{"thread":{"id":"1472","subject":"[PATCH] Missing test_done","startedAt":"2005-08-11T02:15:02Z","lastAt":"2005-08-11T02:15:02Z","messageCount":1,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7047","messageId":"1123726502.18644.16.camel@dv","threadId":"1472","inReplyTo":null,"subject":"[PATCH] Missing test_done","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-08-11T02:15:02Z","receivedAt":"2005-08-11T02:15:02Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello!\n\nAll test scripts should end with test_done, which reports the test\nresults.  In the future, it could be used for other purposes, e.g. to\ndistinguish graceful end from \"exit\" in a test.  This patch fixes\nscripts that don't call test_done.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/t/t2003-checkout-cache-mkdir.sh b/t/t2003-checkout-cache-mkdir.sh\n--- a/t/t2003-checkout-cache-mkdir.sh\n+++ b/t/t2003-checkout-cache-mkdir.sh\n@@ -93,3 +93,4 @@ test_expect_success \\\n      test -d tmp-path1 &&\n      test -f tmp-path1/file1'\n \n+test_done\ndiff --git a/t/t3001-ls-files-others-exclude.sh b/t/t3001-ls-files-others-exclude.sh\n--- a/t/t3001-ls-files-others-exclude.sh\n+++ b/t/t3001-ls-files-others-exclude.sh\n@@ -66,3 +66,5 @@ test_expect_success \\\n        --exclude-from=.git/ignore \\\n        >output &&\n      diff -u expect output'\n+\n+test_done\ndiff --git a/t/t4101-apply-nonl.sh b/t/t4101-apply-nonl.sh\n--- a/t/t4101-apply-nonl.sh\n+++ b/t/t4101-apply-nonl.sh\n@@ -30,3 +30,5 @@ do\n \t\"git-apply <diff.$i-$j && diff frotz.$j frotz\"\n   done\n done\n+\n+test_done\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -52,3 +52,5 @@ test_expect_success \\\n \tgit-send-pack --force ./victim/.git/ master &&\n \tcmp victim/.git/refs/heads/master .git/refs/heads/master\n '\n+\n+test_done\n\n\n-- \nRegards,\nPavel Roskin\n"}]}