{"thread":{"id":"14715","subject":"[PATCH] Allow installing in the traditional way","startedAt":"2008-07-28T07:09:51Z","lastAt":"2008-07-28T20:00:44Z","messageCount":2,"participants":["Junio C Hamano","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"85258","messageId":"7vod4itrgg.fsf@gitster.siamese.dyndns.org","threadId":"14715","inReplyTo":null,"subject":"[PATCH] Allow installing in the traditional way","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-28T07:09:51Z","receivedAt":"2008-07-28T07:09:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"In an earlier commit c70a8d9 (Makefile: Do not install a copy of 'git' in\n$(gitexecdir), 2008-07-21), we tried to avoid installing two git, one in\n/usr/bin/git and the other in /usr/libexec/git-core/git.  It mistakenly\nremoved the only copy of git when gitexecdir and bindir are set to the\nsame directory, i.e. the traditional layout.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n Makefile |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 7e30b30..52c67c1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1362,7 +1362,10 @@ endif\n \t\tcp \"$$bindir/git$X\" \"$$execdir/git$X\"; \\\n \tfi && \\\n \t{ $(foreach p,$(BUILT_INS), $(RM) \"$$execdir/$p\" && ln \"$$execdir/git$X\" \"$$execdir/$p\" ;) } && \\\n-\t$(RM) \"$$execdir/git$X\" && \\\n+\tif test \"z$$bindir\" != \"z$$execdir\"; \\\n+\tthen \\\n+\t\t$(RM) \"$$execdir/git$X\"; \\\n+\tfi && \\\n \t./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n \n install-doc:\n-- \n1.6.0.rc1\n"},{"id":"85328","messageId":"1217275244.488e256c06da0@webmail.nextra.at","threadId":"14715","inReplyTo":"7vod4itrgg.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Allow installing in the traditional way","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2008-07-28T20:00:44Z","receivedAt":"2008-07-28T20:00:44Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Zitat von Junio C Hamano <gitster@pobox.com>:\n\n> In an earlier commit c70a8d9 (Makefile: Do not install a copy of 'git' in\n> $(gitexecdir), 2008-07-21), we tried to avoid installing two git, one in\n> /usr/bin/git and the other in /usr/libexec/git-core/git.  It mistakenly\n> removed the only copy of git when gitexecdir and bindir are set to the\n> same directory, i.e. the traditional layout.\n\nThe patch looks fine. Thanks for fixing up my mistakes.\n\n-- Hannes\n"}]}