{"thread":{"id":"14670","subject":"[PATCH] bash completion: Add long options for 'git describe'","startedAt":"2008-07-25T10:02:50Z","lastAt":"2008-07-26T21:52:10Z","messageCount":6,"participants":["Thomas Rast","SZEDER Gábor","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84854","messageId":"1216980170-14136-1-git-send-email-trast@student.ethz.ch","threadId":"14670","inReplyTo":null,"subject":"[PATCH] bash completion: Add long options for 'git describe'","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2008-07-25T10:02:50Z","receivedAt":"2008-07-25T10:02:50Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"---\n\nIt seemed so tedious to type --always so I wrote this instead ;-)\n\n contrib/completion/git-completion.bash |   11 +++++++++++\n 1 files changed, 11 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3b04934..421431c 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -665,6 +665,17 @@ _git_commit ()\n \n _git_describe ()\n {\n+\t__git_has_doubledash && return\n+\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"\n+\t\t\t--all --tags --contains --abbrev= --candidates=\n+\t\t\t--exact-match --debug --long --match --always\n+\t\t\t\"\n+\t\treturn\n+\tesac\n \t__gitcomp \"$(__git_refs)\"\n }\n \n-- \n1.6.0.rc0.48.g3fa0a\n"},{"id":"84879","messageId":"20080725131532.GB6701@neumann","threadId":"14670","inReplyTo":"1216980170-14136-1-git-send-email-trast@student.ethz.ch","subject":"Re: [PATCH] bash completion: Add long options for 'git describe'","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2008-07-25T13:15:32Z","receivedAt":"2008-07-25T13:15:32Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nOn Fri, Jul 25, 2008 at 12:02:50PM +0200, Thomas Rast wrote:\n> ---\nSigned off by?\n\n>  _git_describe ()\n>  {\n> +\t__git_has_doubledash && return\nThis line is superfluous, because 'git describe' does not have any path\narguments.\n\nGábor\n"},{"id":"84897","messageId":"20080725162028.GB21117@spearce.org","threadId":"14670","inReplyTo":"20080725131532.GB6701@neumann","subject":"Re: [PATCH] bash completion: Add long options for 'git describe'","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-07-25T16:20:28Z","receivedAt":"2008-07-25T16:20:28Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"SZEDER GGGbor <szeder@ira.uka.de> wrote:\n> On Fri, Jul 25, 2008 at 12:02:50PM +0200, Thomas Rast wrote:\n> > ---\n> Signed off by?\n> \n> >  _git_describe ()\n> >  {\n> > +\t__git_has_doubledash && return\n> This line is superfluous, because 'git describe' does not have any path\n> arguments.\n\nYup.  Aside from the two items described above (mising SOB line\nand the unnecessary double dash test) this patch looks fine.\n\n-- \nShawn.\n"},{"id":"85036","messageId":"200807261225.13949.trast@student.ethz.ch","threadId":"14670","inReplyTo":"20080725162028.GB21117@spearce.org","subject":"Re: [PATCH] bash completion: Add long options for 'git describe'","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2008-07-26T10:25:05Z","receivedAt":"2008-07-26T10:25:05Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Shawn O. Pearce wrote:\n> SZEDER GGGbor <szeder@ira.uka.de> wrote:\n> > >  _git_describe ()\n> > >  {\n> > > +\t__git_has_doubledash && return\n> > This line is superfluous, because 'git describe' does not have any path\n> > arguments.\n> \n> Yup.  Aside from the two items described above (mising SOB line\n> and the unnecessary double dash test) this patch looks fine.\n\nI suppose you're right.  It does (empirically) attempt to parse\nanything following a -- as a revision argument, but similar commands\nlike cherry-pick don't handle the -- specially either.\n\nI'll resend a fixed version.\n\n- Thomas\n\n-- \nThomas Rast\ntrast@student.ethz.ch\n\n"},{"id":"85037","messageId":"1217068016-10954-1-git-send-email-trast@student.ethz.ch","threadId":"14670","inReplyTo":"20080725162028.GB21117@spearce.org","subject":"[PATCH] bash completion: Add long options for 'git describe'","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2008-07-26T10:26:56Z","receivedAt":"2008-07-26T10:26:56Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Signed-off-by: Thomas Rast <trast@student.ethz.ch>\n---\n contrib/completion/git-completion.bash |    9 +++++++++\n 1 files changed, 9 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3b04934..4ae8b36 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -665,6 +665,15 @@ _git_commit ()\n \n _git_describe ()\n {\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"\n+\t\t\t--all --tags --contains --abbrev= --candidates=\n+\t\t\t--exact-match --debug --long --match --always\n+\t\t\t\"\n+\t\treturn\n+\tesac\n \t__gitcomp \"$(__git_refs)\"\n }\n \n-- \n1.6.0.rc0.50.g6a66e\n"},{"id":"85121","messageId":"20080726215210.GC16219@spearce.org","threadId":"14670","inReplyTo":"1217068016-10954-1-git-send-email-trast@student.ethz.ch","subject":"Re: [PATCH] bash completion: Add long options for 'git describe'","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-07-26T21:52:10Z","receivedAt":"2008-07-26T21:52:10Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Thomas Rast <trast@student.ethz.ch> wrote:\n> Signed-off-by: Thomas Rast <trast@student.ethz.ch>\n\nMuch shorter, thanks.\n\nAcked-by: Shawn O. Pearce <spearce@spearce.org>\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 3b04934..4ae8b36 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -665,6 +665,15 @@ _git_commit ()\n>  \n>  _git_describe ()\n>  {\n> +\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n> +\tcase \"$cur\" in\n> +\t--*)\n> +\t\t__gitcomp \"\n> +\t\t\t--all --tags --contains --abbrev= --candidates=\n> +\t\t\t--exact-match --debug --long --match --always\n> +\t\t\t\"\n> +\t\treturn\n> +\tesac\n>  \t__gitcomp \"$(__git_refs)\"\n>  }\n>  \n\n-- \nShawn.\n"}]}