{"thread":{"id":"14654","subject":"[StGit PATCH] Fixed default install location","startedAt":"2008-07-24T10:20:31Z","lastAt":"2008-08-05T21:10:41Z","messageCount":8,"participants":["Daniel White","Karl Hasselström","Catalin Marinas"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84700","messageId":"20080724202031.55dec8e8@whitehouse.id.au","threadId":"14654","inReplyTo":null,"subject":"[StGit PATCH] Fixed default install location","fromName":"Daniel White","fromEmail":"daniel@whitehouse.id.au","sentAt":"2008-07-24T10:20:31Z","receivedAt":"2008-07-24T10:20:31Z","isPatch":true,"sender":{"key":"daniel@whitehouse.id.au","avatar":"https://gravatar.com/avatar/dbe1b9de7de21d3d435a26f487adba1e4cb11ecf7b0c9beaa5a8ec792813e7e1?d=mp&s=160"},"body":"Originally broken by addition of Debian package support.\n\nSigned-off-by: Daniel White <daniel@whitehouse.id.au>\n---\n\nThe default installation direction is actually /usr at present despite\nwhat 'INSTALL' says.\n\nThe 'debian/rules' makefile specifies the prefix as /usr so doesn't\nseem to depend on this. I've tested the resulting debian package and\neverything is still installed correctly under /usr.\n\n setup.cfg |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/setup.cfg b/setup.cfg\nindex 1eb8e9b..4359033 100644\n--- a/setup.cfg\n+++ b/setup.cfg\n@@ -1,2 +1,2 @@\n [install]\n-prefix: /usr\n+prefix: ~\n-- \n1.5.6.2\n"},{"id":"84782","messageId":"20080724194548.GA15665@diana.vm.bytemark.co.uk","threadId":"14654","inReplyTo":"20080724202031.55dec8e8@whitehouse.id.au","subject":"Re: [StGit PATCH] Fixed default install location","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-07-24T19:45:48Z","receivedAt":"2008-07-24T19:45:48Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-07-24 20:20:31 +1000, Daniel White wrote:\n\n> Originally broken by addition of Debian package support.\n>\n> Signed-off-by: Daniel White <daniel@whitehouse.id.au>\n> ---\n>\n> The default installation direction is actually /usr at present\n> despite what 'INSTALL' says.\n>\n> The 'debian/rules' makefile specifies the prefix as /usr so doesn't\n> seem to depend on this. I've tested the resulting debian package and\n> everything is still installed correctly under /usr.\n\nLooks correct to me; I'll queue it up in kha/stable. Catalin, do you\nhave any issues with it?\n\nThose extra comments should have been part of the commit message,\nthough. I'll fix that.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"84955","messageId":"b0943d9e0807251446w1e9ed73erfa7c1638191d88a@mail.gmail.com","threadId":"14654","inReplyTo":"20080724202031.55dec8e8@whitehouse.id.au","subject":"Re: [StGit PATCH] Fixed default install location","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2008-07-25T21:46:27Z","receivedAt":"2008-07-25T21:46:27Z","isPatch":true,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"2008/7/24 Daniel White <daniel@whitehouse.id.au>:\n> Originally broken by addition of Debian package support.\n>\n> Signed-off-by: Daniel White <daniel@whitehouse.id.au>\n> ---\n>\n> The default installation direction is actually /usr at present despite\n> what 'INSTALL' says.\n>\n> The 'debian/rules' makefile specifies the prefix as /usr so doesn't\n> seem to depend on this. I've tested the resulting debian package and\n> everything is still installed correctly under /usr.\n\nI also use \"python setup.py bdist_rpm\" when releasing, I think it will\nget confused by a different prefix.\n\n-- \nCatalin\n"},{"id":"85156","messageId":"20080727162750.25b7cdf3@whitehouse.id.au","threadId":"14654","inReplyTo":"b0943d9e0807251446w1e9ed73erfa7c1638191d88a@mail.gmail.com","subject":"Re: [StGit PATCH] Fixed default install location","fromName":"Daniel White","fromEmail":"daniel@whitehouse.id.au","sentAt":"2008-07-27T06:27:50Z","receivedAt":"2008-07-27T06:27:50Z","isPatch":true,"sender":{"key":"daniel@whitehouse.id.au","avatar":"https://gravatar.com/avatar/dbe1b9de7de21d3d435a26f487adba1e4cb11ecf7b0c9beaa5a8ec792813e7e1?d=mp&s=160"},"body":"\"Catalin Marinas\" <catalin.marinas@gmail.com> wrote:\n> \n> I also use \"python setup.py bdist_rpm\" when releasing, I think it will\n> get confused by a different prefix.\n> \n\nNot being familiar with distutils, I didn't even see that use case.\n\nRegardless, the instructions are incorrect and the behaviour surprising.\nWhen I installed this in a cygwin environment, it went on to clobber\nmy system directories.\n\nWould it be more useful to have the Makefile handle the general case and\nsetup.py for more specialised cases, such as generating an rpm?\n\nI've thrown some patches together that does some of this.  I can tidy\nthese up and put them in a public repository if this sounds like a\nreasonable plan of attack.\n\n-- \nDaniel White\n"},{"id":"85157","messageId":"b0943d9e0807270121x43b0a454g1042c0cfe650f2c1@mail.gmail.com","threadId":"14654","inReplyTo":"20080727162750.25b7cdf3@whitehouse.id.au","subject":"Re: [StGit PATCH] Fixed default install location","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2008-07-27T08:21:06Z","receivedAt":"2008-07-27T08:21:06Z","isPatch":true,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"2008/7/27 Daniel White <daniel@whitehouse.id.au>:\n> \"Catalin Marinas\" <catalin.marinas@gmail.com> wrote:\n>>\n>> I also use \"python setup.py bdist_rpm\" when releasing, I think it will\n>> get confused by a different prefix.\n>\n> Not being familiar with distutils, I didn't even see that use case.\n\nI use \"python setup.py bdist_rpm\", though passing --prefix would\nprobably fix it.\n\n> Regardless, the instructions are incorrect and the behaviour surprising.\n> When I installed this in a cygwin environment, it went on to clobber\n> my system directories.\n>\n> Would it be more useful to have the Makefile handle the general case and\n> setup.py for more specialised cases, such as generating an rpm?\n\nI agree.\n\n> I've thrown some patches together that does some of this.  I can tidy\n> these up and put them in a public repository if this sounds like a\n> reasonable plan of attack.\n\nYes, it is. Please base them on my (or Karl's) latest git tree as I\nalready merged this patch.\n\nThanks.\n\n-- \nCatalin\n"},{"id":"85733","messageId":"20080731162916.14ffc9fd@whitehouse.id.au","threadId":"14654","inReplyTo":"b0943d9e0807270121x43b0a454g1042c0cfe650f2c1@mail.gmail.com","subject":"[StGit RFC] Pull request for build/install work","fromName":"Daniel White","fromEmail":"daniel@whitehouse.id.au","sentAt":"2008-07-31T06:29:16Z","receivedAt":"2008-07-31T06:29:16Z","isPatch":false,"sender":{"key":"daniel@whitehouse.id.au","avatar":"https://gravatar.com/avatar/dbe1b9de7de21d3d435a26f487adba1e4cb11ecf7b0c9beaa5a8ec792813e7e1?d=mp&s=160"},"body":"Changes are on my experimental branch\nat git://repo.or.cz/stgit/dwhite.git.\n\nFixed some old cruft causing problems when building/installing the\ndocumentation and added new targets for streamlining the process.  The\nend result being fairly similar to Git's install process.\n\nDaniel White (7):\n      Fix Makefile to correctly pass prefix option\n      Remove variables regarding section 7 man pages\n      Fix default install location for manpages\n      Add install-doc target to makefile\n      Add install-html target to makefile\n      Remove installation of documentation from setup.py\n      Updated INSTALL with documentation of Makefile\n\n Documentation/Makefile |   25 ++++++++++++-------------\n INSTALL                |   15 ++++++++++-----\n Makefile               |   12 +++++++++---\n setup.py               |    2 +-\n 4 files changed, 32 insertions(+), 22 deletions(-)\n\n-- \nDaniel White\n"},{"id":"86191","messageId":"20080804143838.GD12232@diana.vm.bytemark.co.uk","threadId":"14654","inReplyTo":"20080731162916.14ffc9fd@whitehouse.id.au","subject":"Re: [StGit RFC] Pull request for build/install work","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-08-04T14:38:38Z","receivedAt":"2008-08-04T14:38:38Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-07-31 16:29:16 +1000, Daniel White wrote:\n\n> Changes are on my experimental branch\n> at git://repo.or.cz/stgit/dwhite.git.\n\nThanks. Have merged, and will push out sometime soon.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"86296","messageId":"b0943d9e0808051410v39a95a66se053ea8c764e484e@mail.gmail.com","threadId":"14654","inReplyTo":"20080804143838.GD12232@diana.vm.bytemark.co.uk","subject":"Re: [StGit RFC] Pull request for build/install work","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2008-08-05T21:10:41Z","receivedAt":"2008-08-05T21:10:41Z","isPatch":false,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"2008/8/4 Karl Hasselström <kha@treskal.com>:\n> On 2008-07-31 16:29:16 +1000, Daniel White wrote:\n>\n>> Changes are on my experimental branch\n>> at git://repo.or.cz/stgit/dwhite.git.\n>\n> Thanks. Have merged, and will push out sometime soon.\n\nThanks, both to Daniel and Karl (for merging them).\n\n-- \nCatalin\n"}]}