{"thread":{"id":"14648","subject":"[PATCH] t6030 (bisect): work around Mac OS X \"ls\"","startedAt":"2008-07-24T01:37:35Z","lastAt":"2008-07-27T05:10:19Z","messageCount":12,"participants":["Jonathan Nieder","Christian Couder","Mike Hommey","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84661","messageId":"Pine.GSO.4.62.0807232014030.14945@harper.uchicago.edu","threadId":"14648","inReplyTo":null,"subject":"[PATCH] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@uchicago.edu","sentAt":"2008-07-24T01:37:35Z","receivedAt":"2008-07-24T01:37:35Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\nstatus when asked to list nonexistent files.  Unfortunately,\n/bin/ls on Mac OS X 10.3 exits with exit code 0.  So use \"echo\n<shell glob pattern>\" and grep instead.\n\nSigned-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n---\n\tWith this change, all the non-git-svn tests pass on my machine.\n\tI think the fix is portable but I do not have the experience to\n\tbe sure.  So I would be happier if someone looks it over.\n\n t/t6030-bisect-porcelain.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\nindex 0626544..d19fc1c 100755\n--- a/t/t6030-bisect-porcelain.sh\n+++ b/t/t6030-bisect-porcelain.sh\n@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '\n \ttest_must_fail git bisect start foo $HASH1 -- &&\n \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n-\ttest_must_fail ls .git/BISECT_* &&\n+\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n \tgit bisect start &&\n \ttest_must_fail git bisect good foo $HASH1 &&\n \ttest_must_fail git bisect good $HASH1 bar &&\n-- \n1.5.6.3.549.g8ca11\n"},{"id":"84673","messageId":"200807240757.26290.chriscool@tuxfamily.org","threadId":"14648","inReplyTo":"Pine.GSO.4.62.0807232014030.14945@harper.uchicago.edu","subject":"Re: [PATCH] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-24T05:57:26Z","receivedAt":"2008-07-24T05:57:26Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le jeudi 24 juillet 2008, Jonathan Nieder a écrit :\n> t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> status when asked to list nonexistent files.  Unfortunately,\n> /bin/ls on Mac OS X 10.3 exits with exit code 0.  So use \"echo\n> <shell glob pattern>\" and grep instead.\n>\n> Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n> ---\n> \tWith this change, all the non-git-svn tests pass on my machine.\n> \tI think the fix is portable but I do not have the experience to\n> \tbe sure.  So I would be happier if someone looks it over.\n>\n>  t/t6030-bisect-porcelain.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\n> index 0626544..d19fc1c 100755\n> --- a/t/t6030-bisect-porcelain.sh\n> +++ b/t/t6030-bisect-porcelain.sh\n> @@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk\n> instead of revs' ' test_must_fail git bisect start foo $HASH1 -- &&\n>  \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n>  \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n> -\ttest_must_fail ls .git/BISECT_* &&\n> +\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n\nPerhaps the following is simpler:\n\n+\ttest -z \"$(ls .git/BISECT_*)\" &&\n\n>  \tgit bisect start &&\n>  \ttest_must_fail git bisect good foo $HASH1 &&\n>  \ttest_must_fail git bisect good $HASH1 bar &&\n\nThanks,\nChristian.\n"},{"id":"84675","messageId":"20080724060647.GA24587@glandium.org","threadId":"14648","inReplyTo":"200807240757.26290.chriscool@tuxfamily.org","subject":"Re: [PATCH] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2008-07-24T06:06:47Z","receivedAt":"2008-07-24T06:06:47Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:\n> Le jeudi 24 juillet 2008, Jonathan Nieder a écrit :\n> > t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> > status when asked to list nonexistent files.  Unfortunately,\n> > /bin/ls on Mac OS X 10.3 exits with exit code 0.  So use \"echo\n> > <shell glob pattern>\" and grep instead.\n> >\n> > Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n> > ---\n> > \tWith this change, all the non-git-svn tests pass on my machine.\n> > \tI think the fix is portable but I do not have the experience to\n> > \tbe sure.  So I would be happier if someone looks it over.\n> >\n> >  t/t6030-bisect-porcelain.sh |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> >\n> > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\n> > index 0626544..d19fc1c 100755\n> > --- a/t/t6030-bisect-porcelain.sh\n> > +++ b/t/t6030-bisect-porcelain.sh\n> > @@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk\n> > instead of revs' ' test_must_fail git bisect start foo $HASH1 -- &&\n> >  \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n> >  \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n> > -\ttest_must_fail ls .git/BISECT_* &&\n> > +\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n> \n> Perhaps the following is simpler:\n> \n> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n\nThat is still a useless use of ls ;)\n\nMike\n"},{"id":"84681","messageId":"Pine.GSO.4.62.0807240233310.27074@harper.uchicago.edu","threadId":"14648","inReplyTo":"20080724060647.GA24587@glandium.org","subject":"[PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@uchicago.edu","sentAt":"2008-07-24T07:43:51Z","receivedAt":"2008-07-24T07:43:51Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\nstatus when asked to list nonexistent files.  Unfortunately,\n/bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\nits output instead.\n\nSigned-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n---\n\nMike Hommey wrote:\n\n> On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:\n>> Le jeudi 24 juillet 2008, Jonathan Nieder a �crit :\n>>> -\ttest_must_fail ls .git/BISECT_* &&\n>>> +\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n>> \n>> Perhaps the following is simpler:\n>> \n>> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n> \n> That is still a useless use of ls ;)\n\nIt is much better than what I wrote, at least.\n\nGood night (well, good morning I guess), and thanks.\n\n t/t6030-bisect-porcelain.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\nindex 0626544..244fda6 100755\n--- a/t/t6030-bisect-porcelain.sh\n+++ b/t/t6030-bisect-porcelain.sh\n@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '\n \ttest_must_fail git bisect start foo $HASH1 -- &&\n \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n-\ttest_must_fail ls .git/BISECT_* &&\n+\ttest -z \"$(ls .git/BISECT_* 2>/dev/null)\" &&\n \tgit bisect start &&\n \ttest_must_fail git bisect good foo $HASH1 &&\n \ttest_must_fail git bisect good $HASH1 bar &&\n-- \n1.5.6.3.549.g8ca11\n"},{"id":"84743","messageId":"20080724165434.GA26660@glandium.org","threadId":"14648","inReplyTo":"Pine.GSO.4.62.0807240233310.27074@harper.uchicago.edu","subject":"Re: [PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2008-07-24T16:54:34Z","receivedAt":"2008-07-24T16:54:34Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:\n> t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> status when asked to list nonexistent files.  Unfortunately,\n> /bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\n> its output instead.\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n> ---\n> \n> Mike Hommey wrote:\n> \n> > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:\n> >> Le jeudi 24 juillet 2008, Jonathan Nieder a �crit :\n> >>> -\ttest_must_fail ls .git/BISECT_* &&\n> >>> +\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n> >> \n> >> Perhaps the following is simpler:\n> >> \n> >> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n> > \n> > That is still a useless use of ls ;)\n> \n> It is much better than what I wrote, at least.\n\nBut could also be written with echo instead of ls.\n\nMike\n"},{"id":"84756","messageId":"alpine.DEB.1.00.0807241842030.8986@racer","threadId":"14648","inReplyTo":"20080724165434.GA26660@glandium.org","subject":"Re: [PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-24T17:44:12Z","receivedAt":"2008-07-24T17:44:12Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 24 Jul 2008, Mike Hommey wrote:\n\n> On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:\n>\n> > Mike Hommey wrote:\n> > \n> > > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:\n> > >\n> > >> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n> > > \n> > > That is still a useless use of ls ;)\n> > \n> > It is much better than what I wrote, at least.\n> \n> But could also be written with echo instead of ls.\n\nSure, but then it looks uglier:\n\n\t\ttest \".git/BISECT_*\" = \"$(echo .git/BISECT_*)\" &&\n\nand it is much easier to hide a typo there.\n\nAnd now the big question: is it performance critical?  Or is obvious \ncorrectness the highest goal here?\n\nHth,\nDscho\n"},{"id":"84757","messageId":"Pine.GSO.4.62.0807241233190.16518@harper.uchicago.edu","threadId":"14648","inReplyTo":"20080724165434.GA26660@glandium.org","subject":"[PATCH v3] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@uchicago.edu","sentAt":"2008-07-24T17:51:40Z","receivedAt":"2008-07-24T17:51:40Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\nstatus when asked to list nonexistent files.  Unfortunately,\n/bin/ls on Mac OS X 10.3 exits with exit code 0.  So use \"echo\"\ninstead.\n\nSigned-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n---\n Mike Hommey wrote:\n\n >>>> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n >>> That is still a useless use of ls ;)\n >> It is much better than what I wrote, at least.\n > But could also be written with echo instead of ls.\n\n How about this?  (The echo is necessary because the argument\n to a case statement does not undergo filename expansion.)\n\n t/t6030-bisect-porcelain.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\nindex 0626544..b6841fe 100755\n--- a/t/t6030-bisect-porcelain.sh\n+++ b/t/t6030-bisect-porcelain.sh\n@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '\n \ttest_must_fail git bisect start foo $HASH1 -- &&\n \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n-\ttest_must_fail ls .git/BISECT_* &&\n+\tcase $(echo .git/BISECT_*) in *\\*) ;; *) false ;; esac &&\n \tgit bisect start &&\n \ttest_must_fail git bisect good foo $HASH1 &&\n \ttest_must_fail git bisect good $HASH1 bar &&\n-- \n1.5.6.3.549.g8ca11\n"},{"id":"84763","messageId":"Pine.GSO.4.62.0807241307020.17634@harper.uchicago.edu","threadId":"14648","inReplyTo":"Pine.GSO.4.62.0807241233190.16518@harper.uchicago.edu","subject":"Re: [PATCH v3] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@uchicago.edu","sentAt":"2008-07-24T18:16:26Z","receivedAt":"2008-07-24T18:16:26Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jonathan Nieder wrote:\n\n> -\ttest_must_fail ls .git/BISECT_* &&\n> +\tcase $(echo .git/BISECT_*) in *\\*) ;; *) false ;; esac &&\n\nActually, if we want to go that route, I prefer the version Dscho gave.\nSo please ignore my patch v3; I'd rather people choose between\nChristian's and Dscho's suggestions.\n\nPersonally, without knowing how much time avoiding the ls saves, I\nam not sure which is best.  Certainly the version with \"ls\" is clearer,\nwhich is most important; but if the time savings (of avoiding such\nconstructs generally) are significant, then that is very much worthwhile\n- a faster test suite can be run more often.\n\nJonathan\n"},{"id":"85134","messageId":"200807270519.41441.chriscool@tuxfamily.org","threadId":"14648","inReplyTo":"Pine.GSO.4.62.0807240233310.27074@harper.uchicago.edu","subject":"Re: [PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-27T03:19:41Z","receivedAt":"2008-07-27T03:19:41Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le jeudi 24 juillet 2008, Jonathan Nieder a écrit :\n> t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> status when asked to list nonexistent files.  Unfortunately,\n> /bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\n> its output instead.\n>\n> Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n\nAcked-by: Christian Couder <chriscool@tuxfamily.org>\n\nThanks,\nChristian.\n\n> ---\n>\n> Mike Hommey wrote:\n> > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:\n> >> Le jeudi 24 juillet 2008, Jonathan Nieder a écrit :\n> >>> -\ttest_must_fail ls .git/BISECT_* &&\n> >>> +\techo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&\n> >>\n> >> Perhaps the following is simpler:\n> >>\n> >> +\ttest -z \"$(ls .git/BISECT_*)\" &&\n> >\n> > That is still a useless use of ls ;)\n>\n> It is much better than what I wrote, at least.\n>\n> Good night (well, good morning I guess), and thanks.\n>\n>  t/t6030-bisect-porcelain.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\n> index 0626544..244fda6 100755\n> --- a/t/t6030-bisect-porcelain.sh\n> +++ b/t/t6030-bisect-porcelain.sh\n> @@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk\n> instead of revs' ' test_must_fail git bisect start foo $HASH1 -- &&\n>  \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n>  \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n> -\ttest_must_fail ls .git/BISECT_* &&\n> +\ttest -z \"$(ls .git/BISECT_* 2>/dev/null)\" &&\n>  \tgit bisect start &&\n>  \ttest_must_fail git bisect good foo $HASH1 &&\n>  \ttest_must_fail git bisect good $HASH1 bar &&\n"},{"id":"85137","messageId":"200807270604.16581.chriscool@tuxfamily.org","threadId":"14648","inReplyTo":"200807270519.41441.chriscool@tuxfamily.org","subject":"Re: [PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-27T04:04:16Z","receivedAt":"2008-07-27T04:04:16Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le dimanche 27 juillet 2008, Christian Couder a écrit :\n> Le jeudi 24 juillet 2008, Jonathan Nieder a écrit :\n> > t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> > status when asked to list nonexistent files.  Unfortunately,\n> > /bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\n> > its output instead.\n> >\n> > Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n>\n> Acked-by: Christian Couder <chriscool@tuxfamily.org>\n\nIt seems that there is a problem with the message itself though. When I \"git \nam\" it, I get:\n\nfatal: cannot convert from x-unknown to utf-8\n\nIt seems that it is mime encoded or something and my git \n(1.6.0.rc0.80.gf54f0) doesn't like it.\n\nRegards,\nChristian.\n"},{"id":"85143","messageId":"Pine.GSO.4.62.0807262343510.426@harper.uchicago.edu","threadId":"14648","inReplyTo":"200807270604.16581.chriscool@tuxfamily.org","subject":"[PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@uchicago.edu","sentAt":"2008-07-27T04:53:30Z","receivedAt":"2008-07-27T04:53:30Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\nstatus when asked to list nonexistent files.  Unfortunately,\n/bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\nits output instead.\n\nSigned-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\nAcked-by: Christian Couder <chriscool@tuxfamily.org>\n---\nOn Sun, 27 Jul 2008, Christian Couder wrote:\n\n> It seems that there is a problem with the message itself though. When I \"git \n> am\" it, I get:\n> \n> fatal: cannot convert from x-unknown to utf-8\n\nHmm, not sure what happened.  Maybe resending it will work...\n\n t/t6030-bisect-porcelain.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\nindex 0626544..244fda6 100755\n--- a/t/t6030-bisect-porcelain.sh\n+++ b/t/t6030-bisect-porcelain.sh\n@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '\n \ttest_must_fail git bisect start foo $HASH1 -- &&\n \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n-\ttest_must_fail ls .git/BISECT_* &&\n+\ttest -z \"$(ls .git/BISECT_* 2>/dev/null)\" &&\n \tgit bisect start &&\n \ttest_must_fail git bisect good foo $HASH1 &&\n \ttest_must_fail git bisect good $HASH1 bar &&\n-- \n1.5.5.1.328.gbfcc6\n"},{"id":"85144","messageId":"200807270710.19974.chriscool@tuxfamily.org","threadId":"14648","inReplyTo":"Pine.GSO.4.62.0807262343510.426@harper.uchicago.edu","subject":"Re: [PATCH v2] t6030 (bisect): work around Mac OS X \"ls\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-27T05:10:19Z","receivedAt":"2008-07-27T05:10:19Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le dimanche 27 juillet 2008, Jonathan Nieder a écrit :\n> t6030-bisect-porcelain.sh relies on \"ls\" exiting with nonzero\n> status when asked to list nonexistent files.  Unfortunately,\n> /bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at\n> its output instead.\n>\n> Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>\n> Acked-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>\n> On Sun, 27 Jul 2008, Christian Couder wrote:\n> > It seems that there is a problem with the message itself though. When I\n> > \"git am\" it, I get:\n> >\n> > fatal: cannot convert from x-unknown to utf-8\n>\n> Hmm, not sure what happened.  Maybe resending it will work...\n\nYes, this one works fine.\n\nThanks,\nChristian.\n\n>\n>  t/t6030-bisect-porcelain.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh\n> index 0626544..244fda6 100755\n> --- a/t/t6030-bisect-porcelain.sh\n> +++ b/t/t6030-bisect-porcelain.sh\n> @@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk\n> instead of revs' ' test_must_fail git bisect start foo $HASH1 -- &&\n>  \ttest_must_fail git bisect start $HASH4 $HASH1 bar -- &&\n>  \ttest -z \"$(git for-each-ref \"refs/bisect/*\")\" &&\n> -\ttest_must_fail ls .git/BISECT_* &&\n> +\ttest -z \"$(ls .git/BISECT_* 2>/dev/null)\" &&\n>  \tgit bisect start &&\n>  \ttest_must_fail git bisect good foo $HASH1 &&\n>  \ttest_must_fail git bisect good $HASH1 bar &&\n"}]}