{"thread":{"id":"14643","subject":"[PATCH] Make non-static functions, that may be static, static","startedAt":"2008-07-23T23:09:35Z","lastAt":"2008-07-23T23:09:35Z","messageCount":1,"participants":["Stephan Beyer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84637","messageId":"1216854575-25893-1-git-send-email-s-beyer@gmx.net","threadId":"14643","inReplyTo":null,"subject":"[PATCH] Make non-static functions, that may be static, static","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-07-23T23:09:35Z","receivedAt":"2008-07-23T23:09:35Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"Signed-off-by: Stephan Beyer <s-beyer@gmx.net>\n---\n\nOr are there any reasons against that? :)\n\n builtin-commit.c       |    2 +-\n builtin-config.c       |    2 +-\n builtin-for-each-ref.c |    2 +-\n builtin-merge.c        |    2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 97e64de..9d7100c 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -877,7 +877,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)\n \t}\n }\n \n-int git_commit_config(const char *k, const char *v, void *cb)\n+static int git_commit_config(const char *k, const char *v, void *cb)\n {\n \tif (!strcmp(k, \"commit.template\"))\n \t\treturn git_config_string(&template_file, k, v);\ndiff --git a/builtin-config.c b/builtin-config.c\nindex 0cf191a..91fdc49 100644\n--- a/builtin-config.c\n+++ b/builtin-config.c\n@@ -145,7 +145,7 @@ free_strings:\n \treturn ret;\n }\n \n-char *normalize_value(const char *key, const char *value)\n+static char *normalize_value(const char *key, const char *value)\n {\n \tchar *normalized;\n \ndiff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c\nindex 76282ad..445039e 100644\n--- a/builtin-for-each-ref.c\n+++ b/builtin-for-each-ref.c\n@@ -809,7 +809,7 @@ static struct ref_sort *default_sort(void)\n \treturn sort;\n }\n \n-int opt_parse_sort(const struct option *opt, const char *arg, int unset)\n+static int opt_parse_sort(const struct option *opt, const char *arg, int unset)\n {\n \tstruct ref_sort **sort_tail = opt->value;\n \tstruct ref_sort *s;\ndiff --git a/builtin-merge.c b/builtin-merge.c\nindex 8825dcf..e78fa18 100644\n--- a/builtin-merge.c\n+++ b/builtin-merge.c\n@@ -431,7 +431,7 @@ static void merge_name(const char *remote, struct strbuf *msg)\n \t\tsha1_to_hex(remote_head->sha1), remote);\n }\n \n-int git_merge_config(const char *k, const char *v, void *cb)\n+static int git_merge_config(const char *k, const char *v, void *cb)\n {\n \tif (branch && !prefixcmp(k, \"branch.\") &&\n \t\t!prefixcmp(k + 7, branch) &&\n-- \n1.6.0.rc0.102.ga1791\n"}]}