{"thread":{"id":"14618","subject":"[PATCH 01/12] git-grep: read config","startedAt":"2008-07-23T14:55:35Z","lastAt":"2008-07-24T19:16:37Z","messageCount":9,"participants":["Nguyễn Thái Ngọc Duy","Jeff King","Nguyen Thai Ngoc Duy","Sverre Rabbelier","Jay Soffian"],"isPatch":true,"patchVersion":1,"patchTotal":12},"messages":[{"id":"84505","messageId":"20080723145535.GA29053@laptop","threadId":"14618","inReplyTo":null,"subject":"[PATCH 01/12] git-grep: read config","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-07-23T14:55:35Z","receivedAt":"2008-07-23T14:55:35Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"\nSigned-off-by: Nguyễn Thái Ngọc Duy \n---\n builtin-grep.c | 2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/builtin-grep.c b/builtin-grep.c\nindex 631129d..cc9ba6b 100644\n--- a/builtin-grep.c\n+++ b/builtin-grep.c\n@@ -517,6 +517,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix)\n \tconst char **paths = NULL;\n \tint i;\n \n+\tgit_config(git_default_config, NULL);\n+\n \tmemset(&opt, 0, sizeof(opt));\n \topt.prefix_length = (prefix && *prefix) ? strlen(prefix) : 0;\n \topt.relative = 1;\n-- \n1.5.5.GIT\n"},{"id":"84751","messageId":"20080724171519.GA21043@sigill.intra.peff.net","threadId":"14618","inReplyTo":"20080723145535.GA29053@laptop","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-07-24T17:15:19Z","receivedAt":"2008-07-24T17:15:19Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jul 23, 2008 at 09:55:35PM +0700, Nguyễn Thái Ngọc Duy wrote:\n\n> \n> Signed-off-by: Nguyễn Thái Ngọc Duy \n\nThe commit message is a bit lacking...what config are we interested in?\n\n-Peff\n"},{"id":"84769","messageId":"fcaeb9bf0807241145y16bb5f94q9f7e3c09c3184782@mail.gmail.com","threadId":"14618","inReplyTo":"20080724171519.GA21043@sigill.intra.peff.net","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-07-24T18:45:58Z","receivedAt":"2008-07-24T18:45:58Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On 7/25/08, Jeff King wrote:\n> On Wed, Jul 23, 2008 at 09:55:35PM +0700, Nguyen Thai Ngoc Duy wrote:\n>\n> >\n> > Signed-off-by: Nguyễn Thái Ngọc Duy \n>\n>\n> The commit message is a bit lacking...what config are we interested in?\n\ncore.sparsecheckout, but I will probably stay away from config.\n\n-- \nDuy\n"},{"id":"84774","messageId":"bd6139dc0807241153v5055e922p69a176b5b706f98e@mail.gmail.com","threadId":"14618","inReplyTo":"fcaeb9bf0807241145y16bb5f94q9f7e3c09c3184782@mail.gmail.com","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Sverre Rabbelier","fromEmail":"alturin@gmail.com","sentAt":"2008-07-24T18:53:15Z","receivedAt":"2008-07-24T18:53:15Z","isPatch":true,"sender":{"key":"alturin@gmail.com","avatar":null},"body":"On Thu, Jul 24, 2008 at 8:45 PM, Nguyen Thai Ngoc Duy wrote:\n>\n\nSomething went wrong replying here possibly? Or is it just me who is\nreceiving empty messages? (At least the 3rd empty mail I see.)\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"84775","messageId":"20080724185844.GC21186@sigill.intra.peff.net","threadId":"14618","inReplyTo":"fcaeb9bf0807241145y16bb5f94q9f7e3c09c3184782@mail.gmail.com","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-07-24T18:58:44Z","receivedAt":"2008-07-24T18:58:44Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jul 25, 2008 at 01:45:58AM +0700, Nguyen Thai Ngoc Duy wrote:\n\n> > The commit message is a bit lacking...what config are we interested in?\n> \n> core.sparsecheckout, but I will probably stay away from config.\n\nRight, I kind of guessed that from reading the rest of the series. But\nthat sort of \"why\" really should go into the commit message.\n\n-Peff\n"},{"id":"84778","messageId":"fcaeb9bf0807241203yd57e675j964594c501ce59a2@mail.gmail.com","threadId":"14618","inReplyTo":"bd6139dc0807241153v5055e922p69a176b5b706f98e@mail.gmail.com","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-07-24T19:03:59Z","receivedAt":"2008-07-24T19:03:59Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On 7/25/08, Sverre Rabbelier wrote:\n> On Thu, Jul 24, 2008 at 8:45 PM, Nguyen Thai Ngoc Duy wrote:\n> >\n>\n> Something went wrong replying here possibly? Or is it just me who is\n> receiving empty messages? (At least the 3rd empty mail I see.)\n\nI blame gmail MTA or my name's having non-ascii chars in it. Combining\nthose two, it produces base64-encoded messages, which are usually\nrefused by vger.\n-- \nDuy\n"},{"id":"84779","messageId":"fcaeb9bf0807241207y460ebe52o9e9f4958ab07679b@mail.gmail.com","threadId":"14618","inReplyTo":"20080724185844.GC21186@sigill.intra.peff.net","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-07-24T19:07:05Z","receivedAt":"2008-07-24T19:07:05Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On 7/25/08, Jeff King wrote:\n> On Fri, Jul 25, 2008 at 01:45:58AM +0700, Nguyen Thai Ngoc Duy wrote:\n>\n> > > The commit message is a bit lacking...what config are we interested in?\n> >\n> > core.sparsecheckout, but I will probably stay away from config.\n>\n>\n> Right, I kind of guessed that from reading the rest of the series. But\n> that sort of \"why\" really should go into the commit message.\n\nThere was \"why\" in the commit before but I wanted to make the first\ntwo patches independent to this series. Turns out bad, I think :)\n-- \nDuy\n"},{"id":"84780","messageId":"bd6139dc0807241212x4904b7a6x5dc8fa84cca32e18@mail.gmail.com","threadId":"14618","inReplyTo":"fcaeb9bf0807241203yd57e675j964594c501ce59a2@mail.gmail.com","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Sverre Rabbelier","fromEmail":"alturin@gmail.com","sentAt":"2008-07-24T19:12:26Z","receivedAt":"2008-07-24T19:12:26Z","isPatch":true,"sender":{"key":"alturin@gmail.com","avatar":null},"body":"On Thu, Jul 24, 2008 at 9:03 PM, Nguyen Thai Ngoc Duy wrote:\n> On 7/25/08, Sverre Rabbelier wrote:\n>> On Thu, Jul 24, 2008 at 8:45 PM, Nguyen Thai Ngoc Duy wrote:\n>> >\n>>\n>> Something went wrong replying here possibly? Or is it just me who is\n>> receiving empty messages? (At least the 3rd empty mail I see.)\n>\n> I blame gmail MTA or my name's having non-ascii chars in it. Combining\n> those two, it produces base64-encoded messages, which are usually\n> refused by vger.\n\nCuriously enough, in the first mail there -are- non-asci characters in\nyour name, in the 'empty' mail there are non, instead the 'letter\ndecorations' were removed.\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"84781","messageId":"76718490807241216qcb587d0k7e0f96c011b545f3@mail.gmail.com","threadId":"14618","inReplyTo":"bd6139dc0807241153v5055e922p69a176b5b706f98e@mail.gmail.com","subject":"Re: [PATCH 01/12] git-grep: read config","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2008-07-24T19:16:37Z","receivedAt":"2008-07-24T19:16:37Z","isPatch":true,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Thu, Jul 24, 2008 at 2:53 PM, Sverre Rabbelier wrote:\n> On Thu, Jul 24, 2008 at 8:45 PM, Nguyen Thai Ngoc Duy wrote:\n>>\n>\n> Something went wrong replying here possibly? Or is it just me who is\n> receiving empty messages? (At least the 3rd empty mail I see.)\n\nHere's what's going on.\n\n1. Gmail will often send messages as base64 encoded, inline. i.e.:\n\n Content-Type: text/plain; charset=UTF-8\n Content-Transfer-Encoding: base64\n Content-Disposition: inline\n\n2. Majordomo is dumb dumb dumb and adds the standard list footer to\nthe message. It should probably either not add the footer to such\nmessages, or it should do it correctly by base64 decoding them, adding\nthe footer, then re-encoding. Anyway, what it sends out is:\n\n [... prior base64 encoded lines elided ...]\n b3V0LCBidXQgSSB3aWxsIHByb2JhYmx5IHN0YXkgYXdheSBmcm9tIGNvbmZpZy4KCi0tIApEdXkK\n --\n To unsubscribe from this list: send the line \"unsubscribe git\" in\n the body of a message to majordomo@vger.kernel.org\n More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n3. Gmail is dumb dumb dumb and cannot decode such \"corrupted\"\nmessages. They display as completely blank. If you go to gmane you can\nsee the message is fine. (I think gmane strips the majordomo added\nfooter.)\n\nI've filed a bug against gmail multiple times about this. No idea if\nthey'll ever fix it.\n\nI also sent an email to git-owner@vger.kernel.org (which I think was\n/dev/null'ed) offering to patch Majordomo, but got no reply.\n\nI wonder if such a mailing list footer is useful in the first place.\nPerhaps it could just be disabled.\n\nAnyway, my offer to \"fix\" majordomo still stands. Perhaps someone\nknows who I should contact at vger.kernel.org to find out whether\nthey're willing to accept a patch.\n\nj.\n"}]}