{"thread":{"id":"14597","subject":"[PATCH] builtin-commit: Two trivial style-cleanups","startedAt":"2008-07-22T20:40:41Z","lastAt":"2008-07-22T20:40:41Z","messageCount":1,"participants":["Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84363","messageId":"alpine.DEB.1.00.0807222139550.8986@racer","threadId":"14597","inReplyTo":null,"subject":"[PATCH] builtin-commit: Two trivial style-cleanups","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-22T20:40:41Z","receivedAt":"2008-07-22T20:40:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nPierre Habouzit noticed that two variables were not static which should\nhave been, and that adding \"\\n\\n\" is better than adding '\\n' twice.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n\n\tThis was in my queue for half an eternity.\n\n\tOh, and it _is_ meant for inclusion.  On top of master.\n\n builtin-commit.c |    7 +++----\n 1 files changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 97e64de..7434797 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -68,8 +68,8 @@ static enum {\n static char *cleanup_arg;\n \n static int use_editor = 1, initial_commit, in_merge;\n-const char *only_include_assumed;\n-struct strbuf message;\n+static const char *only_include_assumed;\n+static struct strbuf message;\n \n static int opt_parse_m(const struct option *opt, const char *arg, int unset)\n {\n@@ -78,8 +78,7 @@ static int opt_parse_m(const struct option *opt, const char *arg, int unset)\n \t\tstrbuf_setlen(buf, 0);\n \telse {\n \t\tstrbuf_addstr(buf, arg);\n-\t\tstrbuf_addch(buf, '\\n');\n-\t\tstrbuf_addch(buf, '\\n');\n+\t\tstrbuf_addstr(buf, \"\\n\\n\");\n \t}\n \treturn 0;\n }\n-- \n1.6.0.rc0.22.gf2096d.dirty\n"}]}