{"thread":{"id":"14554","subject":"git-shell build error","startedAt":"2008-07-21T00:29:52Z","lastAt":"2008-07-21T01:33:45Z","messageCount":5,"participants":["SungHyun Nam","Stephan Beyer","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"84116","messageId":"g60la4$diu$1@ger.gmane.org","threadId":"14554","inReplyTo":null,"subject":"git-shell build error","fromName":"SungHyun Nam","fromEmail":"namsh@posdata.co.kr","sentAt":"2008-07-21T00:29:52Z","receivedAt":"2008-07-21T00:29:52Z","isPatch":false,"sender":{"key":"namsh@posdata.co.kr","avatar":null},"body":"Hello,\n\nIf NO_SETENV is defined, git-shell cannot be built.\nSimply adding the 'compat/setenv.o' to the make rule fixes the problem.\n\nRegards,\n\n[master] ~/srcs/git[30]$ LANG= make\n LINK git-shell\nUndefined first referenced\n symbol in file\ngitsetenv exec_cmd.o\nld: fatal: Symbol referencing errors. No output written to git-shell\ncollect2: ld returned 1 exit status\nmake: *** [git-shell] Error 1\n"},{"id":"84117","messageId":"1216601017-7871-1-git-send-email-s-beyer@gmx.net","threadId":"14554","inReplyTo":"g60la4$diu$1@ger.gmane.org","subject":"[PATCH] Fix git-shell build error when NO_SETENV is defined","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-07-21T00:43:37Z","receivedAt":"2008-07-21T00:43:37Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"If NO_SETENV is defined, git-shell could not be built.\n\nThanks to SungHyun Nam for the hint.\n\nSigned-off-by: Stephan Beyer \n---\n\nThis was my mistake. I haven't tested with several build options.\nNow I've tested with\n\tNO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1\n\tNO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1\nand compat/setenv.o seems to be the only one that was missing.\n\nRegards.\n\n Makefile | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 2b670d7..b650ee6 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1203,7 +1203,8 @@ git-http-push$X: revision.o http.o http-push.o $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)\n \n-git-shell$X: compat/strlcpy.o abspath.o ctype.o exec_cmd.o quote.o strbuf.o usage.o wrapper.o shell.o\n+git-shell$X: compat/strlcpy.o compat/setenv.o abspath.o ctype.o exec_cmd.o \\\n+\t quote.o strbuf.o usage.o wrapper.o shell.o\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^)\n \n $(LIB_OBJS) $(BUILTIN_OBJS): $(LIB_H)\n-- \n1.5.6.3.390.g7b30\n"},{"id":"84124","messageId":"alpine.DEB.1.00.0807210321190.3305@eeepc-johanness","threadId":"14554","inReplyTo":"1216601017-7871-1-git-send-email-s-beyer@gmx.net","subject":"Re: [PATCH] Fix git-shell build error when NO_SETENV is defined","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-21T01:23:00Z","receivedAt":"2008-07-21T01:23:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 21 Jul 2008, Stephan Beyer wrote:\n\n> If NO_SETENV is defined, git-shell could not be built.\n> \n> Thanks to SungHyun Nam for the hint.\n> \n> Signed-off-by: Stephan Beyer \n> ---\n> \n> This was my mistake. I haven't tested with several build options.\n> Now I've tested with\n> \tNO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1\n> \tNO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1\n> and compat/setenv.o seems to be the only one that was missing.\n\nFunny. It was not 24 hours ago that Hannes reported a related issue. And \nhe was testing with different options.\n\nHis fix to include COMPAT_OBJECTS made much more sense, too, than to pick \nselectively a file here and a file there and then hoping that you catch \nall.\n\nCiao,\nDscho\n"},{"id":"84126","messageId":"20080721012928.GG5950@leksak.fem-net","threadId":"14554","inReplyTo":"alpine.DEB.1.00.0807210321190.3305@eeepc-johanness","subject":"Re: [PATCH] Fix git-shell build error when NO_SETENV is defined","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-07-21T01:29:28Z","receivedAt":"2008-07-21T01:29:28Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"Johannes Schindelin wrote:\n> Funny. It was not 24 hours ago that Hannes reported a related issue. And \n> he was testing with different options.\n\nOh, seems that I have missed that topic. Gna :)\n\nBut fine if everything is working again then.\n\nRegards.\n\n-- \nStephan Beyer , PGP 0x6EDDD207FCC5040F\n"},{"id":"84128","messageId":"alpine.DEB.1.00.0807210333330.3305@eeepc-johanness","threadId":"14554","inReplyTo":"20080721012928.GG5950@leksak.fem-net","subject":"Re: [PATCH] Fix git-shell build error when NO_SETENV is defined","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-21T01:33:45Z","receivedAt":"2008-07-21T01:33:45Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 21 Jul 2008, Stephan Beyer wrote:\n\n> Johannes Schindelin wrote:\n> > Funny. It was not 24 hours ago that Hannes reported a related issue. And \n> > he was testing with different options.\n> \n> Oh, seems that I have missed that topic. Gna :)\n> \n> But fine if everything is working again then.\n\nNo, it is not.\n\nCiao,\nDscho\n"}]}