{"thread":{"id":"14499","subject":"[PATCH] guilt(1): fix path to git-sh-setup","startedAt":"2008-07-16T23:23:39Z","lastAt":"2008-07-17T14:53:56Z","messageCount":4,"participants":["Alex Chiang","Petr Baudis","Johannes Schindelin","Josef 'Jeff' Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"83619","messageId":"20080716232339.GC22919@ldl.fc.hp.com","threadId":"14499","inReplyTo":null,"subject":"[PATCH] guilt(1): fix path to git-sh-setup","fromName":"Alex Chiang","fromEmail":"achiang@hp.com","sentAt":"2008-07-16T23:23:39Z","receivedAt":"2008-07-16T23:23:39Z","isPatch":true,"sender":{"key":"achiang@hp.com","avatar":null},"body":"git is in the process of moving subcommands to /usr/libexec/git-core\n\nThis move breaks an assumption in guilt about the location of\ngit-sh-setup.\n\nWe can ask git for where it thinks its executables live.\n\nSigned-off-by: Alex Chiang <achiang@hp.com>\n---\n\ndiff --git a/guilt b/guilt\nindex 50414a4..ba4593a 100755\n--- a/guilt\n+++ b/guilt\n@@ -23,7 +23,7 @@ esac\n # we change directories ourselves\n SUBDIRECTORY_OK=1\n \n-. git-sh-setup\n+. `git --exec-path`/git-sh-setup\n \n #\n # Git version check\n"},{"id":"83659","messageId":"20080717100217.GT32184@machine.or.cz","threadId":"14499","inReplyTo":"20080716232339.GC22919@ldl.fc.hp.com","subject":"Re: [PATCH] guilt(1): fix path to git-sh-setup","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-07-17T10:02:17Z","receivedAt":"2008-07-17T10:02:17Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:\n> diff --git a/guilt b/guilt\n> index 50414a4..ba4593a 100755\n> --- a/guilt\n> +++ b/guilt\n> @@ -23,7 +23,7 @@ esac\n>  # we change directories ourselves\n>  SUBDIRECTORY_OK=1\n>  \n> -. git-sh-setup\n> +. `git --exec-path`/git-sh-setup\n\nBeware of the proverbial \"/Program Files/Git\" location, however.\n\n\t\t\t\tPetr \"Pasky\" Baudis\n"},{"id":"83671","messageId":"alpine.LSU.1.00.0807171357150.3486@wbgn129.biozentrum.uni-wuerzburg.de","threadId":"14499","inReplyTo":"20080717100217.GT32184@machine.or.cz","subject":"Re: [PATCH] guilt(1): fix path to git-sh-setup","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-17T11:58:13Z","receivedAt":"2008-07-17T11:58:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 17 Jul 2008, Petr Baudis wrote:\n\n> On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:\n> > diff --git a/guilt b/guilt\n> > index 50414a4..ba4593a 100755\n> > --- a/guilt\n> > +++ b/guilt\n> > @@ -23,7 +23,7 @@ esac\n> >  # we change directories ourselves\n> >  SUBDIRECTORY_OK=1\n> >  \n> > -. git-sh-setup\n> > +. `git --exec-path`/git-sh-setup\n> \n> Beware of the proverbial \"/Program Files/Git\" location, however.\n\nIndeed.  And when trying to stray not _too_ far away from the coding style \nof git.git, avoid the backticks, too, like so:\n\n\t. \"$(git --exec-path)\"/git-sh-setup\n\nCiao,\nDscho\n"},{"id":"83698","messageId":"20080717145356.GA7235@josefsipek.net","threadId":"14499","inReplyTo":"20080716232339.GC22919@ldl.fc.hp.com","subject":"Re: [PATCH] guilt(1): fix path to git-sh-setup","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2008-07-17T14:53:56Z","receivedAt":"2008-07-17T14:53:56Z","isPatch":true,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:\n> git is in the process of moving subcommands to /usr/libexec/git-core\n> \n> This move breaks an assumption in guilt about the location of\n> git-sh-setup.\n \nI already have a fix for this queued up.\n\nThanks anyway,\n\nJosef 'Jeff' Sipek.\n\nP.S. Pasky: good catch, I'll check the queued up patch to make sure it's not\n\"broken\"\n\n-- \nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like\nthat.\n\t\t- Linus Torvalds\n"}]}