{"thread":{"id":"14405","subject":"[PATCH 0/5] Extend make remove-dashes","startedAt":"2008-07-11T00:12:02Z","lastAt":"2008-07-13T21:26:57Z","messageCount":9,"participants":["Miklos Vajna","Christian Couder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"82901","messageId":"cover.1215734604.git.vmiklos@frugalware.org","threadId":"14405","inReplyTo":null,"subject":"[PATCH 0/5] Extend make remove-dashes","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T00:12:02Z","receivedAt":"2008-07-11T00:12:02Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Hi,\n\nThis series extends what make remove-dashes did so far, now it uses not\nonly builtins but other programs (git-daemon, etc.) and the shell/perl\nscripts as well.\n\nThe first two patch does minor changes to avoid unwanted renames.\n\nThe third patch changes the output of git bisect log to use a dash-less\nform.\n\nThe 4th patch updates Linus' fixup-builtins script. It was used to\ngenerate the last 'huge' patch.\n\nThe idea behind this series is to avoid commands in the source code and\ntests which is not available in PATH; in other words I *think* is not a\n'necessary' but a 'sooner or later we will have to do this' series.\n\nThe last patch is more a demonstration than a patch for inclusion at the\nmoment, since problem this is not the right time to do such a big\nrename.\n\nMiklos Vajna (5):\n t0001-init.sh: change confusing directory name\n t1007-hash-object.sh: use quotes for the test description\n git-bisect: use dash-less form on git bisect log\n make remove-dashes: apply to scripts and programs as well, not just\n to builtins\n Rewrite \"git-frotz\" to \"git frotz\" for scripts and programs as well\n\n Makefile | 2 +-\n contrib/examples/git-checkout.sh | 2 +-\n contrib/examples/git-clean.sh | 2 +-\n contrib/examples/git-clone.sh | 24 ++--\n contrib/examples/git-commit.sh | 6 +-\n contrib/examples/git-fetch.sh | 6 +-\n contrib/examples/git-gc.sh | 2 +-\n contrib/examples/git-ls-remote.sh | 2 +-\n contrib/examples/git-resolve.sh | 4 +-\n contrib/examples/git-revert.sh | 22 ++--\n contrib/examples/git-tag.sh | 6 +-\n fixup-builtins | 18 +-\n git-am.sh | 22 ++--\n git-bisect.sh | 10 +-\n git-instaweb.sh | 4 +-\n git-merge-octopus.sh | 2 +-\n git-merge-one-file.sh | 8 +-\n git-merge-resolve.sh | 2 +-\n git-merge.sh | 10 +-\n git-parse-remote.sh | 6 +-\n git-pull.sh | 10 +-\n git-quiltimport.sh | 2 +-\n git-rebase.sh | 14 +-\n git-repack.sh | 12 +-\n git-sh-setup.sh | 2 +-\n git-stash.sh | 10 +-\n git-submodule.sh | 12 +-\n git-web--browse.sh | 2 +-\n t/t0001-init.sh | 6 +-\n t/t0050-filesystem.sh | 2 +-\n t/t1007-hash-object.sh | 2 +-\n t/t1200-tutorial.sh | 2 +-\n t/t1303-wacky-config.sh | 2 +-\n t/t1400-update-ref.sh | 10 +-\n t/t1503-rev-parse-verify.sh | 2 +-\n t/t2005-checkout-index-symlinks.sh | 4 +-\n t/t2050-git-dir-relative.sh | 4 +-\n t/t2101-update-index-reupdate.sh | 2 +-\n t/t2102-update-index-symlinks.sh | 2 +-\n t/t2200-add-update.sh | 12 +-\n t/t3001-ls-files-others-exclude.sh | 2 +-\n t/t3020-ls-files-error-unmatch.sh | 2 +-\n t/t3030-merge-recursive.sh | 14 +-\n t/t3200-branch.sh | 58 +++---\n t/t3210-pack-refs.sh | 4 +-\n t/t3400-rebase.sh | 6 +-\n t/t3401-rebase-partial.sh | 22 ++--\n t/t3403-rebase-skip.sh | 2 +-\n t/t3404-rebase-interactive.sh | 2 +-\n t/t3407-rebase-abort.sh | 2 +-\n t/t3500-cherry.sh | 12 +-\n t/t3600-rm.sh | 4 +-\n t/t3800-mktag.sh | 12 +-\n t/t3900-i18n-commit.sh | 6 +-\n t/t3901-i18n-patch.sh | 16 +-\n t/t3903-stash.sh | 2 +-\n t/t4012-diff-binary.sh | 4 +-\n t/t4103-apply-binary.sh | 26 ++--\n t/t4124-apply-ws-rule.sh | 2 +-\n t/t4127-apply-same-fn.sh | 4 +-\n t/t4150-am.sh | 2 +-\n t/t5300-pack-object.sh | 14 +-\n t/t5301-sliding-window.sh | 4 +-\n t/t5302-pack-index.sh | 12 +-\n t/t5400-send-pack.sh | 30 ++--\n t/t5401-update-hooks.sh | 4 +-\n t/t5402-post-merge-hook.sh | 4 +-\n t/t5403-post-checkout-hook.sh | 4 +-\n t/t5500-fetch-pack.sh | 4 +-\n t/t5510-fetch.sh | 2 +-\n t/t5530-upload-pack-error.sh | 4 +-\n t/t5600-clone-fail-cleanup.sh | 12 +-\n t/t6006-rev-list-format.sh | 6 +-\n t/t6025-merge-symlinks.sh | 32 ++--\n t/t6026-merge-attr.sh | 12 +-\n t/t6030-bisect-porcelain.sh | 4 +-\n t/t6120-describe.sh | 30 ++--\n t/t6300-for-each-ref.sh | 28 ++--\n t/t7001-mv.sh | 12 +-\n t/t7003-filter-branch.sh | 20 +-\n t/t7004-tag.sh | 318 +++++++++++++++++-----------------\n t/t7101-reset.sh | 8 +-\n t/t7102-reset.sh | 4 +-\n t/t7103-reset-bare.sh | 2 +-\n t/t7201-co.sh | 2 +-\n t/t7300-clean.sh | 76 ++++----\n t/t7400-submodule-basic.sh | 48 +++---\n t/t7401-submodule-summary.sh | 2 +-\n t/t7500-commit.sh | 2 +-\n t/t7501-commit.sh | 48 +++---\n t/t7502-status.sh | 2 +-\n t/t7505-prepare-commit-msg-hook.sh | 2 +-\n t/t7506-status-submodule.sh | 2 +-\n t/t7600-merge.sh | 2 +-\n t/t7610-mergetool.sh | 2 +-\n t/t7701-repack-unpack-unreachable.sh | 2 +-\n t/t9001-send-email.sh | 2 +-\n t/t9101-git-svn-props.sh | 28 ++--\n t/t9119-git-svn-info.sh | 44 +++---\n t/t9200-git-cvsexportcommit.sh | 14 +-\n t/t9300-fast-import.sh | 66 ++++----\n t/t9301-fast-export.sh | 2 +-\n t/t9400-git-cvsserver-server.sh | 40 ++--\n t/t9401-git-cvsserver-crlf.sh | 10 +-\n t/t9600-cvsimport.sh | 2 +-\n t/t9700-perl-git.sh | 16 +-\n 106 files changed, 731 insertions(+), 731 deletions(-)\n"},{"id":"82903","messageId":"8275a6b4a676d33a1ae80f29f85c52b7bbda9a84.1215734605.git.vmiklos@frugalware.org","threadId":"14405","inReplyTo":"cover.1215734604.git.vmiklos@frugalware.org","subject":"[PATCH 1/5] t0001-init.sh: change confusing directory name","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T00:12:03Z","receivedAt":"2008-07-11T00:12:03Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"using git-init as directory name confused 'make remove-dashes', so just\ndrop the 'git-' prefix.\n\nSigned-off-by: Miklos Vajna \n---\n t/t0001-init.sh | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex d31887f..2a38d98 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -83,11 +83,11 @@ test_expect_success 'init --bare' '\n \n \t(\n \t\tunset GIT_DIR GIT_WORK_TREE GIT_CONFIG\n-\t\tmkdir git-init-bare.git &&\n-\t\tcd git-init-bare.git &&\n+\t\tmkdir init-bare.git &&\n+\t\tcd init-bare.git &&\n \t\tgit init --bare\n \t) &&\n-\tcheck_config git-init-bare.git true unset\n+\tcheck_config init-bare.git true unset\n '\n \n test_expect_success 'GIT_DIR non-bare' '\n-- \n1.5.6.2.450.g8d367.dirty\n"},{"id":"82904","messageId":"9568dd5d03cd0f1da8872fd71f8bb253560e2352.1215734605.git.vmiklos@frugalware.org","threadId":"14405","inReplyTo":"8275a6b4a676d33a1ae80f29f85c52b7bbda9a84.1215734605.git.vmiklos@frugalware.org","subject":"[PATCH 2/5] t1007-hash-object.sh: use quotes for the test description","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T00:12:04Z","receivedAt":"2008-07-11T00:12:04Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n t/t1007-hash-object.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t1007-hash-object.sh b/t/t1007-hash-object.sh\nindex 0526295..1ec0535 100755\n--- a/t/t1007-hash-object.sh\n+++ b/t/t1007-hash-object.sh\n@@ -1,6 +1,6 @@\n #!/bin/sh\n \n-test_description=git-hash-object\n+test_description=\"git-hash-object\"\n \n . ./test-lib.sh\n \n-- \n1.5.6.2.450.g8d367.dirty\n"},{"id":"82902","messageId":"eb505d0d8f7d2bf50073414baa799a80a9df7453.1215734605.git.vmiklos@frugalware.org","threadId":"14405","inReplyTo":"9568dd5d03cd0f1da8872fd71f8bb253560e2352.1215734605.git.vmiklos@frugalware.org","subject":"[PATCH 3/5] git-bisect: use dash-less form on git bisect log","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T00:12:05Z","receivedAt":"2008-07-11T00:12:05Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Given that users are supposed to type 'git bisect' now, make the output\nof 'git bisect log' consistent with this.\n\nSigned-off-by: Miklos Vajna \n---\n git-bisect.sh | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 991b2ef..f4852a9 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -149,7 +149,7 @@ bisect_start() {\n \techo \"$start_head\" >\"$GIT_DIR/BISECT_START\" &&\n \tsq \"$@\" >\"$GIT_DIR/BISECT_NAMES\" &&\n \teval \"$eval\" &&\n-\techo \"git-bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n+\techo \"git bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n \t#\n \t# Check if we can proceed to the next bisect state.\n \t#\n@@ -169,7 +169,7 @@ bisect_write() {\n \tesac\n \tgit update-ref \"refs/bisect/$tag\" \"$rev\" || exit\n \techo \"# $state: $(git show-branch $rev)\" >>\"$GIT_DIR/BISECT_LOG\"\n-\ttest -n \"$nolog\" || echo \"git-bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n+\ttest -n \"$nolog\" || echo \"git bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n }\n \n bisect_state() {\n@@ -426,9 +426,9 @@ bisect_clean_state() {\n bisect_replay () {\n \ttest -r \"$1\" || die \"cannot read $1 for replaying\"\n \tbisect_reset\n-\twhile read bisect command rev\n+\twhile read git bisect command rev\n \tdo\n-\t\ttest \"$bisect\" = \"git-bisect\" || continue\n+\t\ttest \"$git $bisect\" = \"git bisect\" || continue\n \t\tcase \"$command\" in\n \t\tstart)\n \t\t\tcmd=\"bisect_start $rev\"\n-- \n1.5.6.2.450.g8d367.dirty\n"},{"id":"82905","messageId":"581f7ee17a4fb122f4df258d9cc0631b763fe9e1.1215734605.git.vmiklos@frugalware.org","threadId":"14405","inReplyTo":"eb505d0d8f7d2bf50073414baa799a80a9df7453.1215734605.git.vmiklos@frugalware.org","subject":"[PATCH 4/5] make remove-dashes: apply to scripts and programs as well, not just to builtins","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T00:12:06Z","receivedAt":"2008-07-11T00:12:06Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"All programs and scripts are now moved outside PATH, so it's a good idea\nnot to use the dashed forms for them, either.\n\nSigned-off-by: Miklos Vajna \n---\n Makefile | 2 +-\n fixup-builtins | 18 +++++++++---------\n 2 files changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 4796565..2b54d92 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1296,7 +1296,7 @@ check: common-cmds.h\n \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n \n remove-dashes:\n-\t./fixup-builtins $(BUILT_INS)\n+\t./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)\n \n ### Installation rules\n \ndiff --git a/fixup-builtins b/fixup-builtins\nindex 49e861d..63dfa4c 100755\n--- a/fixup-builtins\n+++ b/fixup-builtins\n@@ -1,16 +1,16 @@\n #!/bin/sh\n while [ \"$1\" ]\n do\n-\told=\"$1\"\n-\tnew=$(echo \"$1\" | sed 's/git-/git /')\n-\techo \"Converting '$old' to '$new'\"\n-\tgit ls-files '*.sh' | while read file\n-\tdo\n-\t\tsed \"s/\\\\<$old\\\\>/$new/g\" < $file > $file.new\n-\t\tchmod --reference=$file $file.new\n-\t\tmv $file.new $file\n-\tdone\n+\tif [ \"$1\" != \"git-sh-setup\" -a \"$1\" != \"git-parse-remote\" -a \"$1\" != \"git-svn\" ]; then\n+\t\told=\"$1\"\n+\t\tnew=$(echo \"$1\" | sed 's/git-/git /')\n+\t\techo \"Converting '$old' to '$new'\"\n+\t\tsed -i \"s/\\\\<$old\\\\>/$new/g\" $(git ls-files '*.sh')\n+\tfi\n \tshift\n done\n+\n+sed -i 's/git merge-one-file/git-merge-one-file/g\n+s/git rebase-todo/git-rebase-todo/g' $(git ls-files '*.sh')\n git update-index --refresh >& /dev/null\n exit 0\n-- \n1.5.6.2.450.g8d367.dirty\n"},{"id":"82922","messageId":"200807110839.14764.chriscool@tuxfamily.org","threadId":"14405","inReplyTo":"eb505d0d8f7d2bf50073414baa799a80a9df7453.1215734605.git.vmiklos@frugalware.org","subject":"Re: [PATCH 3/5] git-bisect: use dash-less form on git bisect log","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-11T06:39:14Z","receivedAt":"2008-07-11T06:39:14Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le vendredi 11 juillet 2008, Miklos Vajna a écrit :\n> Given that users are supposed to type 'git bisect' now, make the output\n> of 'git bisect log' consistent with this.\n>\n> Signed-off-by: Miklos Vajna \n> ---\n> git-bisect.sh | 8 ++++----\n> 1 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/git-bisect.sh b/git-bisect.sh\n> index 991b2ef..f4852a9 100755\n> --- a/git-bisect.sh\n> +++ b/git-bisect.sh\n> @@ -149,7 +149,7 @@ bisect_start() {\n> \techo \"$start_head\" >\"$GIT_DIR/BISECT_START\" &&\n> \tsq \"$@\" >\"$GIT_DIR/BISECT_NAMES\" &&\n> \teval \"$eval\" &&\n> -\techo \"git-bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n> +\techo \"git bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n> \t#\n> \t# Check if we can proceed to the next bisect state.\n> \t#\n> @@ -169,7 +169,7 @@ bisect_write() {\n> \tesac\n> \tgit update-ref \"refs/bisect/$tag\" \"$rev\" || exit\n> \techo \"# $state: $(git show-branch $rev)\" >>\"$GIT_DIR/BISECT_LOG\"\n> -\ttest -n \"$nolog\" || echo \"git-bisect $state $rev\"\n> >>\"$GIT_DIR/BISECT_LOG\" +\ttest -n \"$nolog\" || echo \"git bisect $state\n> $rev\" >>\"$GIT_DIR/BISECT_LOG\" }\n>\n> bisect_state() {\n> @@ -426,9 +426,9 @@ bisect_clean_state() {\n> bisect_replay () {\n> \ttest -r \"$1\" || die \"cannot read $1 for replaying\"\n> \tbisect_reset\n> -\twhile read bisect command rev\n> +\twhile read git bisect command rev\n> \tdo\n> -\t\ttest \"$bisect\" = \"git-bisect\" || continue\n> +\t\ttest \"$git $bisect\" = \"git bisect\" || continue\n> \t\tcase \"$command\" in\n> \t\tstart)\n> \t\t\tcmd=\"bisect_start $rev\"\n\nWouldn't it be better if bisect_replay could read old logs?\n\nMaybe with something like:\n\n+\twhile read git bisect command rev\n \tdo\n-\t\ttest \"$bisect\" = \"git-bisect\" || continue\n+\t\ttest \"$git $bisect\" = \"git bisect\" -o \"$git\" = \"git-bisect\" || continue\n+\t\tif test \"$git\" = \"git-bisect\"; then\n+\t\t\trev=\"$command\"\n+\t\t\tcommand=\"$bisect\"\n+\t\tfi\n \t\tcase \"$command\" in\n \t\tstart)\n \t\t\tcmd=\"bisect_start $rev\"\n\nThanks,\nChristian.\n"},{"id":"82973","messageId":"1215792089-27201-1-git-send-email-vmiklos@frugalware.org","threadId":"14405","inReplyTo":"200807110839.14764.chriscool@tuxfamily.org","subject":"[PATCH] git-bisect: use dash-less form on git bisect log","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-07-11T16:01:29Z","receivedAt":"2008-07-11T16:01:29Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Given that users are supposed to type 'git bisect' now, make the output\nof 'git bisect log' consistent with this.\n\nSigned-off-by: Miklos Vajna \n---\n\nOn Fri, Jul 11, 2008 at 08:39:14AM +0200, Christian Couder wrote:\n> Wouldn't it be better if bisect_replay could read old logs?\n>\n> Maybe with something like:\n>\n> + while read git bisect command rev\n> do\n> - test \"$bisect\" = \"git-bisect\" || continue\n> + test \"$git $bisect\" = \"git bisect\" -o \"$git\" =\n> \"git-bisect\" || continue\n> + if test \"$git\" = \"git-bisect\"; then\n> + rev=\"$command\"\n> + command=\"$bisect\"\n> + fi\n\nYou are right, here is an updated patch.\n\n git-bisect.sh | 12 ++++++++----\n 1 files changed, 8 insertions(+), 4 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 991b2ef..3cac20d 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -149,7 +149,7 @@ bisect_start() {\n \techo \"$start_head\" >\"$GIT_DIR/BISECT_START\" &&\n \tsq \"$@\" >\"$GIT_DIR/BISECT_NAMES\" &&\n \teval \"$eval\" &&\n-\techo \"git-bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n+\techo \"git bisect start$orig_args\" >>\"$GIT_DIR/BISECT_LOG\" || exit\n \t#\n \t# Check if we can proceed to the next bisect state.\n \t#\n@@ -169,7 +169,7 @@ bisect_write() {\n \tesac\n \tgit update-ref \"refs/bisect/$tag\" \"$rev\" || exit\n \techo \"# $state: $(git show-branch $rev)\" >>\"$GIT_DIR/BISECT_LOG\"\n-\ttest -n \"$nolog\" || echo \"git-bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n+\ttest -n \"$nolog\" || echo \"git bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n }\n \n bisect_state() {\n@@ -426,9 +426,13 @@ bisect_clean_state() {\n bisect_replay () {\n \ttest -r \"$1\" || die \"cannot read $1 for replaying\"\n \tbisect_reset\n-\twhile read bisect command rev\n+\twhile read git bisect command rev\n \tdo\n-\t\ttest \"$bisect\" = \"git-bisect\" || continue\n+\t\ttest \"$git $bisect\" = \"git bisect\" -o \"$git\" = \"git-bisect\" || continue\n+\t\tif test \"$git\" = \"git-bisect\"; then\n+\t\t\trev=\"$command\"\n+\t\t\tcommand=\"$bisect\"\n+\t\tfi\n \t\tcase \"$command\" in\n \t\tstart)\n \t\t\tcmd=\"bisect_start $rev\"\n-- \n1.5.6.2.450.g8d367.dirty\n"},{"id":"83125","messageId":"200807130819.24206.chriscool@tuxfamily.org","threadId":"14405","inReplyTo":"1215792089-27201-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] git-bisect: use dash-less form on git bisect log","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-07-13T06:19:24Z","receivedAt":"2008-07-13T06:19:24Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le vendredi 11 juillet 2008, Miklos Vajna a écrit :\n> Given that users are supposed to type 'git bisect' now, make the output\n> of 'git bisect log' consistent with this.\n>\n> Signed-off-by: Miklos Vajna \n> ---\n>\n> On Fri, Jul 11, 2008 at 08:39:14AM +0200, Christian Couder \n wrote:\n> > Wouldn't it be better if bisect_replay could read old logs?\n> >\n> > Maybe with something like:\n> >\n> > + while read git bisect command rev\n> > do\n> > - test \"$bisect\" = \"git-bisect\" || continue\n> > + test \"$git $bisect\" = \"git bisect\" -o \"$git\" =\n> > \"git-bisect\" || continue\n> > + if test \"$git\" = \"git-bisect\"; then\n> > + rev=\"$command\"\n> > + command=\"$bisect\"\n> > + fi\n>\n> You are right, here is an updated patch.\n\nYour patch looks good. But there is also the problem that new bisect logs \nwill not be understood by old git. So I wonder if a patch to only read the \nnew log should be first commited to the \"maint\" branch.\n\nAnd sorry but I will be on vacation without Internet access for one week \nstarting really soon now, so I will not be able to do anything soon, nor \nanswer to any mails.\n\nThanks,\nChristian.\n"},{"id":"83177","messageId":"7vk5fpqxum.fsf@gitster.siamese.dyndns.org","threadId":"14405","inReplyTo":"200807130819.24206.chriscool@tuxfamily.org","subject":"Re: [PATCH] git-bisect: use dash-less form on git bisect log","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-13T21:26:57Z","receivedAt":"2008-07-13T21:26:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder writes:\n\n> Your patch looks good. But there is also the problem that new bisect logs \n> will not be understood by old git. So I wonder if a patch to only read the \n> new log should be first commited to the \"maint\" branch.\n\nI do not think it is worth it. If we are making something long lived like\nrerere cache backward incompatible, the approach would be sensible, but\nbisect log is about a single session and once you reached the breakage you\nwould not reuse it. Besides, the bisect log is designed to be executable\nshell script so you can always copy it out, edit it if needed and feed\nthat to shell.\n"}]}