{"thread":{"id":"14386","subject":"[PATCH] git-send-email: Fix authenticating on some servers when using TLS.","startedAt":"2008-07-09T21:39:40Z","lastAt":"2008-07-09T22:51:09Z","messageCount":2,"participants":["Robert Shearman","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"82760","messageId":"1215639580-25040-1-git-send-email-robertshearman@gmail.com","threadId":"14386","inReplyTo":null,"subject":"[PATCH] git-send-email: Fix authenticating on some servers when using TLS.","fromName":"Robert Shearman","fromEmail":"robertshearman@gmail.com","sentAt":"2008-07-09T21:39:40Z","receivedAt":"2008-07-09T21:39:40Z","isPatch":true,"sender":{"key":"robertshearman@gmail.com","avatar":null},"body":"Send hello after a successful STARTTLS command to refresh the list of extensions. These may be different to what is returned over a clear connection (for example the AUTH command may be accepted over a secure connection, but not over a clear connection).\n\nFurthermore, this behaviour is recommended by RFC 2487 (http://www.ietf.org/rfc/rfc2487.txt).\n\nSigned-off-by: Robert Shearman <robertshearman@gmail.com>\n---\n git-send-email.perl |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 3564419..6adb669 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -773,6 +773,9 @@ X-Mailer: git-send-email $gitversion\n \t\t\t\t\t$smtp = Net::SMTP::SSL->start_SSL($smtp)\n \t\t\t\t\t\tor die \"STARTTLS failed! \".$smtp->message;\n \t\t\t\t\t$smtp_encryption = '';\n+\t\t\t\t\t# Send EHLO again to receive fresh\n+\t\t\t\t\t# supported commands\n+\t\t\t\t\t$smtp->hello();\n \t\t\t\t} else {\n \t\t\t\t\tdie \"Server does not support STARTTLS! \".$smtp->message;\n \t\t\t\t}\n-- \n1.5.6.2.224.g26efb.dirty\n"},{"id":"82761","messageId":"7v1w227jtu.fsf@gitster.siamese.dyndns.org","threadId":"14386","inReplyTo":"1215639580-25040-1-git-send-email-robertshearman@gmail.com","subject":"Re: [PATCH] git-send-email: Fix authenticating on some servers when using TLS.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-09T22:51:09Z","receivedAt":"2008-07-09T22:51:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert Shearman <robertshearman@gmail.com> writes:\n\n> Send hello after a successful STARTTLS command to refresh the list of extensions. These may be different to what is returned over a clear connection (for example the AUTH command may be accepted over a secure connection, but not over a clear connection).\n>\n> Furthermore, this behaviour is recommended by RFC 2487 (http://www.ietf.org/rfc/rfc2487.txt).\n\nVery true.  Thanks.\n"}]}