{"thread":{"id":"14375","subject":"[PATCH] t9113-*.sh: provide user feedback when test skipped","startedAt":"2008-07-08T23:18:26Z","lastAt":"2008-07-08T23:18:26Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"82739","messageId":"4873F5C2.2030605@ramsay1.demon.co.uk","threadId":"14375","inReplyTo":null,"subject":"[PATCH] t9113-*.sh: provide user feedback when test skipped","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2008-07-08T23:18:26Z","receivedAt":"2008-07-08T23:18:26Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCurrently this test simply exits without providing any\nfeedback at all.  Tell user if the test is being skipped\nand provide a hint as to how the test may be enabled.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n t/t9113-git-svn-dcommit-new-file.sh |    8 +++++++-\n 1 files changed, 7 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.sh\nindex 31c929b..8da8ce5 100755\n--- a/t/t9113-git-svn-dcommit-new-file.sh\n+++ b/t/t9113-git-svn-dcommit-new-file.sh\n@@ -7,12 +7,18 @@\n # I don't like the idea of taking a port and possibly leaving a\n # daemon running on a users system if the test fails.\n # Not all git users will need to interact with SVN.\n-test -z \"$SVNSERVE_PORT\" && exit 0\n \n test_description='git-svn dcommit new files over svn:// test'\n \n . ./lib-git-svn.sh\n \n+if test -z \"$SVNSERVE_PORT\"\n+then\n+\tsay 'skipping svnserve test. (set $SVNSERVE_PORT to enable)'\n+\ttest_done\n+\texit\n+fi\n+\n start_svnserve () {\n \tsvnserve --listen-port $SVNSERVE_PORT \\\n \t         --root \"$rawsvnrepo\" \\\n-- \n1.5.6\n"}]}