{"thread":{"id":"14374","subject":"[PATCH] t9100-git-svn-basic.sh: Fix determination of utf-8 locale","startedAt":"2008-07-08T22:59:25Z","lastAt":"2008-07-08T22:59:25Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"82738","messageId":"4873F14D.1080903@ramsay1.demon.co.uk","threadId":"14374","inReplyTo":null,"subject":"[PATCH] t9100-git-svn-basic.sh: Fix determination of utf-8 locale","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2008-07-08T22:59:25Z","receivedAt":"2008-07-08T22:59:25Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nWhen setting the GIT_SVN_LC_ALL variable, default to the $LANG\nenvironment variable, when the $LC_ALL override is not set.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nIt took some time before I noticed this because the message\n\"UTF-8 locale not set, ...\" did not stand-out when flying past on\nthe console. After noticing it, however, it surprised me (then\nirritated me) because I most definitely did have a UTF-8 locale\nset ...\n\nThe two hunks which s/echo/say/ are not strictly part of the fix\nand should perhaps be in a separate patch ... Dunno. (but it\ncertainly makes the message stand out more ;-)\n\n\n t/t9100-git-svn-basic.sh |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh\nindex 242cdf0..3bc6164 100755\n--- a/t/t9100-git-svn-basic.sh\n+++ b/t/t9100-git-svn-basic.sh\n@@ -4,9 +4,9 @@\n #\n \n test_description='git-svn basic tests'\n-GIT_SVN_LC_ALL=$LC_ALL\n+GIT_SVN_LC_ALL=${LC_ALL:-$LANG}\n \n-case \"$LC_ALL\" in\n+case \"$GIT_SVN_LC_ALL\" in\n *.UTF-8)\n \thave_utf8=t\n \t;;\n@@ -17,7 +17,7 @@ esac\n \n . ./lib-git-svn.sh\n \n-echo 'define NO_SVN_TESTS to skip git-svn tests'\n+say 'define NO_SVN_TESTS to skip git-svn tests'\n \n test_expect_success \\\n     'initialize git-svn' '\n@@ -183,7 +183,7 @@ then\n \t\tgit-svn set-tree HEAD\"\n \tunset LC_ALL\n else\n-\techo \"UTF-8 locale not set, test skipped ($GIT_SVN_LC_ALL)\"\n+\tsay \"UTF-8 locale not set, test skipped ($GIT_SVN_LC_ALL)\"\n fi\n \n name='test fetch functionality (svn => git) with alternate GIT_SVN_ID'\n-- \n1.5.6\n"}]}