{"thread":{"id":"1436","subject":"Make git-sh-setup-script do what it was supposed to do","startedAt":"2005-08-06T17:04:50Z","lastAt":"2005-08-06T17:18:16Z","messageCount":2,"participants":["Linus Torvalds","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"6879","messageId":"Pine.LNX.4.58.0508061002370.3258@g5.osdl.org","threadId":"1436","inReplyTo":null,"subject":"Make git-sh-setup-script do what it was supposed to do","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-08-06T17:04:50Z","receivedAt":"2005-08-06T17:04:50Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\nDuh. A missing && meant that half the tests that git-sh-setup-script were\n_meant_ to do were actually totally ignored.\n\nIn particular, the git sanity checking ended up only testing that the \nGIT_OBJECT_DIRECTORY was sane, not that GIT_DIR itself was..\n\nSigned-off-by: Linus Torvalds <torvalds@osdl.org>\n---\ndiff --git a/git-sh-setup-script b/git-sh-setup-script\n--- a/git-sh-setup-script\n+++ b/git-sh-setup-script\n@@ -12,6 +12,6 @@ die() {\n }\n \n [ -d \"$GIT_DIR\" ] &&\n-[ -d \"$GIT_DIR/refs\" ]\n+[ -d \"$GIT_DIR/refs\" ] &&\n [ -d \"$GIT_OBJECT_DIRECTORY\" ] &&\n [ -d \"$GIT_OBJECT_DIRECTORY/00\" ]\n"},{"id":"6881","messageId":"7vll3f9e7b.fsf@assigned-by-dhcp.cox.net","threadId":"1436","inReplyTo":"Pine.LNX.4.58.0508061002370.3258@g5.osdl.org","subject":"Re: Make git-sh-setup-script do what it was supposed to do","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-06T17:18:16Z","receivedAt":"2005-08-06T17:18:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Torvalds <torvalds@osdl.org> writes:\n\n> Duh. A missing && meant that half the tests that git-sh-setup-script were\n> _meant_ to do were actually totally ignored.\n>\n> In particular, the git sanity checking ended up only testing that the \n> GIT_OBJECT_DIRECTORY was sane, not that GIT_DIR itself was..\n\nOuch.  Thanks.\n"}]}