{"thread":{"id":"14324","subject":"[PATCH] run_command(): respect GIT_TRACE","startedAt":"2008-07-07T13:41:34Z","lastAt":"2008-07-07T20:00:26Z","messageCount":2,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"82444","messageId":"alpine.DEB.1.00.0807071441190.18205@racer","threadId":"14324","inReplyTo":null,"subject":"[PATCH] run_command(): respect GIT_TRACE","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-07T13:41:34Z","receivedAt":"2008-07-07T13:41:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nWhen GIT_TRACE is set, the user is most likely wanting to see an external\ncommand that is about to be executed.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n run-command.c |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex 2ce8c2b..6e29fdf 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -65,6 +65,8 @@ int start_command(struct child_process *cmd)\n \t\tcmd->err = fderr[0];\n \t}\n \n+\ttrace_argv_printf(cmd->argv, \"trace: run_command:\");\n+\n #ifndef __MINGW32__\n \tcmd->pid = fork();\n \tif (!cmd->pid) {\n-- \n1.5.6.2.402.g95b5ab.dirty\n"},{"id":"82485","messageId":"7v4p7131np.fsf@gitster.siamese.dyndns.org","threadId":"14324","inReplyTo":"alpine.DEB.1.00.0807071441190.18205@racer","subject":"Re: [PATCH] run_command(): respect GIT_TRACE","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-07T20:00:26Z","receivedAt":"2008-07-07T20:00:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> When GIT_TRACE is set, the user is most likely wanting to see an external\n> command that is about to be executed.\n\nI haven't checked to see if none of the callers of start_command() assumes\nthe current behaviour and is printing this information itself instead, but\nother than that, your justification feels very sensible.\n\nThanks.\n\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n>  run-command.c |    2 ++\n>  1 files changed, 2 insertions(+), 0 deletions(-)\n>\n> diff --git a/run-command.c b/run-command.c\n> index 2ce8c2b..6e29fdf 100644\n> --- a/run-command.c\n> +++ b/run-command.c\n> @@ -65,6 +65,8 @@ int start_command(struct child_process *cmd)\n>  \t\tcmd->err = fderr[0];\n>  \t}\n>  \n> +\ttrace_argv_printf(cmd->argv, \"trace: run_command:\");\n> +\n>  #ifndef __MINGW32__\n>  \tcmd->pid = fork();\n>  \tif (!cmd->pid) {\n> -- \n> 1.5.6.2.402.g95b5ab.dirty\n"}]}