{"thread":{"id":"143","subject":"[PATCH] Makefile uses installed commit-id","startedAt":"2005-04-19T17:28:38Z","lastAt":"2005-04-19T17:28:38Z","messageCount":1,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"838","messageId":"1113931718.3793.8.camel@dv","threadId":"143","inReplyTo":null,"subject":"[PATCH] Makefile uses installed commit-id","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-04-19T17:28:38Z","receivedAt":"2005-04-19T17:28:38Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello!\n\nCurrent git-pasky cannot be compiled properly unless it's already\ninstalled.  The rule for creating gitversion.sh requires commit-id in\nthe PATH, which won't be there until \"make install\" is run.\n\nAlso, commit-id runs gitXnormid.sh, which in turn runs cat-file.  All of\nthem should be from the current directory to avoid the requirement that\ngit is installed before gitversion.sh is generated.\n\nThis patch adds \".\" to PATH when running commit-id.  The patch is\nagainst current git-pasky.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\n--- a/Makefile\n+++ b/Makefile\n@@ -46,11 +46,11 @@ $(LIB_FILE): $(LIB_OBJS)\n \n %.o: $(LIB_H)\n \n-gitversion.sh: $(VERSION)\n+gitversion.sh: $(VERSION) commit-id\n \t@echo Generating gitversion.sh...\n \t@rm -f $@\n \t@echo \"#!/bin/sh\" > $@\n-\t@echo \"echo \\\"$(shell cat $(VERSION)) ($(shell commit-id))\\\"\" >> $@\n+\t@echo \"echo \\\"$(shell cat $(VERSION)) ($(shell PATH=.:$$PATH ./commit-id))\\\"\" >> $@\n \t@chmod +x $@\n \n install: $(PROG) $(GEN_SCRIPT)\n\n\n-- \nRegards,\nPavel Roskin\n\n\n"}]}