{"thread":{"id":"14192","subject":"Make test on AIX","startedAt":"2008-06-27T21:13:41Z","lastAt":"2008-06-28T15:35:05Z","messageCount":3,"participants":["Craig L. Ching","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"81472","messageId":"63BEA5E623E09F4D92233FB12A9F794302389D09@emailmn.mqsoftware.com","threadId":"14192","inReplyTo":null,"subject":"Make test on AIX","fromName":"Craig L. Ching","fromEmail":"cching@mqsoftware.com","sentAt":"2008-06-27T21:13:41Z","receivedAt":"2008-06-27T21:13:41Z","isPatch":false,"sender":{"key":"cching@mqsoftware.com","avatar":null},"body":"Hi all,\n\nI just got through a rather painful build and install of 1.5.6.1 on AIX\nand I was wondering if anyone has any clues on how to get the tests to\nrun a bit better there.\n\nThe first thing I encountered was that because the tests all use\n#!/bin/sh the exit code was not what the tests expected.  So I ended up\nrunning 'make SHELL=`which bash` all' directly in the git/t/ directory.\nThat seemed to shake out and work for most of the tests except for\nt/t7502-commit.sh.  Try as I might, I could not get SHELL_PATH set to\nanything but /bin/sh except to hard-code the SHELL_PATH in this script.\n\nAm I missing something?  Is there an easier way to get the test suite to\nwork?  If so, I appreciate any advice.  If not, does anyone have any\nideas on how I might fix this and create a patch for git to submit?  I\ndon't claim to be a make or bash expert, so go easy on me if I've missed\nsomething obvious ;-)\n\nAny help appreciated!\n\nCheers,\nCraig\n"},{"id":"81544","messageId":"20080628051500.GF9451@sigill.intra.peff.net","threadId":"14192","inReplyTo":"63BEA5E623E09F4D92233FB12A9F794302389D09@emailmn.mqsoftware.com","subject":"Re: Make test on AIX","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-06-28T05:15:00Z","receivedAt":"2008-06-28T05:15:00Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 27, 2008 at 04:13:41PM -0500, Craig L. Ching wrote:\n\n> The first thing I encountered was that because the tests all use\n> #!/bin/sh the exit code was not what the tests expected.  So I ended up\n> running 'make SHELL=`which bash` all' directly in the git/t/ directory.\n> That seemed to shake out and work for most of the tests except for\n> t/t7502-commit.sh.  Try as I might, I could not get SHELL_PATH set to\n> anything but /bin/sh except to hard-code the SHELL_PATH in this script.\n\nThe SHELL_PATH actually comes from the build options for all of git. So\nyou should be able to go to the toplevel of your git repo and do a \"make\nSHELL_PATH=`which bash`\". This means that we will also use bash for all\nof the script components of git.\n\nI don't know how necessary that is on AIX, but it certainly is on\nSolaris, where /bin/sh is unusable.\n\n-Peff\n"},{"id":"81561","messageId":"63BEA5E623E09F4D92233FB12A9F7943013D8B@emailmn.mqsoftware.com","threadId":"14192","inReplyTo":"20080628051500.GF9451@sigill.intra.peff.net","subject":"RE: Make test on AIX","fromName":"Craig L. Ching","fromEmail":"cching@mqsoftware.com","sentAt":"2008-06-28T15:35:05Z","receivedAt":"2008-06-28T15:35:05Z","isPatch":false,"sender":{"key":"cching@mqsoftware.com","avatar":null},"body":"(I apologize in advance if the quoting is bad, using owa since I don't want an outlook client installed on my home system)\n\n\n-----Original Message-----\nFrom: git-owner@vger.kernel.org on behalf of Jeff King\nSent: Sat 6/28/2008 12:15 AM\nTo: Craig L. Ching\nCc: git@vger.kernel.org\nSubject: Re: Make test on AIX\n \nOn Fri, Jun 27, 2008 at 04:13:41PM -0500, Craig L. Ching wrote:\n\n> The first thing I encountered was that because the tests all use\n> #!/bin/sh the exit code was not what the tests expected.  So I ended up\n> running 'make SHELL=`which bash` all' directly in the git/t/ directory.\n> That seemed to shake out and work for most of the tests except for\n> t/t7502-commit.sh.  Try as I might, I could not get SHELL_PATH set to\n> anything but /bin/sh except to hard-code the SHELL_PATH in this script.\n\n> > The SHELL_PATH actually comes from the build options for all of git. So\n> > you should be able to go to the toplevel of your git repo and do a \"make\n> > SHELL_PATH=`which bash`\". This means that we will also use bash for all\n> > of the script components of git.\n\nWell, I swear I tried 'make SHELL_PATH=`which bash` test' and that *didn't* work, but I just rebuilt adding SHELL_PATH to even the build step and the tests are running.  I do know I upgraded bash somewhere in between trying that and now, maybe that had some affect, the bash that was installed was fairly old.  The tests are running now, I'll post back if I run into any other problems.\n\n> > I don't know how necessary that is on AIX, but it certainly is on\n> > Solaris, where /bin/sh is unusable.\n\nI didn't have this problem at all on Solaris, the tests ran just great apart from needing to install a pretty hefty GNU tool chain since a lot of the tests wouldn't work with non-GNU equivalents (e.g. patch, diff, sed, etc.).  Not a huge deal, just glad to see it building and passing tests on these platforms ;-)\n\n> > -Peff\n\nThanks again!\n\nCheers,\nCraig\n"}]}