{"thread":{"id":"1418","subject":"[PATCH] Use $DESTDIR instead of $dest","startedAt":"2005-08-04T22:55:29Z","lastAt":"2005-08-09T20:57:25Z","messageCount":4,"participants":["Petr Baudis","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"6820","messageId":"20050804225529.GJ24479@pasky.ji.cz","threadId":"1418","inReplyTo":null,"subject":"[PATCH] Use $DESTDIR instead of $dest","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-08-04T22:55:29Z","receivedAt":"2005-08-04T22:55:29Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"$DESTDIR is more usual during the build than $dest and is what is usually\nused in the makefiles, so let's use it too.\n\nSigned-off-by: Petr Baudis \n\n---\ncommit ffc29a11e9be157e2349d431adadf1b6e91a2251\ntree fbd1076ed78c609777f81094cb8989b5b32973da\nparent aa6f095b0cd57ab424f02695ccfc8168f5c3b981\nauthor Petr Baudis Fri, 05 Aug 2005 00:54:52 +0200\ncommitter Petr Baudis Fri, 05 Aug 2005 00:54:52 +0200\n\n Makefile | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -41,7 +41,7 @@ prefix=$(HOME)\n bindir=$(prefix)/bin\n etcdir=$(prefix)/etc\n etcgitdir=$(etcdir)/git-core\n-# dest=\n+# DESTDIR=\n \n CC?=gcc\n AR?=ar\n@@ -197,8 +197,8 @@ check:\n ### Installation rules\n \n install: $(PROG) $(SCRIPTS)\n-\t$(INSTALL) -m755 -d $(dest)$(bindir)\n-\t$(INSTALL) $(PROG) $(SCRIPTS) $(dest)$(bindir)\n+\t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)\n \t$(MAKE) -C templates install\n \n install-tools:\n"},{"id":"6828","messageId":"20050804235638.GL24479@pasky.ji.cz","threadId":"1418","inReplyTo":"20050804225529.GJ24479@pasky.ji.cz","subject":"[PATCH] Use $DESTDIR instead of $dest","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-08-04T23:56:38Z","receivedAt":"2005-08-04T23:56:38Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"$DESTDIR is more usual during the build than $dest and is what is usually\nused in the makefiles, so let's use it too.\n\nSigned-off-by: Petr Baudis \n\n---\n\n\tThis updates the subdirectory Makefiles as well.\n\ncommit aef274d1fc04d848c7355a68c3e48c0b2b5400cb\ntree 546c10ded595cf48473ce216b594607fd922836d\nparent aa6f095b0cd57ab424f02695ccfc8168f5c3b981\nauthor Petr Baudis Fri, 05 Aug 2005 01:55:36 +0200\ncommitter Petr Baudis Fri, 05 Aug 2005 01:55:36 +0200\n\n Documentation/Makefile | 6 +++---\n Makefile | 6 +++---\n templates/Makefile | 10 +++++-----\n tools/Makefile | 6 +++---\n 4 files changed, 14 insertions(+), 14 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -33,9 +33,9 @@ man1: $(DOC_MAN1)\n man7: $(DOC_MAN7)\n \n install:\n-\t$(INSTALL) -m755 -d $(dest)/$(man1) $(dest)/$(man7)\n-\t$(INSTALL) $(DOC_MAN1) $(dest)/$(man1)\n-\t$(INSTALL) $(DOC_MAN7) $(dest)/$(man7)\n+\t$(INSTALL) -m755 -d $(DESTDIR)/$(man1) $(DESTDIR)/$(man7)\n+\t$(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1)\n+\t$(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7)\n \n # 'include' dependencies\n git-diff-%.txt: diff-format.txt diff-options.txt\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -41,7 +41,7 @@ prefix=$(HOME)\n bindir=$(prefix)/bin\n etcdir=$(prefix)/etc\n etcgitdir=$(etcdir)/git-core\n-# dest=\n+# DESTDIR=\n \n CC?=gcc\n AR?=ar\n@@ -197,8 +197,8 @@ check:\n ### Installation rules\n \n install: $(PROG) $(SCRIPTS)\n-\t$(INSTALL) -m755 -d $(dest)$(bindir)\n-\t$(INSTALL) $(PROG) $(SCRIPTS) $(dest)$(bindir)\n+\t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)\n \t$(MAKE) -C templates install\n \n install-tools:\ndiff --git a/templates/Makefile b/templates/Makefile\n--- a/templates/Makefile\n+++ b/templates/Makefile\n@@ -5,15 +5,15 @@ prefix=$(HOME)\n etcdir=$(prefix)/etc\n etcgitdir=$(etcdir)/git-core\n templatedir=$(etcgitdir)/templates\n-# dest=\n+# DESTDIR=\n \n all:\n clean:\n \n install:\n-\t$(INSTALL) -d -m755 $(dest)$(templatedir)/hooks/\n+\t$(INSTALL) -d -m755 $(DESTDIR)$(templatedir)/hooks/\n \t$(foreach s,$(wildcard hooks--*),\\\n \t\t$(INSTALL) -m644 $s \\\n-\t\t$(dest)$(templatedir)/hooks/$(patsubst hooks--%,%,$s);)\n-\t$(INSTALL) -d -m755 $(dest)$(templatedir)/info\n-\t$(INSTALL) -d -m755 $(dest)$(templatedir)/branches\n+\t\t$(DESTDIR)$(templatedir)/hooks/$(patsubst hooks--%,%,$s);)\n+\t$(INSTALL) -d -m755 $(DESTDIR)$(templatedir)/info\n+\t$(INSTALL) -d -m755 $(DESTDIR)$(templatedir)/branches\ndiff --git a/tools/Makefile b/tools/Makefile\n--- a/tools/Makefile\n+++ b/tools/Makefile\n@@ -8,7 +8,7 @@ INSTALL=install\n HOME=$(shell echo $$HOME)\n prefix=$(HOME)\n bindir=$(prefix)/bin\n-# dest=\n+# DESTDIR=\n \n PROGRAMS=git-mailsplit git-mailinfo\n SCRIPTS=git-applymbox git-applypatch\n@@ -19,8 +19,8 @@ git-%: %.c\n all: $(PROGRAMS)\n \n install: $(PROGRAMS) $(SCRIPTS)\n-\t$(INSTALL) -m755 -d $(dest)$(bindir)\n-\t$(INSTALL) $(PROGRAMS) $(SCRIPTS) $(dest)$(bindir)\n+\t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(PROGRAMS) $(SCRIPTS) $(DESTDIR)$(bindir)\n \n clean:\n \trm -f $(PROGRAMS) *.o\n"},{"id":"6866","messageId":"7v4qa4geiq.fsf@assigned-by-dhcp.cox.net","threadId":"1418","inReplyTo":"20050804235638.GL24479@pasky.ji.cz","subject":"Re: [PATCH] Use $DESTDIR instead of $dest","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-05T23:17:17Z","receivedAt":"2005-08-05T23:17:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis writes:\n\n> $DESTDIR is more usual during the build than $dest and is what is usually\n> used in the makefiles, so let's use it too.\n\nWhile I do not have much preference either way, I do not want to\nmake this kind of change without making corresponding changes to\nthe spec.in and debian/rules file in the same commit, or another\ncommit that immediately follow it. And I wanted to do a 0.99.4\ntomorrow, so I hope you would not mind if I placed this on\nhold...\n"},{"id":"7006","messageId":"20050809205725.GG7052@pasky.ji.cz","threadId":"1418","inReplyTo":"7v4qa4geiq.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use $DESTDIR instead of $dest","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-08-09T20:57:25Z","receivedAt":"2005-08-09T20:57:25Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sat, Aug 06, 2005 at 01:17:17AM CEST, I got a letter\nwhere Junio C Hamano told me that...\n> Petr Baudis writes:\n> \n> > $DESTDIR is more usual during the build than $dest and is what is usually\n> > used in the makefiles, so let's use it too.\n> \n> While I do not have much preference either way, I do not want to\n> make this kind of change without making corresponding changes to\n> the spec.in and debian/rules file in the same commit, or another\n> commit that immediately follow it. And I wanted to do a 0.99.4\n> tomorrow, so I hope you would not mind if I placed this on\n> hold...\n\nNo problem, this was just some of the last tidbits wrt. synchronization\nof the makefiles with Cogito.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nIf you want the holes in your knowledge showing up try teaching\nsomeone. -- Alan Cox\n"}]}