{"thread":{"id":"1412","subject":"[Patch] Fix sparse warnings","startedAt":"2005-08-04T03:35:37Z","lastAt":"2005-08-04T03:35:37Z","messageCount":1,"participants":["Alecs King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"6788","messageId":"20050804033537.GA5584@loalhost.H.qngy.gscas","threadId":"1412","inReplyTo":null,"subject":"[Patch] Fix sparse warnings","fromName":"Alecs King","fromEmail":"alecsk@gmail.com","sentAt":"2005-08-04T03:35:37Z","receivedAt":"2005-08-04T03:35:37Z","isPatch":true,"sender":{"key":"alecsk@gmail.com","avatar":"https://avatars.githubusercontent.com/u/84553?v=4"},"body":"fix one 'should it be static?' warning and\ntwo 'mixing declarations and code' warnings.\n\nSigned-off-by: Alecs King <alecsk@gmail.com>\n---\n\n connect.c        |    3 ++-\n ssh-pull.c       |    2 +-\n tools/mailinfo.c |    2 +-\n 3 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/connect.c b/connect.c\n--- a/connect.c\n+++ b/connect.c\n@@ -219,6 +219,7 @@ static struct ref *find_ref_by_name(stru\n int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail,\n \t       int nr_refspec, char **refspec, int all)\n {\n+\tint len;\n \tstruct refspec *rs = parse_ref_spec(nr_refspec, refspec);\n \n \tif (nr_refspec)\n@@ -236,7 +237,7 @@ int match_refs(struct ref *src, struct r\n \t\t\tif (!all)\n \t\t\t\tcontinue;\n \t\t\t/* Create a new one and link it */\n-\t\t\tint len = strlen(src->name) + 1;\n+\t\t\tlen = strlen(src->name) + 1;\n \t\t\tdst_peer = xcalloc(1, sizeof(*dst_peer) + len);\n \t\t\tmemcpy(dst_peer->name, src->name, len);\n \t\t\tmemcpy(dst_peer->new_sha1, src->new_sha1, 20);\ndiff --git a/ssh-pull.c b/ssh-pull.c\n--- a/ssh-pull.c\n+++ b/ssh-pull.c\n@@ -10,7 +10,7 @@ static int fd_out;\n static unsigned char remote_version = 0;\n static unsigned char local_version = 1;\n \n-ssize_t force_write(int fd, void *buffer, size_t length)\n+static ssize_t force_write(int fd, void *buffer, size_t length)\n {\n \tssize_t ret = 0;\n \twhile (ret < length) {\ndiff --git a/tools/mailinfo.c b/tools/mailinfo.c\n--- a/tools/mailinfo.c\n+++ b/tools/mailinfo.c\n@@ -152,13 +152,13 @@ static void cleanup_space(char *buf)\n \n static void handle_rest(void)\n {\n+\tFILE *out = cmitmsg;\n \tchar *sub = cleanup_subject(subject);\n \tcleanup_space(name);\n \tcleanup_space(date);\n \tcleanup_space(email);\n \tcleanup_space(sub);\n \tprintf(\"Author: %s\\nEmail: %s\\nSubject: %s\\nDate: %s\\n\\n\", name, email, sub, date);\n-\tFILE *out = cmitmsg;\n \n \tdo {\n \t\tif (!memcmp(\"diff -\", line, 6) ||\n-- \nAlecs King\n"}]}