{"thread":{"id":"14104","subject":"Code Formatting vs Trailing Whitespaces","startedAt":"2008-06-23T18:15:50Z","lastAt":"2008-06-24T06:01:35Z","messageCount":4,"participants":["Florian Köberle","Robin Rosenberg"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"80736","messageId":"485FE856.1080808@web.de","threadId":"14104","inReplyTo":null,"subject":"Code Formatting vs Trailing Whitespaces","fromName":"Florian Köberle","fromEmail":"florianskarten@web.de","sentAt":"2008-06-23T18:15:50Z","receivedAt":"2008-06-23T18:15:50Z","isPatch":false,"sender":{"key":"florianskarten@web.de","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nHi\n\nI noticed that Robin removed trailing whitespaces from my patch(thanks).\nIt appears that if you enable code formatting and the removement of\ntrailing whitespaces in the save actions option that the formatting\noption will win.\nIt will add a space at the second line of a javadoc comment:\n/**\n~ * <----\n\nI think this is a bug in eclipse, did any of you create a bug report for\nthat? Or a feature request for an \"no whitespace after javadoc\" option\nin the code formatter page?\n\nI want to have both options active, because I don't want to commit wrong\nformatted patches.\n\nBest regards,\nFlorian\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v1.4.6 (GNU/Linux)\nComment: Using GnuPG with Mozilla - http://enigmail.mozdev.org\n\niD8DBQFIX+hW59ca4mzhfxMRApU4AKCbYzwRFqVcBCr11zc9lk6jqick2ACeMBhW\nnXOoN4nIsTjzWWhQzDOxiz4=\n=bm+i\n-----END PGP SIGNATURE-----\n"},{"id":"80759","messageId":"200806232231.38391.robin.rosenberg.lists@dewire.com","threadId":"14104","inReplyTo":"485FE856.1080808@web.de","subject":"Re: Code Formatting vs Trailing Whitespaces","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-06-23T20:31:38Z","receivedAt":"2008-06-23T20:31:38Z","isPatch":false,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"måndagen den 23 juni 2008 20.15.50 skrev Florian Köberle:\n> Hi\n> \n> I noticed that Robin removed trailing whitespaces from my patch(thanks).\n> It appears that if you enable code formatting and the removement of\n> trailing whitespaces in the save actions option that the formatting\n> option will win.\n> It will add a space at the second line of a javadoc comment:\n> /**\n> ~ * <----\n> \n> I think this is a bug in eclipse, did any of you create a bug report for\n> that? Or a feature request for an \"no whitespace after javadoc\" option\n> in the code formatter page?\n\nThis one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619\n\n> I want to have both options active, because I don't want to commit wrong\n> formatted patches.\n\nWhen I have both options active, it adds the whitespace when formatting, but\nremoves it when saving in (version 3.3.2).\n\n-- robin\n"},{"id":"80768","messageId":"486012F2.6070006@web.de","threadId":"14104","inReplyTo":"200806232231.38391.robin.rosenberg.lists@dewire.com","subject":"Re: Code Formatting vs Trailing Whitespaces","fromName":"Florian Köberle","fromEmail":"florianskarten@web.de","sentAt":"2008-06-23T21:17:38Z","receivedAt":"2008-06-23T21:17:38Z","isPatch":false,"sender":{"key":"florianskarten@web.de","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nHi\n\n| This one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619\nThank you. I voted for that feature, maybe it helps to draw attention to\nthis feature wish.\n\n| When I have both options active, it adds the whitespace when\nformatting, but\n| removes it when saving in (version 3.3.2).\nStrange, I use version 3.3.2 too. I configured it in the workspace settings.\nMaybe you did in the project settings?\n\nBest regards,\nFlorian\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v1.4.6 (GNU/Linux)\nComment: Using GnuPG with Mozilla - http://enigmail.mozdev.org\n\niD8DBQFIYBLy59ca4mzhfxMRAs7vAJ4la1ABhh5Q6pwvhGdx9bZHJvQvWwCfS8nr\n2oakNrgbvGSVlGkLzwlJYbw=\n=rZFh\n-----END PGP SIGNATURE-----\n"},{"id":"80836","messageId":"200806240801.35907.robin.rosenberg.lists@dewire.com","threadId":"14104","inReplyTo":"486012F2.6070006@web.de","subject":"Re: Code Formatting vs Trailing Whitespaces","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-06-24T06:01:35Z","receivedAt":"2008-06-24T06:01:35Z","isPatch":false,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"måndagen den 23 juni 2008 23.17.38 skrev Florian Köberle:\n> Hi\n> \n> | This one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619\n> Thank you. I voted for that feature, maybe it helps to draw attention to\n> this feature wish.\n> \n> | When I have both options active, it adds the whitespace when\n> formatting, but\n> | removes it when saving in (version 3.3.2).\n> Strange, I use version 3.3.2 too. I configured it in the workspace settings.\n> Maybe you did in the project settings?\n\nIndeed.\n\n-- robin\n"}]}