{"thread":{"id":"14058","subject":"git svn --add-author-from implies --use-log-author","startedAt":"2008-06-20T11:31:47Z","lastAt":"2008-06-24T16:02:41Z","messageCount":7,"participants":["Fredrik Skolmli","Mircea Bardac","Avery Pennarun"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"80461","messageId":"20080620113147.GC27940@frsk.net","threadId":"14058","inReplyTo":null,"subject":"git svn --add-author-from implies --use-log-author","fromName":"Fredrik Skolmli","fromEmail":"fredrik@frsk.net","sentAt":"2008-06-20T11:31:47Z","receivedAt":"2008-06-20T11:31:47Z","isPatch":false,"sender":{"key":"fredrik@frsk.net","avatar":"https://avatars.githubusercontent.com/u/40261?v=4"},"body":"Hi,\n\nwhen running git svn dcommit --add-author-from on a git-svn repository,\n--use-log-author is not implied by itself. This causes the rewritten history\nto not show the author in the way most users would expect it to be, \"Name\n\", but instead \"\".\n\nInstead of forcing people to write \"svn dcommit --add-author-from\n--use-log-author\", is it a bad move to imply the last argument, making the\nhistory look more user-friendly to start with?\n\nAny thoughts?\n\n-- \nRegards,\nFredrik Skolmli\n"},{"id":"80485","messageId":"485BB134.9080203@mircea.bardac.net","threadId":"14058","inReplyTo":"20080620113147.GC27940@frsk.net","subject":"Re: git svn --add-author-from implies --use-log-author","fromName":"Mircea Bardac","fromEmail":"dev@mircea.bardac.net","sentAt":"2008-06-20T13:31:32Z","receivedAt":"2008-06-20T13:31:32Z","isPatch":false,"sender":{"key":"dev@mircea.bardac.net","avatar":"https://gravatar.com/avatar/9cf887bf86f677aafb60f450e5898c0342283ebf3633c9bdbec1233256f2510f?d=mp&s=160"},"body":"Hi,\n\nFredrik Skolmli wrote:\n> when running git svn dcommit --add-author-from on a git-svn repository,\n> --use-log-author is not implied by itself. This causes the rewritten history\n> to not show the author in the way most users would expect it to be, \"Name\n> \", but instead \"\".\n> \n> Instead of forcing people to write \"svn dcommit --add-author-from\n> --use-log-author\", is it a bad move to imply the last argument, making the\n> history look more user-friendly to start with?\n\nThe documentation mentions that these 2 parameters are for init and, \nlike other parameters, I had the feeling they will affect either the \n\"init\" process or the entire existance of the repository. Now that I \nlook better, I see that there is no \"config\" note next to them.\n\n From my point of view, they should be repository config options, \naffecting all commits. I can't see a reason for having only sometimes\n--add-author-from. If you want to commit information about the authors \nin regards to a SVN repository, you'll always want that option to be on. \nIf you want to have authors properly identified when getting something \nout of the SVN repository, you'll always want to have --use-log-author on.\n\nI would also like some option to stop pushing a commit if it doesn't \nhave any From/Signed-off-by line in it.\n\nMircea\n\nP.S. I am very curious why using From and not Signed-off-by. I had the \nfeeling that Signed-off-by is being used to also mark the path of a \npatch. Also, is there a centralized list of all the ways a patch can be \n\"marked\"\n\n--\nhttp://mircea.bardac.net\n"},{"id":"80754","messageId":"32541b130806231312l679aba31ra3daac2bb634cf1b@mail.gmail.com","threadId":"14058","inReplyTo":"485BB134.9080203@mircea.bardac.net","subject":"Re: git svn --add-author-from implies --use-log-author","fromName":"Avery Pennarun","fromEmail":"apenwarr@gmail.com","sentAt":"2008-06-23T20:12:37Z","receivedAt":"2008-06-23T20:12:37Z","isPatch":false,"sender":{"key":"apenwarr@gmail.com","avatar":"https://avatars.githubusercontent.com/u/20592?v=4"},"body":"On 6/20/08, Mircea Bardac wrote:\n> > when running git svn dcommit --add-author-from on a git-svn repository,\n> > --use-log-author is not implied by itself. This causes the rewritten history\n> > to not show the author in the way most users would expect it to be, \"Name\n> > \", but instead \"\".\n> >\n> > Instead of forcing people to write \"svn dcommit --add-author-from\n> > --use-log-author\", is it a bad move to imply the last argument, making the\n> > history look more user-friendly to start with?\n>\n> The documentation mentions that these 2 parameters are for init and, like\n> other parameters, I had the feeling they will affect either the \"init\"\n> process or the entire existance of the repository. Now that I look better, I\n> see that there is no \"config\" note next to them.\n\nThey are separate options; --add-author-from affects dcommit (but not\nfetch or clone), while --use-log-author affects fetch and clone (but\nnot dcommit). They do different things, and I can imagine wanting one\nand not the other, so having one imply the other isn't very safe.\n\nYou can set config options for these, however:\n\ngit config svn.addAuthorFrom true\ngit config svn.useLogAuthor true\n\n(I actually use \"git config --global\" to set these on my system so\nthey apply to all my git-svn repositories.)\n\n> I would also like some option to stop pushing a commit if it doesn't have\n> any From/Signed-off-by line in it.\n[...]\n> P.S. I am very curious why using From and not Signed-off-by. I had the\n> feeling that Signed-off-by is being used to also mark the path of a patch.\n> Also, is there a centralized list of all the ways a patch can be \"marked\"\n\nSigned-off-by is a legal declaration. Please read the documentation\ncarefully before using it.\n\nFrom: is automatically added (when you enable the option and there's\nno Signed-off-by or From already) and is just informational.\n\nHave fun,\n\nAvery\n"},{"id":"80770","messageId":"48601432.2090707@mircea.bardac.net","threadId":"14058","inReplyTo":"32541b130806231312l679aba31ra3daac2bb634cf1b@mail.gmail.com","subject":"Re: git svn --add-author-from implies --use-log-author","fromName":"Mircea Bardac","fromEmail":"dev@mircea.bardac.net","sentAt":"2008-06-23T21:22:58Z","receivedAt":"2008-06-23T21:22:58Z","isPatch":false,"sender":{"key":"dev@mircea.bardac.net","avatar":"https://gravatar.com/avatar/9cf887bf86f677aafb60f450e5898c0342283ebf3633c9bdbec1233256f2510f?d=mp&s=160"},"body":"\n\nAvery Pennarun wrote:\n> You can set config options for these, however:\n> \n> git config svn.addAuthorFrom true\n> git config svn.useLogAuthor true\n> \n> (I actually use \"git config --global\" to set these on my system so\n> they apply to all my git-svn repositories.)\n\nOh great. This is what I actually wanted. Makes a lot more sense to have \nthem as (global) variables.\n\nMy initial thought was that there are (somewhere) some variables being \nset for the repository by using --add-author-from and --use-log-author \nwith \"git svn clone ...\". I find this quite intuitive (and maybe this \nshould be default?). I can't see a reason for using these options once \nand not using them later, but it might just be me.\n\n\n>> P.S. I am very curious why using From and not Signed-off-by. I had the\n>> feeling that Signed-off-by is being used to also mark the path of a patch.\n>> Also, is there a centralized list of all the ways a patch can be \"marked\"\n> \n> Signed-off-by is a legal declaration. Please read the documentation\n> carefully before using it.\n> \n> From: is automatically added (when you enable the option and there's\n> no Signed-off-by or From already) and is just informational.\n\nI have found that Documentation/SubmittingPatches contains info on how \nto use \"Signed-off-by:\"/\"Acked-by:\"/a little bit of \"From:\" but, as far \nas I remember, others have been/are used. Are they all gathered \nsomewhere, as recommendations?\n\nMany thanks.\n\n-- \nMircea\nhttp://mircea.bardac.net\n"},{"id":"80776","messageId":"32541b130806231431r61da1f02v663463cedb5b96ef@mail.gmail.com","threadId":"14058","inReplyTo":"48601432.2090707@mircea.bardac.net","subject":"Re: git svn --add-author-from implies --use-log-author","fromName":"Avery Pennarun","fromEmail":"apenwarr@gmail.com","sentAt":"2008-06-23T21:31:43Z","receivedAt":"2008-06-23T21:31:43Z","isPatch":false,"sender":{"key":"apenwarr@gmail.com","avatar":"https://avatars.githubusercontent.com/u/20592?v=4"},"body":"On 6/23/08, Mircea Bardac wrote:\n> Avery Pennarun wrote:\n>\n> > You can set config options for these, however:\n> >\n> > git config svn.addAuthorFrom true\n> > git config svn.useLogAuthor true\n> >\n> > (I actually use \"git config --global\" to set these on my system so\n> > they apply to all my git-svn repositories.)\n>\n> Oh great. This is what I actually wanted. Makes a lot more sense to have\n> them as (global) variables.\n>\n> My initial thought was that there are (somewhere) some variables being set\n> for the repository by using --add-author-from and --use-log-author with \"git\n> svn clone ...\". I find this quite intuitive (and maybe this should be\n> default?). I can't see a reason for using these options once and not using\n> them later, but it might just be me.\n\nI agree, it's a good idea to save them to the config at git svn clone time.\n\nWhen I added --add-author-from I just did it like --use-log-author,\nthen I had to read the source code to find out how to set them as\nconfig variables :)\n\nI'm sure some patches (at least for the documentation) would be welcomed.\n\n> I have found that Documentation/SubmittingPatches contains info on how to\n> use \"Signed-off-by:\"/\"Acked-by:\"/a little bit of \"From:\" but, as far as I\n> remember, others have been/are used. Are they all gathered somewhere, as\n> recommendations?\n\nI don't know of any definitive reference, but Signed-off-by and\nAcked-by seem to be the important ones. From: (as part of the commit\nmessage) seems to be a git-svn extension that I invented. From: (as a\nheader in the commit message) is interpreted as the committer name by\ngit-am, I think, but you almost never need that.\n\nHave fun,\n\nAvery\n"},{"id":"80841","messageId":"20080624073707.GA6495@frsk.net","threadId":"14058","inReplyTo":"32541b130806231312l679aba31ra3daac2bb634cf1b@mail.gmail.com","subject":"Re: git svn --add-author-from implies --use-log-author","fromName":"Fredrik Skolmli","fromEmail":"fredrik@frsk.net","sentAt":"2008-06-24T07:37:07Z","receivedAt":"2008-06-24T07:37:07Z","isPatch":false,"sender":{"key":"fredrik@frsk.net","avatar":"https://avatars.githubusercontent.com/u/40261?v=4"},"body":"On Mon, Jun 23, 2008 at 04:12:37PM -0400, Avery Pennarun wrote:\n\n> They are separate options; --add-author-from affects dcommit (but not\n> fetch or clone), while --use-log-author affects fetch and clone (but\n> not dcommit). They do different things, and I can imagine wanting one\n> and not the other, so having one imply the other isn't very safe.\n\nNo, I agree implying it isn't safe. The need for implying --use-log-author\nwhen doing --add-author-from might just be me being to lazy to remember both\nflags. :-)\n\n> You can set config options for these, however:\n> \n> git config svn.addAuthorFrom true\n> git config svn.useLogAuthor true\n> \n> (I actually use \"git config --global\" to set these on my system so\n> they apply to all my git-svn repositories.)\n\nHm, I did not know about these config options. Are they documented somewhere?\n\n- F\n\n-- \nRegards,\nFredrik Skolmli\n"},{"id":"80916","messageId":"1214323361-13136-1-git-send-email-apenwarr@gmail.com","threadId":"14058","inReplyTo":"20080624073707.GA6495@frsk.net","subject":"[PATCH] git-svn docs: mention svn.addAuthorFrom and svn.useLogAuthor config options.","fromName":"Avery Pennarun","fromEmail":"apenwarr@gmail.com","sentAt":"2008-06-24T16:02:41Z","receivedAt":"2008-06-24T16:02:41Z","isPatch":true,"sender":{"key":"apenwarr@gmail.com","avatar":"https://avatars.githubusercontent.com/u/20592?v=4"},"body":"At least one person got confused because they thought it was necessary to\nprovide these on the command line every time.\n\nSigned-off-by: Avery Pennarun \n---\n Documentation/git-svn.txt | 9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 97bed54..e8200ce 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -64,13 +64,16 @@ COMMANDS\n --use-log-author;;\n \tWhen retrieving svn commits into git (as part of fetch, rebase, or\n \tdcommit operations), look for the first From: or Signed-off-by: line\n-\tin the log message and use that as the author string.\n+\tin the log message and use that as the author string. (To enable\n+\tthis permanently, use git config svn.useLogAuthor)\n --add-author-from;;\n \tWhen committing to svn from git (as part of commit or dcommit\n \toperations), if the existing log message doesn't already have a\n \tFrom: or Signed-off-by: line, append a From: line based on the\n-\tgit commit's author string. If you use this, then --use-log-author\n-\twill retrieve a valid author string for all commits.\n+\tgit commit's author string. If you use this, then if you enable\n+\t--use-log-author it will retrieve a valid author string for all\n+\tcommits. (To enable this option permanently, use git config\n+\tsvn.addAuthorFrom)\n --username=;;\n \tFor transports that SVN handles authentication for (http,\n \thttps, and plain svn), specify the username. For other\n-- \n1.5.6.56.g29b0d\n"}]}