{"thread":{"id":"13953","subject":"[PATCH] gitk - work around stderr redirection on Cygwin","startedAt":"2008-06-14T16:57:48Z","lastAt":"2008-07-18T02:41:47Z","messageCount":6,"participants":["Mark Levedahl","Junio C Hamano","Eric Blake"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"79863","messageId":"1213462668-424-1-git-send-email-mlevedahl@gmail.com","threadId":"13953","inReplyTo":null,"subject":"[PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2008-06-14T16:57:48Z","receivedAt":"2008-06-14T16:57:48Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"Cygwin is *still* shipping with antiquated Tcl 8.4.1, and will continue\nto do so for the indefinite future. This version does not understand\nthe \"2>@1\" redirection syntax, so such redirection of stderr must be\ndone using sh.\n\nSigned-off-by: Mark Levedahl <mlevedahl@gmail.com>\n---\n gitk |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex fddcb45..386a385 100755\n--- a/gitk\n+++ b/gitk\n@@ -7625,7 +7625,7 @@ proc resethead {} {\n     tkwait window $w\n     if {!$confirm_ok} return\n     if {[catch {set fd [open \\\n-\t    [list | git reset --$resettype $rowmenuid 2>@1] r]} err]} {\n+\t    [list | sh -c \"git reset --$resettype $rowmenuid 2>&1\"] r]} err]} {\n \terror_popup $err\n     } else {\n \tdohidelocalchanges\n@@ -7691,7 +7691,7 @@ proc cobranch {} {\n     update\n     dohidelocalchanges\n     if {[catch {\n-\tset fd [open [list | git checkout $headmenuhead 2>@1] r]\n+\tset fd [open [list | sh -c \"git checkout $headmenuhead 2>&1\"] r]\n     } err]} {\n \tnotbusy checkout\n \terror_popup $err\n-- \n1.5.6.rc2.67.g19fe3\n"},{"id":"83173","messageId":"487A6780.7030500@gmail.com","threadId":"13953","inReplyTo":"1213462668-424-1-git-send-email-mlevedahl@gmail.com","subject":"Re: [PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2008-07-13T20:37:20Z","receivedAt":"2008-07-13T20:37:20Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"Mark Levedahl wrote:\n> Cygwin is *still* shipping with antiquated Tcl 8.4.1, and will continue\n> to do so for the indefinite future. This version does not understand\n> the \"2>@1\" redirection syntax, so such redirection of stderr must be\n> done using sh.\n>   \n\nPing. This bug is in 1.5.6.x, and thus also in the current Cygwin git \nrelease: as a result, several gitk context menu items cause errors. (Let \nme know if I should resend the patch).\n\nMark\n"},{"id":"83179","messageId":"7vfxqdqxh7.fsf@gitster.siamese.dyndns.org","threadId":"13953","inReplyTo":"487A6780.7030500@gmail.com","subject":"Re: [PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-13T21:35:00Z","receivedAt":"2008-07-13T21:35:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Levedahl <mlevedahl@gmail.com> writes:\n\n> Mark Levedahl wrote:\n>> Cygwin is *still* shipping with antiquated Tcl 8.4.1, and will continue\n>> to do so for the indefinite future. This version does not understand\n>> the \"2>@1\" redirection syntax, so such redirection of stderr must be\n>> done using sh.\n>\n> Ping. This bug is in 1.5.6.x, and thus also in the current Cygwin git\n> release: as a result, several gitk context menu items cause\n> errors. (Let me know if I should resend the patch).\n\nIn the meantime, is it an option to apply this as a port specific patch\nwhen Cygwin and whichever distribution ship with old Tcl package their\nbinary releases?\n\nJust checking how urgent this issue is (8.4.1 was from Oct 2002 if I am\nnot mistaken) for maintainers of Cygwin port, and I am suspecting that\nkernel folks are somewhat busy near/around OLS/KS timeframe (but not me).\n"},{"id":"83186","messageId":"487A7949.9050800@gmail.com","threadId":"13953","inReplyTo":"7vfxqdqxh7.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2008-07-13T21:53:13Z","receivedAt":"2008-07-13T21:53:13Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"Junio C Hamano wrote:\n> Mark Levedahl <mlevedahl@gmail.com> writes:\n>\n>   \n>> Mark Levedahl wrote:\n>>     \n>>> Cygwin is *still* shipping with antiquated Tcl 8.4.1, and will continue\n>>> to do so for the indefinite future. This version does not understand\n>>> the \"2>@1\" redirection syntax, so such redirection of stderr must be\n>>> done using sh.\n>>>       \n>> Ping. This bug is in 1.5.6.x, and thus also in the current Cygwin git\n>> release: as a result, several gitk context menu items cause\n>> errors. (Let me know if I should resend the patch).\n>>     \n>\n> In the meantime, is it an option to apply this as a port specific patch\n> when Cygwin and whichever distribution ship with old Tcl package their\n> binary releases?\n>\n> Just checking how urgent this issue is (8.4.1 was from Oct 2002 if I am\n> not mistaken) for maintainers of Cygwin port, and I am suspecting that\n> kernel folks are somewhat busy near/around OLS/KS timeframe (but not me).\n>\n>   \n(I didn't trim the message as I've copied the Cygwin git maintainer).\n\nI certainly have this patch in my tree so the folks I supply git to who \nuse Cygwin have this patch. The question of whether to maintain this out \nof tree for the official Cygwin release is up to Eric.\n\nMark\n"},{"id":"83638","messageId":"487EC2BB.5050503@byu.net","threadId":"13953","inReplyTo":"487A7949.9050800@gmail.com","subject":"Re: [PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Eric Blake","fromEmail":"ebb9@byu.net","sentAt":"2008-07-17T03:55:39Z","receivedAt":"2008-07-17T03:55:39Z","isPatch":true,"sender":{"key":"eblake@redhat.com","avatar":"https://avatars.githubusercontent.com/u/32933908?v=4"},"body":"According to Mark Levedahl on 7/13/2008 3:53 PM:\n>>>    \n>>>> Cygwin is *still* shipping with antiquated Tcl 8.4.1\n>>>>       \n>>> Ping. This bug is in 1.5.6.x, and thus also in the current Cygwin git\n>>> release: as a result, several gitk context menu items cause\n>>> errors. (Let me know if I should resend the patch).\n\n> I certainly have this patch in my tree so the folks I supply git to who \n> use Cygwin have this patch. The question of whether to maintain this out \n> of tree for the official Cygwin release is up to Eric.\n\nCould you point me to the patch?  I need to roll the Cygwin git release of\n1.5.6.3 anyway (in part because cygwin has upgraded from perl 5.8 to\n5.10).  This sounds like something worth me including as a vendor patch,\nif it does not get folded into the main repo.\n\n-- \nDon't work too hard, make some time for fun as well!\n\nEric Blake             ebb9@byu.net\n"},{"id":"83815","messageId":"488002EB.8080100@gmail.com","threadId":"13953","inReplyTo":"487EC2BB.5050503@byu.net","subject":"Re: [PATCH] gitk - work around stderr redirection on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2008-07-18T02:41:47Z","receivedAt":"2008-07-18T02:41:47Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"Eric Blake wrote:\n> Could you point me to the patch?  I need to roll the Cygwin git \n> release of\n> 1.5.6.3 anyway (in part because cygwin has upgraded from perl 5.8 to\n> 5.10).  This sounds like something worth me including as a vendor patch,\n> if it does not get folded into the main repo.\n>\nThe patch is at the top of this thread:\nhttp://article.gmane.org/gmane.comp.version-control.git/85023/match=gitk+work+around+stderr+redirection\n\n(I'll send you a patch against Junio's tree privately as a backup).\n\nMark\n"}]}