{"thread":{"id":"13865","subject":"[PATCH] Port to 12 other Platforms.","startedAt":"2008-06-08T15:28:42Z","lastAt":"2008-06-08T21:49:31Z","messageCount":15,"participants":["Boyd Lynn Gerber","Jakub Narebski","Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"79123","messageId":"Pine.LNX.4.64.0806080926240.18454@xenau.zenez.com","threadId":"13865","inReplyTo":null,"subject":"[PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T15:28:42Z","receivedAt":"2008-06-08T15:28:42Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"\nThis patch adds support to compile git on 12 additional platforms.\nThey are based on UNIX Systems Labs (USL)/Novell and SYS V\nbased OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\nSCO pre OSR 5 OS's to build and run git.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\n---\nMakefile\n\nAdd changes for System V, UnixWare, SCO OS's\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\nof the SCO OS's. It is used just like Apple and BSD, both of these\nshouldn't have _XOPEN_SOURCE defined.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..026de2f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -564,6 +564,45 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kthread\n+\tendif\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..c04e8ba 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n-- \n1.5.2.4\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79124","messageId":"m3prqsvsiq.fsf@localhost.localdomain","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806080926240.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-06-08T15:46:43Z","receivedAt":"2008-06-08T15:46:43Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> This patch adds support to compile git on 12 additional platforms.\n> They are based on UNIX Systems Labs (USL)/Novell and SYS V\n> based OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\n> SCO pre OSR 5 OS's to build and run git.\n> \n> Signed-off-by: Boyd Lynn Gerber \n> ---\n[...]\n> git-compat-util.h\n> \n> __USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\n> compiler and/or some SysV based OS's.\n> \n> __M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\n> of the SCO OS's. It is used just like Apple and BSD, both of these\n> shouldn't have _XOPEN_SOURCE defined.\n\nAbove info is neither in commit message, not in comment in some file.\nIt would be nice to have it in somewhere, and not only in mailing list\narchives.\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"79127","messageId":"Pine.LNX.4.64.0806080959390.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"m3prqsvsiq.fsf@localhost.localdomain","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T16:04:21Z","receivedAt":"2008-06-08T16:04:21Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Jakub Narebski wrote:\n> Boyd Lynn Gerber writes:\n> \n> > This patch adds support to compile git on 12 additional platforms.\n> > They are based on UNIX Systems Labs (USL)/Novell and SYS V\n> > based OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\n> > SCO pre OSR 5 OS's to build and run git.\n> > \n> > Signed-off-by: Boyd Lynn Gerber \n> > ---\n> [...]\n> > git-compat-util.h\n> > \n> > __USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\n> > compiler and/or some SysV based OS's.\n> > \n> > __M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\n> > of the SCO OS's. It is used just like Apple and BSD, both of these\n> > shouldn't have _XOPEN_SOURCE defined.\n> \n> Above info is neither in commit message, not in comment in some file.\n> It would be nice to have it in somewhere, and not only in mailing list\n> archives.\n\nThis was from my own copy of the master archive. It is my proposal. I \nthought you had to get an OK from this list before you do a push to the \nmain archive. Am I missing something? I am new to this list and the \nproper methods for submitting patches. I thought I was following the \nguidelines from \n\nhttp://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n\nWhat am I missing?\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79131","messageId":"vpqve0j3nkd.fsf@bauges.imag.fr","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806080959390.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2008-06-08T16:21:06Z","receivedAt":"2008-06-08T16:21:06Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> This was from my own copy of the master archive. It is my proposal. I \n> thought you had to get an OK from this list before you do a push to the \n> main archive.\n\nYou won't do a push, the maintainer will apply the patch if it seems\nOK.\n\n> What am I missing?\n\nThe format used to send patches. git format-patch and git send-email\nwould do that for you, but in particular : what comes after « --- »\nand before the patch itself is ignored by the tools, just an\ninformative message for people reading your email. What comes before\nthis « --- » is the commit message.\n\n-- \nMatthieu\n"},{"id":"79132","messageId":"Pine.LNX.4.64.0806081028460.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"vpqve0j3nkd.fsf@bauges.imag.fr","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T16:33:40Z","receivedAt":"2008-06-08T16:33:40Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Matthieu Moy wrote:\n> Boyd Lynn Gerber writes:\n> > This was from my own copy of the master archive. It is my proposal. I \n> > thought you had to get an OK from this list before you do a push to the \n> > main archive.\n> \n> You won't do a push, the maintainer will apply the patch if it seems\n> OK.\n\nThanks, I understand better now.\n \n> > What am I missing?\n> \n> The format used to send patches. git format-patch and git send-email\n> would do that for you, but in particular : what comes after « --- »\n> and before the patch itself is ignored by the tools, just an\n> informative message for people reading your email. What comes before\n> this « --- » is the commit message.\n\n\nI moved the message from above my commiter message because I was told to \nadd comments after the --- with the file being modified. The reasons for \nthe modifications. I used git format-patch -p -M -B origin to generate \nthis email. All I did was read the contents into the email I create for \nposting. This was the advice I was given on IRC as the best method to \ncreate/send the patch. When on IRC I was omitting the -p and was not \ngetting the .patch file. After reading the docs over and over I finally \nnoticed I was missing the -p. Once I added it I got the patch file and \nthen I emailed it to the list.\n\nThanks,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79137","messageId":"200806081919.05273.jnareb@gmail.com","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806081028460.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-06-08T17:19:03Z","receivedAt":"2008-06-08T17:19:03Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:\n> On Sun, 8 Jun 2008, Matthieu Moy wrote:\n>> Boyd Lynn Gerber writes:\n>>>\n>>> This was from my own copy of the master archive. It is my proposal. I \n>>> thought you had to get an OK from this list before you do a push to the \n>>> main archive.\n>> \n>> You won't do a push, the maintainer will apply the patch if it seems\n>> OK.\n> \n> Thanks, I understand better now.\n\nBy the way, if you want to send large series of patches, and you have\nyour git repository published somewhere (repo.or.cz, gitorious, github,\nfreedektop, kernel.org), sometimes pull request is used. As you\nusually use git-format-patch (perhaps together with git-send-email)\nwhen sending patches, you can use output of git-request-pull there.\n\nJust FYI, you can safely ignore above.\n\n>>> What am I missing?\n>> \n>> The format used to send patches. git format-patch and git send-email\n>> would do that for you, but in particular : what comes after « --- »\n>> and before the patch itself is ignored by the tools, just an\n>> informative message for people reading your email. What comes before\n>> this « --- » is the commit message.\n> \n> I moved the message from above my commiter message because I was told to \n> add comments after the --- with the file being modified. The reasons for \n> the modifications. I used git format-patch -p -M -B origin to generate \n> this email. All I did was read the contents into the email I create for \n> posting. This was the advice I was given on IRC as the best method to \n> create/send the patch. When on IRC I was omitting the -p and was not \n> getting the .patch file. After reading the docs over and over I finally \n> noticed I was missing the -p. Once I added it I got the patch file and \n> then I emailed it to the list.\n\nStrange. While in git-diff family of commands '-p' means generate\ndiff in patchset format:\n\n -p Generate patch (see section on generating patches).\n\nit has different meaning (oops) in git-format-patch:\n\n -p Generate patches without diffstat.\n\n(What is probably a bug in git-format-patch it doesn't add \"---\\n\"\nseparator between commit message and patch itself).\n\n\nEverything between \"---\\n\" after commit message (usually ending in\nSigned-off-by) and the diffstat and patch is a transient comment,\nwhich won't get included in commit message, and wouldn't be anywhere\nin the repository, neither in contents not in commits.\n\nWhat you put there is information which shouldn't be in commit message,\nlike for example difference from previous version of patch, sometimes\nexplanation behind _why_ of this patch; you put there to which branch\nthis patch applies, if it is not 'master' (por example if it requires\nmaterial from 'next') or if given patch depends on earlier patch NOT\nin the series.\n\nIMVVVHO you should put verbatim copy of certificate of origin there,\nbut put the comment about which operating systems needs which defines,\nor use which defines, and why either in commit message, in comment in\nsome file, or both.\n\nHTH (Hope That Helps).\n-- \nJakub Narebski\nPoland\n"},{"id":"79142","messageId":"Pine.LNX.4.64.0806081147550.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"200806081919.05273.jnareb@gmail.com","subject":"Re: [PATCH] Port to 12 other Platforms. (Comments)","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T17:58:39Z","receivedAt":"2008-06-08T17:58:39Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Jakub Narebski wrote:\n> On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:\n> > On Sun, 8 Jun 2008, Matthieu Moy wrote:\n> >> Boyd Lynn Gerber writes:\n> >>> This was from my own copy of the master archive. It is my proposal. I \n> >>> thought you had to get an OK from this list before you do a push to the \n> >>> main archive.\n> >> \n> >> You won't do a push, the maintainer will apply the patch if it seems\n> >> OK.\n> > Thanks, I understand better now.\n> \n> By the way, if you want to send large series of patches, and you have\n> your git repository published somewhere (repo.or.cz, gitorious, github,\n> freedektop, kernel.org), sometimes pull request is used. As you\n> usually use git-format-patch (perhaps together with git-send-email)\n> when sending patches, you can use output of git-request-pull there.\n> \n> Just FYI, you can safely ignore above.\n\nI have setup a repo on www.zenez.com.\n\nI just did a git clone give://www.zenez.com/git git.\n\nI am trying to get various communities to use git. So I want all there \nchanges to go to my master repo. I am trying to get those that still \nsupport/work on SCO OS's to embrase the Open Source Software (OSS) \nconcepts and give back to the OSS community inspite of the SCO Group and \nwhat they are doing. I am a firm believer of OSS Concepts. I still have \nto support many SCO Systems. My clients applicatios only run on them. \nBut I want as much as I can to promote the OSS Concepts and have them \nbecome a major part of the business I support. \n\nBecause of all the anti SCO I want them to have a safe place to use and \nprovide good services for them. Saddly, I do this because of my own \nexperience with retrobuction from fanatics. I have had over 650 GB over \nwritten with \"DIE SCO\" I was away for a week and when I came back I had \nhad a break-in on one system and that was the result. I have had DOS \nattacks and many others. So I am trying to be a bridge between the to \ncommunities and other communites to promote the true spirt of Open Source.\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79143","messageId":"Pine.LNX.4.64.0806081200240.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806081147550.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms. (Comments)","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T18:01:29Z","receivedAt":"2008-06-08T18:01:29Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:\n> I have setup a repo on www.zenez.com.\n> \n> I just did a git clone give://www.zenez.com/git git.\n\nSorry type-o should have been\n\ngit clone git://www.zenez.com/git git\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79149","messageId":"7vhcc3kbdw.fsf@gitster.siamese.dyndns.org","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806080959390.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-06-08T18:52:11Z","receivedAt":"2008-06-08T18:52:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> On Sun, 8 Jun 2008, Jakub Narebski wrote:\n>> Boyd Lynn Gerber writes:\n>> \n>> > This patch adds support to compile git on 12 additional platforms.\n>> > They are based on UNIX Systems Labs (USL)/Novell and SYS V\n>> > based OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\n>> > SCO pre OSR 5 OS's to build and run git.\n>> > \n>> > Signed-off-by: Boyd Lynn Gerber \n>> > ---\n>> [...]\n>> > git-compat-util.h\n>> > \n>> > __USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\n>> > compiler and/or some SysV based OS's.\n>> > \n>> > __M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\n>> > of the SCO OS's. It is used just like Apple and BSD, both of these\n>> > shouldn't have _XOPEN_SOURCE defined.\n>> \n>> Above info is neither in commit message, not in comment in some file.\n>> It would be nice to have it in somewhere, and not only in mailing list\n>> archives.\n>\n> This was from my own copy of the master archive. It is my proposal. I \n> thought you had to get an OK from this list before you do a push to the \n> main archive. Am I missing something? I am new to this list and the \n> proper methods for submitting patches. I thought I was following the \n> guidelines from \n>\n> http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n>\n> What am I missing?\n\nIt might appear that many people somehow hate your patch and ganging up on\nit, and if so I apologize for them and I assure you that they do not mean\nill.\n\nThere seem to be some confusion either in the SubmittingPatches document\nor the way some suggestions have been given in the recent postings by\npeople, so let's clear it up first.\n\nThere are four different kinds of information you would want to convey\nwhen you send patches to the list. This is just a convention around here,\nbut the tool is built to support that convention, so you can consider it\nthe suggested BCP in any git managed projects that employ e-mail based\nworkflow.\n\n * What the patch is about, a short and sweet summary. This should be\n something that can be used to identify the change and it should be easy\n to tell what it is about when viewed in \"git log --pretty=oneline\" or\n in \"git shortlog\" output. This goes to Subject: line.\n\n * Justification for the patch. When anybody views with \"git show\" the\n change after it gets committed, \"how\" the patch changes can be seen,\n but what cannot be easily seen is \"why\", and the commit message is the\n place to describe it. This takes various forms, depending on the\n nature of the patch:\n\n * For a fix, describe how the status-quo is broken, what the desired\n behaviour should be, and discuss and defend why you chose this\n specific approach to fix among other possible avenues. E.g. \"If you\n use this and that option together, the command does this, which is\n not correct. It should do that instead. For that, we introduce\n helper function X and Y use them in each codepaths. We could instead\n use a single helper that does X or Y depending on an option but these\n two codepaths are likely to evolve into doing even more different\n things, and using separate functions would be cleaner.\"\n\n * For an enhancement, describe in what situation the new feature is\n useful, defend why that use case is worth supporting, state how\n awkward (or perhaps impossible) to do the same thing is with the\n current set of features, and discuss and defend why you chose this\n specific approach to fix the awkwardness among other possibilities.\n E.g. \"This adds a new feature X that works like this. When you have\n Y and want to arrive at Z, with the current set of commands you would\n need to do W, but...\".\n\n The point is to help people, who later wonder why the change was made\n and on what basis the author thought the change was necessary and/or\n sufficient back then when the change was made, understand the context.\n\n This comes at the beginning of the e-mail message, and is concluded by\n S-o-b line(s).\n\n * Supporting material that makes it easy to understand the particular\n iteration of the patch in the context of review discussion, things like\n \"Compared to the previous round, I changed this and that, thanks to\n comments from X and Y.\" Because only the final iteration will get\n committed in the final history, it does not make sense to include such\n information in the commit message. This comes after the commit log\n message, and a single three-dash line is used to separate this part\n from the commit log message.\n\n * The change itself, aka \"patch\". This comes at the end of the message.\n\nLet's look at the pieces you have after --- (the first one is the only one\nthat counts).\n\n Makefile\n\n Add changes for System V, UnixWare, SCO OS's\n\nThis is something poeple can find out and guess by looking at the patch\nitself, and is unnecessary, not even as supporting material.\n\n __USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\n compiler and/or some SysV based OS's.\n\n __M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\n of the SCO OS's. It is used just like Apple and BSD, both of these\n shouldn't have _XOPEN_SOURCE defined.\n\nThese are valuable clues to anybody who is unfamiliar with (and/or do not\nhave an easy access to) these systems. When people later want to touch\ngit-compat-util.h around the place where !defined(__USLC__) is used, they\nwould run \"git blame\" (or perhaps \"git log -S__USLC__\") to find your\ncommit that modified this line, and by looking at the commit log message\nwhy you added these symbols on the #if line. It would help protect your\nchanges from begin broken by them if you help them understand why these\nare there, and the above two paragraphs should definitely go to the commit\nlog message. They are not mere supporting material for this review cycle\nalone.\n\n\"..., both of these shouldn't have\" however could even be more helpful if\nit was stated like \"On these platforms, defining _XOPEN_SOURCE hides\ndefinitions of X, Y and Z that we use, which is not what we want.\", for\npeople who would want to know what specific breakage the change addresses.\n\nIt would change \"Ok, somebody with SCO systems says this patch fixes\nthings for him\" to \"I see, if _XOPEN_SOURCE over there makes *that*\nfunction unavailable, then we definitely shouldn't have _XOPEN_SOURCE\ndefined at this point of the header file\". IOW, it makes \"Ok, I trust the\nguy's judgement, even though the details are fuzzy to me\" into \"Ok, I\nagree with his judgement\".\n"},{"id":"79152","messageId":"Pine.LNX.4.64.0806081318520.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"7vhcc3kbdw.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T19:31:15Z","receivedAt":"2008-06-08T19:31:15Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Junio C Hamano wrote:\n> Boyd Lynn Gerber writes:\n> > On Sun, 8 Jun 2008, Jakub Narebski wrote:\n> > This was from my own copy of the master archive. It is my proposal. I \n> > thought you had to get an OK from this list before you do a push to the \n> > main archive. Am I missing something? I am new to this list and the \n> > proper methods for submitting patches. I thought I was following the \n> > guidelines from \n> >\n> > http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n> >\n> > What am I missing?\n> \n> It might appear that many people somehow hate your patch and ganging up \n> on it, and if so I apologize for them and I assure you that they do not \n> mean ill.\n\nThis list has been very good. The problem comes from other lists and \npersonal assualts on my domain. \n \n> There seem to be some confusion either in the SubmittingPatches document \n> or the way some suggestions have been given in the recent postings by \n> people, so let's clear it up first.\n\nYes, I was a bit confused but the docs/email/IRC. I really apperciate the \nmessage below. I really want to comply with the rules of this list and \nmake sure my changes make it into the master/core source.\n\n... \n> * For an enhancement, describe in what situation the new feature is\n> useful, defend why that use case is worth supporting, state how\n> awkward (or perhaps impossible) to do the same thing is with the\n> current set of features, and discuss and defend why you chose this\n> specific approach to fix the awkwardness among other possibilities.\n> E.g. \"This adds a new feature X that works like this. When you have\n> Y and want to arrive at Z, with the current set of commands you would\n> need to do W, but...\".\n> \n> The point is to help people, who later wonder why the change was made\n> and on what basis the author thought the change was necessary and/or\n> sufficient back then when the change was made, understand the context.\n> \n> This comes at the beginning of the e-mail message, and is concluded by\n> S-o-b line(s).\n\nI agree. I am not sure on some things but I will ask more later.\n\n> * Supporting material that makes it easy to understand the particular\n> iteration of the patch in the context of review discussion, things like\n> \"Compared to the previous round, I changed this and that, thanks to\n> comments from X and Y.\" Because only the final iteration will get\n> committed in the final history, it does not make sense to include such\n> information in the commit message. This comes after the commit log\n> message, and a single three-dash line is used to separate this part\n> from the commit log message.\n> \n> * The change itself, aka \"patch\". This comes at the end of the message.\n...\n\n> __USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\n> compiler and/or some SysV based OS's.\n> \n> __M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\n> of the SCO OS's. It is used just like Apple and BSD, both of these\n> shouldn't have _XOPEN_SOURCE defined.\n> \n> These are valuable clues to anybody who is unfamiliar with (and/or do \n> not have an easy access to) these systems. When people later want to \n> touch git-compat-util.h around the place where !defined(__USLC__) is \n> used, they would run \"git blame\" (or perhaps \"git log -S__USLC__\") to \n> find your commit that modified this line, and by looking at the commit \n> log message why you added these symbols on the #if line. It would help \n> protect your changes from begin broken by them if you help them \n> understand why these are there, and the above two paragraphs should \n> definitely go to the commit log message. They are not mere supporting \n> material for this review cycle alone.\n\nI will have to find all this information. It took me 2 months in my \npersonal time to find and fix them. I will have to get back on this \nbelow.\n \n> \"..., both of these shouldn't have\" however could even be more helpful \n> if it was stated like \"On these platforms, defining _XOPEN_SOURCE hides \n> definitions of X, Y and Z that we use, which is not what we want.\", for \n> people who would want to know what specific breakage the change \n> addresses.\n>\n> It would change \"Ok, somebody with SCO systems says this patch fixes \n> things for him\" to \"I see, if _XOPEN_SOURCE over there makes *that* \n> function unavailable, then we definitely shouldn't have _XOPEN_SOURCE \n> defined at this point of the header file\". IOW, it makes \"Ok, I trust \n> the guy's judgement, even though the details are fuzzy to me\" into \"Ok, \n> I agree with his judgement\".\n\nThanks, more later when time permits.\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79158","messageId":"Pine.LNX.4.64.0806081443130.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"7vhcc3kbdw.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T20:47:54Z","receivedAt":"2008-06-08T20:47:54Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Junio C Hamano wrote:\n> * Justification for the patch. When anybody views with \"git show\" the\n> change after it gets committed, \"how\" the patch changes can be seen,\n> but what cannot be easily seen is \"why\", and the commit message is the\n> place to describe it. This takes various forms, depending on the\n> nature of the patch:\n> \n> * For a fix, describe how the status-quo is broken, what the desired\n> behaviour should be, and discuss and defend why you chose this\n> specific approach to fix among other possible avenues. E.g. \"If you\n> use this and that option together, the command does this, which is\n> not correct. It should do that instead. For that, we introduce\n> helper function X and Y use them in each codepaths. We could instead\n> use a single helper that does X or Y depending on an option but these\n> two codepaths are likely to evolve into doing even more different\n> things, and using separate functions would be cleaner.\"\n> \n> * For an enhancement, describe in what situation the new feature is\n> useful, defend why that use case is worth supporting, state how\n> awkward (or perhaps impossible) to do the same thing is with the\n> current set of features, and discuss and defend why you chose this\n> specific approach to fix the awkwardness among other possibilities.\n> E.g. \"This adds a new feature X that works like this. When you have\n> Y and want to arrive at Z, with the current set of commands you would\n> need to do W, but...\".\n...\n> \"..., both of these shouldn't have\" however could even be more helpful if\n> it was stated like \"On these platforms, defining _XOPEN_SOURCE hides\n> definitions of X, Y and Z that we use, which is not what we want.\", for\n> people who would want to know what specific breakage the change addresses.\n> \n> It would change \"Ok, somebody with SCO systems says this patch fixes\n> things for him\" to \"I see, if _XOPEN_SOURCE over there makes *that*\n> function unavailable, then we definitely shouldn't have _XOPEN_SOURCE\n> defined at this point of the header file\". IOW, it makes \"Ok, I trust the\n> guy's judgement, even though the details are fuzzy to me\" into \"Ok, I\n> agree with his judgement\".\n\nSo the patch should be\n\nFrom: Boyd Lynn Gerber \nDate: Sun, 8 Jun 2008 11:41:46 -0600\n[PATCH] Port to 12 other Platforms.\n\nThis patch adds support to compile and run git on 12 additional platforms.\nThe platforms are based on UNIX Systems Labs (USL)/Novell/SYS V code base.\nThe most common are Novell UnixWare 2.X.X, SCO UnixWare 7.X.X,\nOpenServer 5.0.X, OpenServer 6.0.X, and SCO pre OSR 5 platforms.\n\nThis is from\n\n# 1 \"/usr/include/netinet/tcp_f.h\"\n\nThe problem is that git source has blocked some typedefs\nby excluding certain content.\n\nLooking at the the various platform header, I see around line 450\n\n#if defined(_KERNEL) || !defined(_POSIX_SOURCE) \\\n && !defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)\n\nThe git source is covering the u_short typedef line and other typedefs\nare also covered in the platforms. They all lead back to the above\nwhich comes from\n\ngit-compat-util.h\n\nabout line 66. I had to make the following changes\n\n#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n\nThe _XOPEN_SOURCE hides many typedefs.\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\nof the SCO OS's. It is used just like Apple and BSD, both of these\nshouldn't have _XOPEN_SOURCE defined.\n\nThis is with suggestions and modifications from\n\nDaniel Barkalow \nJunio C Hamano \nThomas Harning \nJeremy Maitin-Shepard \n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\nof the SCO OS's. It is used just like Apple and BSD, both of these\nshouldn't have _XOPEN_SOURCE defined.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..026de2f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -564,6 +564,45 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kthread\n+\tendif\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..c04e8ba 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n-- \n1.5.2.4\n"},{"id":"79162","messageId":"7v8wxfiq01.fsf@gitster.siamese.dyndns.org","threadId":"13865","inReplyTo":"Pine.LNX.4.64.0806081443130.18454@xenau.zenez.com","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-06-08T21:19:26Z","receivedAt":"2008-06-08T21:19:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> So the patch should be\n> ...\n\nThanks.\n\nI'll apply, but I'd reword the part on _XOPEN_SOURCE like this:\n\n Looking at the the various platform headers, I see around line 450:\n\n #if defined(_KERNEL) || !defined(_POSIX_SOURCE) \\\n && !defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)\n\n which hides u_short and other typedefs that other header files on these\n platforms depend on. With _XOPEN_SOURCE defined, sources that include\n system header files that depend on the typedefs such as u_short cannot be\n compiled on these platforms.\n\nHonestly, I'd have to say that such platform header files are buggy ;-)\n\nIf they want to use u_short and other custom types for their internal use,\nthat is understandable and perfectly fine, and if they want to hide these\nnames when _POSIX or _XOPEN is defined because you are not supposed to\ncontaminate the namespace, that is also sensible, but at the same time you\n(not you, Boyd, but whoever developed the system header files) should have\ntaken an alternate measure (perhaps by using __u_short or something) not\nto break the features they declare in the other header files of their own.\n\nAnd not defining _XOPEN nor _POSIX would be a reasonable workaround to\nthe problem on such systems.\n"},{"id":"79168","messageId":"Pine.LNX.4.64.0806081535080.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"7v8wxfiq01.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] version 0001 Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T21:36:36Z","receivedAt":"2008-06-08T21:36:36Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"\nThis patch adds support to compile and run git on 12 additional platforms.\nThe platforms are based on UNIX Systems Labs (USL)/Novell/SYS V code base.\nThe most common are Novell UnixWare 2.X.X, SCO UnixWare 7.X.X,\nOpenServer 5.0.X, OpenServer 6.0.X, and SCO pre OSR 5 platforms.\n\nThis is from\n\nThe problem is that git source has blocked some typedefs\nby excluding certain content.\n\nLooking at the the various platform header, I see around line 450\n\n && !defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)\n\nwhich hides u_short and other typedefs that other header files on these\nplatforms dependon. With _XOPEN_SOURCE defined, sources that include\nsystem header files that depend on the typedefs such as u_short cannot\nbe compiled on these platforms.\n\nThey all lead back to about line 66 in git-compat-util.h\n\nI had to make the following changes\n\nned(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 fo\nr S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n\nThe _XOPEN_SOURCE hides many typedefs.\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\nof the SCO OS's. It is used just like Apple and BSD, both of these\nshouldn't have _XOPEN_SOURCE defined.\n\nThis is with suggestions and modifications from\n\nDaniel Barkalow \nJunio C Hamano \nThomas Harning \nJeremy Maitin-Shepard \n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior releases\nof the SCO OS's. It is used just like Apple and BSD, both of these\nshouldn't have _XOPEN_SOURCE defined.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..026de2f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -564,6 +564,45 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kthread\n+\tendif\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..c04e8ba 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n-- \n1.5.2.4\n"},{"id":"79169","messageId":"Pine.LNX.4.64.0806081536450.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"7v8wxfiq01.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] progress.c: avoid use of dynamic-sized array","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T21:37:40Z","receivedAt":"2008-06-08T21:37:40Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"\nDynamically sized arrays are gcc and C99 construct. Using them hurts\nportability to older compilers, although using them is nice in this case\nit is not desirable. This patch removes the only use of the construct\nin stop_progress_msg(); the function is about writing out a single line\nof a message, and the existing callers of this function feed messages\nof only bounded size anyway, so use of dynamic array is simply overkill.\n\nThis is with suggestions from\n\nDaniel Barkalow \nJunio C Hamano \nThomas Harning \nJeremy Maitin-Shepard \n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\n---\nprogress.c\n\nChanges for older OS's that do not support the current methods for\nallocation of memory.\n\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n-- \n1.5.2.4\n"},{"id":"79170","messageId":"Pine.LNX.4.64.0806081545140.18454@xenau.zenez.com","threadId":"13865","inReplyTo":"7v8wxfiq01.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Port to 12 other Platforms.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T21:49:31Z","receivedAt":"2008-06-08T21:49:31Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Sun, 8 Jun 2008, Junio C Hamano wrote:\n> Honestly, I'd have to say that such platform header files are buggy ;-)\n\nI agree, but getting various things changed is near impossible. \nEspecially since they are either in a retired or unmaintained state. \nAlthough a few are still release updated products, they refuse to change \nthem citeing backword compatibility.\n \n> If they want to use u_short and other custom types for their internal use,\n> that is understandable and perfectly fine, and if they want to hide these\n> names when _POSIX or _XOPEN is defined because you are not supposed to\n> contaminate the namespace, that is also sensible, but at the same time you\n> (not you, Boyd, but whoever developed the system header files) should have\n> taken an alternate measure (perhaps by using __u_short or something) not\n> to break the features they declare in the other header files of their own.\n\nI agree +1\n\n> And not defining _XOPEN nor _POSIX would be a reasonable workaround to\n> the problem on such systems.\n\nAgreed.\n\nThanks,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"}]}