{"thread":{"id":"13854","subject":"[PATCH] Remove unused code in parse_commit_buffer()","startedAt":"2008-06-07T20:38:37Z","lastAt":"2008-06-08T15:46:32Z","messageCount":2,"participants":["Miklos Vajna","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"79067","messageId":"1212871117-1509-1-git-send-email-vmiklos@frugalware.org","threadId":"13854","inReplyTo":null,"subject":"[PATCH] Remove unused code in parse_commit_buffer()","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-06-07T20:38:37Z","receivedAt":"2008-06-07T20:38:37Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"The n_refs variable is no longer really used in this function, so there\nis no reason to keep it.\n\nIt was introduced in 27dedf0c and the code that really used it was\nremoved in 7914053.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n commit.c |    8 +-------\n 1 files changed, 1 insertions(+), 7 deletions(-)\n\ndiff --git a/commit.c b/commit.c\nindex 94d5b3d..e2d8624 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -243,7 +243,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)\n \tunsigned char parent[20];\n \tstruct commit_list **pptr;\n \tstruct commit_graft *graft;\n-\tunsigned n_refs = 0;\n \n \tif (item->object.parsed)\n \t\treturn 0;\n@@ -255,8 +254,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)\n \t\treturn error(\"bad tree pointer in commit %s\",\n \t\t\t     sha1_to_hex(item->object.sha1));\n \titem->tree = lookup_tree(parent);\n-\tif (item->tree)\n-\t\tn_refs++;\n \tbufptr += 46; /* \"tree \" + \"hex sha1\" + \"\\n\" */\n \tpptr = &item->parents;\n \n@@ -272,10 +269,8 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)\n \t\tif (graft)\n \t\t\tcontinue;\n \t\tnew_parent = lookup_commit(parent);\n-\t\tif (new_parent) {\n+\t\tif (new_parent)\n \t\t\tpptr = &commit_list_insert(new_parent, pptr)->next;\n-\t\t\tn_refs++;\n-\t\t}\n \t}\n \tif (graft) {\n \t\tint i;\n@@ -285,7 +280,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)\n \t\t\tif (!new_parent)\n \t\t\t\tcontinue;\n \t\t\tpptr = &commit_list_insert(new_parent, pptr)->next;\n-\t\t\tn_refs++;\n \t\t}\n \t}\n \titem->date = parse_commit_date(bufptr, tail);\n-- \n1.5.6.rc0.dirty\n"},{"id":"79125","messageId":"alpine.DEB.1.00.0806081646200.1783@racer","threadId":"13854","inReplyTo":"1212871117-1509-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] Remove unused code in parse_commit_buffer()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-06-08T15:46:32Z","receivedAt":"2008-06-08T15:46:32Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 7 Jun 2008, Miklos Vajna wrote:\n\n> The n_refs variable is no longer really used in this function, so there\n> is no reason to keep it.\n> \n> It was introduced in 27dedf0c and the code that really used it was\n> removed in 7914053.\n\nNice catch!\n\nCiao,\nDscho\n"}]}