{"thread":{"id":"13835","subject":"[PATCH] This patch is to allow 12 different OS's to compile and run git.","startedAt":"2008-06-06T19:34:03Z","lastAt":"2008-06-08T17:07:11Z","messageCount":24,"participants":["Boyd Lynn Gerber","Jeremy Maitin-Shepard","Thomas Harning","Stephan Beyer","Linus Torvalds","Brandon Casey","Daniel Barkalow","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"78941","messageId":"Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com","threadId":"13835","inReplyTo":null,"subject":"[PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-06T19:34:03Z","receivedAt":"2008-06-06T19:34:03Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"This patch has patches to\n\nMakefile\ngit-compat-util.h\nprogress.c\n\nThis patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\nand OpenServer 6.0.X to build and run git.\n\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n\t(d) I understand and agree that this project and the contribution\n\t are public and that a record of the contribution (including all\n\t personal information I submit with it, including my sign-off) is\n\t maintained indefinitely and may be redistributed consistent with\n\t this project or the open source license(s) involved.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..6df008a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -165,6 +165,20 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n+ifeq ($(uname_S),SCO_SV)\n+ ifeq ($(uname_R),3.2)\n+# CFLAGS = -g -O2\n+ CFLAGS = -g\n+ endif\n+ ifeq ($(uname_R),5)\n+ CFLAGS = -g -O2 -Wall\n+# CFLAGS = -g -O2\n+ endif\n+endif\n+ifeq ($(uname_S),UnixWare)\n+ CFLAGS = -g -O2 -Wall\n+# CFLAGS = -g -O2\n+endif\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -207,7 +221,8 @@ GITWEB_SITE_FOOTER =\n \n export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n \n-CC = gcc\n+#CC = gcc\n+CC = \"cc\"\n AR = ar\n RM = rm -f\n TAR = tar\n@@ -564,6 +579,42 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tNEEDS_SOCKET = YesPlease\n+#\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+#\tBASIC_CFLAGS += -E -H\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tNEEDS_SOCKET = YesPlease\n+#\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+#\tNO_HSTRERROR = YesPlease\n+#\tBASIC_CFLAGS += -E -H\n+ ifeq ($(uname_R),5)\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+ endif\n+#\tBASIC_CFLAGS += -I/usr/local/include\n+#\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..b57041c 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__ ) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n@@ -89,6 +89,10 @@\n #include \n #define _ALL_SOURCE 1\n #endif\n+#if defined(__USLC__)\n+#undef _XOPEN_SOURCE\n+#include \n+#endif\n \n #ifndef NO_ICONV\n #include \n@@ -206,12 +210,15 @@ void *gitmemmem(const void *haystack, size_t haystacklen,\n #endif\n \n #ifdef FREAD_READS_DIRECTORIES\n+#if !defined (__USLC__)\n #ifdef fopen\n #undef fopen\n #endif\n #define fopen(a,b) git_fopen(a,b)\n extern FILE *git_fopen(const char*, const char*);\n #endif\n+#endif\n+#endif\n \n #ifdef SNPRINTF_RETURNS_BOGUS\n #define snprintf git_snprintf\ndiff --git a/progress.c b/progress.c\nindex d19f80c..11a0841 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\t/* char buf[strlen(msg) + 5]; */\n+\t\tchar *buf = malloc (strlen(msg) + 5 );\n \t\tstruct throughput *tp = progress->throughput;\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n-- \n1.5.2.4\n"},{"id":"78942","messageId":"87bq2ez72u.fsf@jeremyms.com","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Jeremy Maitin-Shepard","fromEmail":"jbms@cmu.edu","sentAt":"2008-06-06T19:39:21Z","receivedAt":"2008-06-06T19:39:21Z","isPatch":true,"sender":{"key":"jbms@cmu.edu","avatar":null},"body":"Boyd Lynn Gerber writes:\n\n[snip]\n\n> diff --git a/progress.c b/progress.c\n> index d19f80c..11a0841 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const\n> char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\t/* char buf[strlen(msg) + 5]; */\n> +\t\tchar *buf = malloc (strlen(msg) + 5 );\n\nThis change will result in the allocated memory being leaked, which is\nprobably not correct. Perhaps change it to alloca instead.\n\n-- \nJeremy Maitin-Shepard\n"},{"id":"78943","messageId":"D11671CD-8F0B-4572-A988-EC6BC6B38A46@gmail.com","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Thomas Harning","fromEmail":"harningt@gmail.com","sentAt":"2008-06-06T19:46:23Z","receivedAt":"2008-06-06T19:46:23Z","isPatch":true,"sender":{"key":"harningt@gmail.com","avatar":"https://gravatar.com/avatar/a79ddd43da8c8f1f899cd75b7b95cc5f3b2ba5643400468988b1a12c86b75d08?d=mp&s=160"},"body":"\nOn Jun 6, 2008, at 3:34 PM, Boyd Lynn Gerber wrote:\n>\n> #ifdef SNPRINTF_RETURNS_BOGUS\n> #define snprintf git_snprintf\n> diff --git a/progress.c b/progress.c\n> index d19f80c..11a0841 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress \n> **p_progress, const char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\t/* char buf[strlen(msg) + 5]; */\n> +\t\tchar *buf = malloc (strlen(msg) + 5 );\n> \t\tstruct throughput *tp = progress->throughput;\nHrm... malloc w/o free... perhaps you should use a something like \nalloca /IFF/ C99/gnu isn't available for the dynamic buffer \nallocation...\n"},{"id":"78944","messageId":"Pine.LNX.4.64.0806061359080.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"87bq2ez72u.fsf@jeremyms.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-06T20:02:33Z","receivedAt":"2008-06-06T20:02:33Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Jeremy Maitin-Shepard wrote:\n> This change will result in the allocated memory being leaked, which is\n> probably not correct. Perhaps change it to alloca instead.\n\nOK below is a new version with the suggestions.\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---------------------------------New-Submittal-------------------------\nFrom 554045d534dfa89f01fc6b0a819c73ad660f02fb Fri Jun 6 14:01:55 MDT 2008\nFrom: Boyd Lynn Gerber \nDate: Fri, 6 Jun 2008 13:58:04 -0600\nSubject: [PATCH] This patch is to allow 12 different OS's to compile and run git.\n\nThis patch has patches to\n\nMakefile\ngit-compat-util.h\nprogress.c\n\nThis patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\nand OpenServer 6.0.X to build and run git.\n\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..6df008a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -165,6 +165,20 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n+ifeq ($(uname_S),SCO_SV)\n+ ifeq ($(uname_R),3.2)\n+# CFLAGS = -g -O2\n+ CFLAGS = -g\n+ endif\n+ ifeq ($(uname_R),5)\n+ CFLAGS = -g -O2 -Wall\n+# CFLAGS = -g -O2\n+ endif\n+endif\n+ifeq ($(uname_S),UnixWare)\n+ CFLAGS = -g -O2 -Wall\n+# CFLAGS = -g -O2\n+endif\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -207,7 +221,8 @@ GITWEB_SITE_FOOTER =\n \n export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n \n-CC = gcc\n+#CC = gcc\n+CC = \"cc\"\n AR = ar\n RM = rm -f\n TAR = tar\n@@ -564,6 +579,42 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tNEEDS_SOCKET = YesPlease\n+#\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+#\tBASIC_CFLAGS += -E -H\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tNEEDS_SOCKET = YesPlease\n+#\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+#\tNO_HSTRERROR = YesPlease\n+#\tBASIC_CFLAGS += -E -H\n+ ifeq ($(uname_R),5)\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+ endif\n+#\tBASIC_CFLAGS += -I/usr/local/include\n+#\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..f27aea3 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,8 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n+fined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\ndiff --git a/progress.c b/progress.c\nindex d19f80c..295c4e3 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\t/* char buf[strlen(msg) + 5]; */\n+\t\tchar *buf = alloca (strlen(msg) + 5 );\n \t\tstruct throughput *tp = progress->throughput;\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n-- \n1.5.2.4\n"},{"id":"78945","messageId":"20080606201551.GB31040@leksak.fem-net","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061359080.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-06-06T20:15:51Z","receivedAt":"2008-06-06T20:15:51Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"Hi,\n\n> Developer's Certificate of Origin 1.1\n\nIt's not necessary, or even unwanted, to copy&paste this into the\ncommit message.\n\nThe Signed-off-by: line\n> Signed-off-by: Boyd Lynn Gerber \nis enough.\nSo just use the Signed-off-by line and not the whole DCO.\n\nAs Documentation/SubmittingPatches says:\n----\nThe sign-off is a simple line at the end of the explanation for\nthe patch[...].\n[...]\nif you can certify the below:\n\n Developer's Certificate of Origin 1.1\n\t[...]\n\nthen you just add a line saying\n\n Signed-off-by: Random J Developer \n----\n\nRegards,\n Stephan\n\n-- \nStephan Beyer , PGP 0x6EDDD207FCC5040F\n"},{"id":"78946","messageId":"alpine.LFD.1.10.0806061325090.3473@woody.linux-foundation.org","threadId":"13835","inReplyTo":"20080606201551.GB31040@leksak.fem-net","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2008-06-06T20:28:21Z","receivedAt":"2008-06-06T20:28:21Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 6 Jun 2008, Stephan Beyer wrote:\n>\n> It's not necessary, or even unwanted, to copy&paste this into the\n> commit message.\n\nConsidering the particular OS's it adds support for and Boyd's \ngeographical location, I suspect Boyd is pretty used to by now having to \nmake _very_ clear to people that he understands the GPL and has the right \nto post the changes.\n\nSometimes a little bit of extra clarity is a good thing.\n\n\t\t\tLinus\n"},{"id":"78947","messageId":"Pine.LNX.4.64.0806061438200.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"alpine.LFD.1.10.0806061325090.3473@woody.linux-foundation.org","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-06T20:44:19Z","receivedAt":"2008-06-06T20:44:19Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Linus Torvalds wrote:\n> On Fri, 6 Jun 2008, Stephan Beyer wrote:\n> >\n> > It's not necessary, or even unwanted, to copy&paste this into the \n> > commit message.\n> \n> Considering the particular OS's it adds support for and Boyd's \n> geographical location, I suspect Boyd is pretty used to by now having to \n> make _very_ clear to people that he understands the GPL and has the \n> right to post the changes.\n> \n> Sometimes a little bit of extra clarity is a good thing.\n\nYou hit the nail on the head. I get tired of doing exactly that. Just \nsouth of me 20-40 miles is the location of SCO Lindon, Utah. I have to \nmake it really clear in most things I do that I understand and totally \nsupport the GPL. I have done work for said group and always add in my \ncontracts that what is being done has to support the GPL and strict \ncompliance is necessary. All changes will be sent upstream for inclusion \nat the project head. Whether they are added or not is really not the \nissue. I want any and all changes to follow what ever licence they are \nunder and everything has to be in compliance with the licences.\n\nThanks,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"78964","messageId":"zT6Kk5prw6MLDU9U02XgwHxqkW1_ihaulXp9SEp2upryFMd7jIWyVw@cipher.nrlssc.navy.mil","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061359080.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-06-06T22:16:50Z","receivedAt":"2008-06-06T22:16:50Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Boyd Lynn Gerber wrote:\n> On Fri, 6 Jun 2008, Jeremy Maitin-Shepard wrote:\n>> This change will result in the allocated memory being leaked, which is\n>> probably not correct. Perhaps change it to alloca instead.\n> \n> OK below is a new version with the suggestions.\n\n\nComments below basically amount to:\n\n 1) Use tab when indenting.\n 2) Remove commented-out dead code\n 3) Don't put space between function name and open parenthesis.\n\n\n> diff --git a/Makefile b/Makefile\n> index cce5a6e..6df008a 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -165,6 +165,20 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> # CFLAGS and LDFLAGS are for the users to override from the command line.\n> \n> CFLAGS = -g -O2 -Wall\n> +ifeq ($(uname_S),SCO_SV)\n> + ifeq ($(uname_R),3.2)\n\nIndent with a tab not 2 spaces.\n\n> +# CFLAGS = -g -O2\n\nThese commented out assignments should not be included in the final patch.\n\n> + CFLAGS = -g\n\nUse tab.\n\n> + endif\n> + ifeq ($(uname_R),5)\n> + CFLAGS = -g -O2 -Wall\n> +# CFLAGS = -g -O2\n\nditto on comment and tab.\n\n> + endif\n> +endif\n> +ifeq ($(uname_S),UnixWare)\n> + CFLAGS = -g -O2 -Wall\n> +# CFLAGS = -g -O2\n\nditto\n\n> +endif\n> LDFLAGS =\n> ALL_CFLAGS = $(CFLAGS)\n> ALL_LDFLAGS = $(LDFLAGS)\n> @@ -207,7 +221,8 @@ GITWEB_SITE_FOOTER =\n> \n> export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n> \n> -CC = gcc\n> +#CC = gcc\n> +CC = \"cc\"\n\nThis one is up to Junio. Perhaps he has some reason for specifically configuring\ngcc. In which case this CC selection maybe should go in the UnixWare section.\n\n> AR = ar\n> RM = rm -f\n> TAR = tar\n> @@ -564,6 +579,42 @@ endif\n> ifeq ($(uname_S),GNU/kFreeBSD)\n> \tNO_STRLCPY = YesPlease\n> endif\n> +ifeq ($(uname_S),UnixWare)\n> +\tNEEDS_SOCKET = YesPlease\n> +#\tNEEDS_NSL = YesPlease\n\nCommented out. Why is it in the patch?\n\n> +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n> +\tSHELL_PATH = /usr/local/bin/bash\n> +\tNO_IPV6 = YesPlease\n> +\tNO_HSTRERROR = YesPlease\n> +#\tBASIC_CFLAGS += -E -H\n\nummhmm.\n\n> +\tBASIC_CFLAGS += -Kalloca -Kthread\n> +\tBASIC_CFLAGS += -I/usr/local/include\n> +\tBASIC_LDFLAGS += -L/usr/local/lib\n> +\tINSTALL = ginstall\n> +\tTAR = gtar\n> +\tNO_STRCASESTR = YesPlease\n> +\tNO_MEMMEM = YesPlease\n> +endif\n> +ifeq ($(uname_S),SCO_SV)\n> +\tNEEDS_SOCKET = YesPlease\n> +#\tNEEDS_NSL = YesPlease\n\n\n> +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n> +\tSHELL_PATH = /usr/bin/bash\n> +\tNO_IPV6 = YesPlease\n> +#\tNO_HSTRERROR = YesPlease\n> +#\tBASIC_CFLAGS += -E -H\n\n\n> + ifeq ($(uname_R),5)\n\ntabs\n\n> +\tBASIC_CFLAGS += -Kalloca -Kthread\n> + endif\n\ntab.\n\n> +#\tBASIC_CFLAGS += -I/usr/local/include\n> +#\tBASIC_LDFLAGS += -L/usr/local/lib\n\n\n> +\tNO_STRCASESTR = YesPlease\n> +\tNO_MEMMEM = YesPlease\n> +\tINSTALL = ginstall\n> +\tTAR = gtar\n> +endif\n> ifeq ($(uname_S),Darwin)\n> \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> \tNEEDS_LIBICONV = YesPlease\n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index 01c4045..f27aea3 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -39,7 +39,8 @@\n> /* Approximation of the length of the decimal representation of this type. */\n> #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> \n> -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> +#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n> +fined(_M_UNIX)\n> #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n> #endif\n> diff --git a/progress.c b/progress.c\n> index d19f80c..295c4e3 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\t/* char buf[strlen(msg) + 5]; */\n\n This should just be deleted.\n\n> +\t\tchar *buf = alloca (strlen(msg) + 5 );\n ^\n we don't put spaces between function name and open parens.\n\n\n-brandon\n"},{"id":"78971","messageId":"alpine.LNX.1.00.0806061835430.19665@iabervon.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-06-06T22:58:38Z","receivedAt":"2008-06-06T22:58:38Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n\n> This patch has patches to\n> \n> Makefile\n> git-compat-util.h\n> progress.c\n> \n> This patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\n> and OpenServer 6.0.X to build and run git.\n> \n> Developer's Certificate of Origin 1.1\n> \n> By making a contribution to this project, I certify that:\n> \n> (a) The contribution was created in whole or in part by me and I\n> have the right to submit it under the open source license\n> indicated in the file; or\n> \n> (b) The contribution is based upon previous work that, to the best\n> of my knowledge, is covered under an appropriate open source\n> license and I have the right under that license to submit that\n> work with modifications, whether created in whole or in part\n> by me, under the same open source license (unless I am\n> permitted to submit under a different license), as indicated\n> in the file; or\n> \n> (c) The contribution was provided directly to me by some other\n> person who certified (a), (b) or (c) and I have not modified\n> it.\n> \n> \t(d) I understand and agree that this project and the contribution\n> \t are public and that a record of the contribution (including all\n> \t personal information I submit with it, including my sign-off) is\n> \t maintained indefinitely and may be redistributed consistent with\n> \t this project or the open source license(s) involved.\n> \n> Signed-off-by: Boyd Lynn Gerber \n> \n> --\n> Boyd Gerber \n> ZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n> \n> \n> diff --git a/Makefile b/Makefile\n> index cce5a6e..6df008a 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -165,6 +165,20 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> # CFLAGS and LDFLAGS are for the users to override from the command line.\n> \n> CFLAGS = -g -O2 -Wall\n> +ifeq ($(uname_S),SCO_SV)\n> + ifeq ($(uname_R),3.2)\n> +# CFLAGS = -g -O2\n> + CFLAGS = -g\n> + endif\n> + ifeq ($(uname_R),5)\n> + CFLAGS = -g -O2 -Wall\n> +# CFLAGS = -g -O2\n> + endif\n> +endif\n> +ifeq ($(uname_S),UnixWare)\n> + CFLAGS = -g -O2 -Wall\n> +# CFLAGS = -g -O2\n> +endif\n\nMight be better to have something for CFLAGS to filter out. Also, as a \ngeneral rule, remove old lines instead of commentting them out. If we want \nto undo a change, we can get it out of the version control. :) (More of \nthese below)\n\nAlso, only the SCO_SV 3.2 one actually does anything here, right?\n\n> LDFLAGS =\n> ALL_CFLAGS = $(CFLAGS)\n> ALL_LDFLAGS = $(LDFLAGS)\n> @@ -207,7 +221,8 @@ GITWEB_SITE_FOOTER =\n> \n> export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n> \n> -CC = gcc\n> +#CC = gcc\n> +CC = \"cc\"\n\nProbably ought to make this conditional on a flag that says that \"cc\" \nworks and \"gcc\" isn't better; there are a lot of systems, IIRC, where \"cc\" \nis a lousy vendor compiler (unless you bought the expensive vendor \ncompiler) and \"gcc\" is the modern working compiler that everybody has \ninstalled.\n\n> AR = ar\n> RM = rm -f\n> TAR = tar\n> @@ -564,6 +579,42 @@ endif\n> ifeq ($(uname_S),GNU/kFreeBSD)\n> \tNO_STRLCPY = YesPlease\n> endif\n> +ifeq ($(uname_S),UnixWare)\n> +\tNEEDS_SOCKET = YesPlease\n> +#\tNEEDS_NSL = YesPlease\n> +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n> +\tSHELL_PATH = /usr/local/bin/bash\n> +\tNO_IPV6 = YesPlease\n> +\tNO_HSTRERROR = YesPlease\n> +#\tBASIC_CFLAGS += -E -H\n> +\tBASIC_CFLAGS += -Kalloca -Kthread\n> +\tBASIC_CFLAGS += -I/usr/local/include\n> +\tBASIC_LDFLAGS += -L/usr/local/lib\n> +\tINSTALL = ginstall\n> +\tTAR = gtar\n> +\tNO_STRCASESTR = YesPlease\n> +\tNO_MEMMEM = YesPlease\n> +endif\n> +ifeq ($(uname_S),SCO_SV)\n> +\tNEEDS_SOCKET = YesPlease\n> +#\tNEEDS_NSL = YesPlease\n> +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n> +\tSHELL_PATH = /usr/bin/bash\n> +\tNO_IPV6 = YesPlease\n> +#\tNO_HSTRERROR = YesPlease\n> +#\tBASIC_CFLAGS += -E -H\n> + ifeq ($(uname_R),5)\n> +\tBASIC_CFLAGS += -Kalloca -Kthread\n> + endif\n> +#\tBASIC_CFLAGS += -I/usr/local/include\n> +#\tBASIC_LDFLAGS += -L/usr/local/lib\n> +\tNO_STRCASESTR = YesPlease\n> +\tNO_MEMMEM = YesPlease\n> +\tINSTALL = ginstall\n> +\tTAR = gtar\n> +endif\n> ifeq ($(uname_S),Darwin)\n> \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> \tNEEDS_LIBICONV = YesPlease\n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index 01c4045..b57041c 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -39,7 +39,7 @@\n> /* Approximation of the length of the decimal representation of this type. */\n> #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> \n> -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> +#if !defined(__APPLE__) && !defined(__FreeBSD__ ) && !defined(__USLC__) && !defined(_M_UNIX)\n> #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n> #endif\n> @@ -89,6 +89,10 @@\n> #include \n> #define _ALL_SOURCE 1\n> #endif\n> +#if defined(__USLC__)\n> +#undef _XOPEN_SOURCE\n> +#include \n> +#endif\n\nDidn't you avoid defining _XOPEN_SOURCE in this case?\n\n> \n> #ifndef NO_ICONV\n> #include \n> @@ -206,12 +210,15 @@ void *gitmemmem(const void *haystack, size_t haystacklen,\n> #endif\n> \n> #ifdef FREAD_READS_DIRECTORIES\n> +#if !defined (__USLC__)\n\nCan't you not define FREAD_READS_DIRECTORIES?\n\n> #ifdef fopen\n> #undef fopen\n> #endif\n> #define fopen(a,b) git_fopen(a,b)\n> extern FILE *git_fopen(const char*, const char*);\n> #endif\n> +#endif\n> +#endif\n\nThis seems wrong; it looks like you've added more #endifs than #ifs.\n\n> \n> #ifdef SNPRINTF_RETURNS_BOGUS\n> #define snprintf git_snprintf\n> diff --git a/progress.c b/progress.c\n> index d19f80c..11a0841 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\t/* char buf[strlen(msg) + 5]; */\n> +\t\tchar *buf = malloc (strlen(msg) + 5 );\n\nDo we really have exactly one use of this pattern? I thought we either did \nit more or excluded it by policy. Aside from not leaking the memory and \nnot leaving the old version in a comment, it's probably the right change.\n\nIncidentally, you might want to look into \"sparse\", and getting them have \nan optional warning for code like this that might not be supported by some \ncompilers the project wants to support but doesn't actually use for \ndevelopment regularly.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"78972","messageId":"7vmylyrwkg.fsf@gitster.siamese.dyndns.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061359080.18454@xenau.zenez.com","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-06-06T23:08:15Z","receivedAt":"2008-06-06T23:08:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> diff --git a/progress.c b/progress.c\n> index d19f80c..295c4e3 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\t/* char buf[strlen(msg) + 5]; */\n> +\t\tchar *buf = alloca (strlen(msg) + 5 );\n> \t\tstruct throughput *tp = progress->throughput;\n> \t\tif (tp) {\n> \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n\nI do not know the situation over there these days, but I have a distant\nbut bitter memory of having to deal with AIX X-<. It insisted that\ninclusion of to be the very first thing in the source before\nanything else. I would want to keep alloca() out of the codebase without\nvery good reason. Not that I care much about portability to AIX, but not\nhaving to worry about alloca() unless necessary is a good thing.\n\nI do not think progress_msg() is a good reason to even worrying about a\ndynamically sized array. The function is designed to spit out a single\nline of message (so the incoming msg is expected to be shorter than 80\nchars or so). If you \"git grep stop_progress_msg\", you will see that\nthere are only two callers of this function, one in progress.c itself that\nsays \"done\", and the other one in index-pack.c that gives a string\nformatted into 48-byte buffer.\n\nSo we can be lazy and say:\n\n\tchar buf[128];\n ...\n snprintf(buf, sizeof(buf), \", %s.\\n\", msg)\n\nand be done with it.\n\nIf you really wanted to be safe and anal, you could do something like\nthis, which would be just as efficient and much more straightforward:\n\n progress.c | 11 ++++++++---\n 1 files changed, 8 insertions(+), 3 deletions(-)\n\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n"},{"id":"78978","messageId":"Pine.LNX.4.64.0806061702240.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"alpine.LNX.1.00.0806061835430.19665@iabervon.org","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-06T23:17:59Z","receivedAt":"2008-06-06T23:17:59Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Daniel Barkalow wrote:\n> On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n> > This patch has patches to\n> > \n> > Makefile\n> > git-compat-util.h\n> > progress.c\n...\n> > diff --git a/Makefile b/Makefile\n> > index cce5a6e..6df008a 100644\n> > --- a/Makefile\n> > +++ b/Makefile\n> > @@ -165,6 +165,20 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> > # CFLAGS and LDFLAGS are for the users to override from the command line.\n> > \n> > CFLAGS = -g -O2 -Wall\n> > +ifeq ($(uname_S),SCO_SV)\n> > + ifeq ($(uname_R),3.2)\n> > +# CFLAGS = -g -O2\n> > + CFLAGS = -g\n> > + endif\n> > + ifeq ($(uname_R),5)\n> > + CFLAGS = -g -O2 -Wall\n> > +# CFLAGS = -g -O2\n> > + endif\n> > +endif\n> > +ifeq ($(uname_S),UnixWare)\n> > + CFLAGS = -g -O2 -Wall\n> > +# CFLAGS = -g -O2\n> > +endif\n> \n> Might be better to have something for CFLAGS to filter out. Also, as a \n> general rule, remove old lines instead of commentting them out. If we want \n> to undo a change, we can get it out of the version control. :) (More of \n> these below)\n> \n> Also, only the SCO_SV 3.2 one actually does anything here, right?\n\nSCO has SCO_SV defined for all OpenServer/SCO Unix/XENIX Versions from \nabout 1983/4. My memory is a bit fogey on the exact first Release of \nXENIX. The problem is that with OpenServer 6 you have to use the UnixWare \nstuff. OpenServer 6 is a highly modified Unixware 7.1.4, but changed for \n98 % of the OpenServer 5 stuff. I am running XENIX binaries from the mid \nto late 80's on it. So you have to do some really strange things because \nof it. I had git working on SCO UNIX 3.2v4.2/Open Server/ODT 3.0. I have \nto use gcc and FSU-threads for threads. FSU-threads is a user threads. \n\n> Probably ought to make this conditional on a flag that says that \"cc\" \n> works and \"gcc\" isn't better; there are a lot of systems, IIRC, where \"cc\" \n> is a lousy vendor compiler (unless you bought the expensive vendor \n> compiler) and \"gcc\" is the modern working compiler that everybody has \n> installed.\n> \n> > AR = ar\n> > RM = rm -f\n> > TAR = tar\n> > @@ -564,6 +579,42 @@ endif\n> > ifeq ($(uname_S),GNU/kFreeBSD)\n> > \tNO_STRLCPY = YesPlease\n> > endif\n> > +ifeq ($(uname_S),UnixWare)\n> > +\tNEEDS_SOCKET = YesPlease\n> > +#\tNEEDS_NSL = YesPlease\n> > +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> > +\tNEEDS_LIBICONV = YesPlease\n> > +\tSHELL_PATH = /usr/local/bin/bash\n> > +\tNO_IPV6 = YesPlease\n> > +\tNO_HSTRERROR = YesPlease\n> > +#\tBASIC_CFLAGS += -E -H\n> > +\tBASIC_CFLAGS += -Kalloca -Kthread\n> > +\tBASIC_CFLAGS += -I/usr/local/include\n> > +\tBASIC_LDFLAGS += -L/usr/local/lib\n> > +\tINSTALL = ginstall\n> > +\tTAR = gtar\n> > +\tNO_STRCASESTR = YesPlease\n> > +\tNO_MEMMEM = YesPlease\n> > +endif\n> > +ifeq ($(uname_S),SCO_SV)\n> > +\tNEEDS_SOCKET = YesPlease\n> > +#\tNEEDS_NSL = YesPlease\n> > +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> > +\tNEEDS_LIBICONV = YesPlease\n> > +\tSHELL_PATH = /usr/bin/bash\n> > +\tNO_IPV6 = YesPlease\n> > +#\tNO_HSTRERROR = YesPlease\n> > +#\tBASIC_CFLAGS += -E -H\n> > + ifeq ($(uname_R),5)\n> > +\tBASIC_CFLAGS += -Kalloca -Kthread\n> > + endif\n> > +#\tBASIC_CFLAGS += -I/usr/local/include\n> > +#\tBASIC_LDFLAGS += -L/usr/local/lib\n> > +\tNO_STRCASESTR = YesPlease\n> > +\tNO_MEMMEM = YesPlease\n> > +\tINSTALL = ginstall\n> > +\tTAR = gtar\n> > +endif\n> > ifeq ($(uname_S),Darwin)\n> > \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> > \tNEEDS_LIBICONV = YesPlease\n> > diff --git a/git-compat-util.h b/git-compat-util.h\n> > index 01c4045..b57041c 100644\n> > --- a/git-compat-util.h\n> > +++ b/git-compat-util.h\n> > @@ -39,7 +39,7 @@\n> > /* Approximation of the length of the decimal representation of this type. */\n> > #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> > \n> > -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> > +#if !defined(__APPLE__) && !defined(__FreeBSD__ ) && !defined(__USLC__) && !defined(_M_UNIX)\n> > #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n> > #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n> > #endif\n> > @@ -89,6 +89,10 @@\n> > #include \n> > #define _ALL_SOURCE 1\n> > #endif\n> > +#if defined(__USLC__)\n> > +#undef _XOPEN_SOURCE\n> > +#include \n> > +#endif\n> \n> Didn't you avoid defining _XOPEN_SOURCE in this case?\n\nYes, I have to not have any _XOPEN_SOURCE because it ommits many defines \nthat are needed by git. I was using the -E trying to track things down. \nThe only option to get everything defined because of the masking was to \nremove it. I have the same problems on the other OS. This is need for \nany SCO OS from Open Desktop 3 and XENIX to the three SCO support OS's. \nOpenServer 5.0.7, UnixWare 7.1.4 and OpenServer 6. Only the last two have \nlarge file system and kernel threads. There are a couple other OS's that \nNovel provided code that uses the USLC. As it is from the orignal UNIX \nGroup that Novell form when they purchase UNIX. So any UNIX from this \nsource that uses the Novell OS compiler's needs it.\n\n> > \n> > #ifndef NO_ICONV\n> > #include \n> > @@ -206,12 +210,15 @@ void *gitmemmem(const void *haystack, size_t haystacklen,\n> > #endif\n> > \n> > #ifdef FREAD_READS_DIRECTORIES\n> > +#if !defined (__USLC__)\n> \n> Can't you not define FREAD_READS_DIRECTORIES?\n\nRemoved see new patch that was posted.\n\n> This seems wrong; it looks like you've added more #endifs than #ifs.\n\nChanged in the new patch that was submitted.\n \n \n> > #ifdef SNPRINTF_RETURNS_BOGUS\n> > #define snprintf git_snprintf\n> > diff --git a/progress.c b/progress.c\n> > index d19f80c..11a0841 100644\n> > --- a/progress.c\n> > +++ b/progress.c\n> > @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> > \t*p_progress = NULL;\n> > \tif (progress->last_value != -1) {\n> > \t\t/* Force the last update */\n> > -\t\tchar buf[strlen(msg) + 5];\n> > +\t\t/* char buf[strlen(msg) + 5]; */\n> > +\t\tchar *buf = malloc (strlen(msg) + 5 );\n> \n> Do we really have exactly one use of this pattern? I thought we either did \n> it more or excluded it by policy. Aside from not leaking the memory and \n> not leaving the old version in a comment, it's probably the right change.\n\nI only could find the one usuage. I am now using alloca.\n \n> Incidentally, you might want to look into \"sparse\", and getting them have \n> an optional warning for code like this that might not be supported by some \n> compilers the project wants to support but doesn't actually use for \n> development regularly.\n\nI am, trying to understand it right now.\n\nThanks,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"78982","messageId":"Pine.LNX.4.64.0806061718420.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"7vmylyrwkg.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-06T23:23:37Z","receivedAt":"2008-06-06T23:23:37Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Junio C Hamano wrote:\n> Boyd Lynn Gerber writes:\n> > diff --git a/progress.c b/progress.c\n> > index d19f80c..295c4e3 100644\n> > --- a/progress.c\n> > +++ b/progress.c\n> > @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> > \t*p_progress = NULL;\n> > \tif (progress->last_value != -1) {\n> > \t\t/* Force the last update */\n> > -\t\tchar buf[strlen(msg) + 5];\n> > +\t\t/* char buf[strlen(msg) + 5]; */\n> > +\t\tchar *buf = alloca (strlen(msg) + 5 );\n> > \t\tstruct throughput *tp = progress->throughput;\n> > \t\tif (tp) {\n> > \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n> \n> I do not know the situation over there these days, but I have a distant\n> but bitter memory of having to deal with AIX X-<. It insisted that\n> inclusion of to be the very first thing in the source before\n> anything else. I would want to keep alloca() out of the codebase without\n> very good reason. Not that I care much about portability to AIX, but not\n> having to worry about alloca() unless necessary is a good thing.\n\nYou hit the nail on the head, AIX and any Novell derived Compiler code \nrequires it. Also the SCO OS's\n \n> I do not think progress_msg() is a good reason to even worrying about a\n> dynamically sized array. The function is designed to spit out a single\n> line of message (so the incoming msg is expected to be shorter than 80\n> chars or so). If you \"git grep stop_progress_msg\", you will see that\n> there are only two callers of this function, one in progress.c itself that\n> says \"done\", and the other one in index-pack.c that gives a string\n> formatted into 48-byte buffer.\n> \n> So we can be lazy and say:\n> \n> \tchar buf[128];\n> ...\n> snprintf(buf, sizeof(buf), \", %s.\\n\", msg)\n> \n> and be done with it.\n\nI like the idea.\n\n> If you really wanted to be safe and anal, you could do something like\n> this, which would be just as efficient and much more straightforward:\n> \n> progress.c | 11 ++++++++---\n> 1 files changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/progress.c b/progress.c\n> index d19f80c..55a8687 100644\n> --- a/progress.c\n> +++ b/progress.c\n> @@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n> \t*p_progress = NULL;\n> \tif (progress->last_value != -1) {\n> \t\t/* Force the last update */\n> -\t\tchar buf[strlen(msg) + 5];\n> +\t\tchar buf[128], *bufp;\n> +\t\tsize_t len = strlen(msg) + 5;\n> \t\tstruct throughput *tp = progress->throughput;\n> +\n> +\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n> \t\tif (tp) {\n> \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n> \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n> \t\t\tthroughput_string(tp, tp->curr_total, rate);\n> \t\t}\n> \t\tprogress_update = 1;\n> -\t\tsprintf(buf, \", %s.\\n\", msg);\n> -\t\tdisplay(progress, progress->last_value, buf);\n> +\t\tsprintf(bufp, \", %s.\\n\", msg);\n> +\t\tdisplay(progress, progress->last_value, bufp);\n> +\t\tif (buf != bufp)\n> +\t\t\tfree(bufp);\n> \t}\n> \tclear_progress_signal();\n> \tfree(progress->throughput);\n> \n> \n\nThanks for the suggestions. I am making changes based on all the feed \nback. I will remove all the debug junk from the final patch. I am \nputting options in and out a lot at the moment. Trying to make sure I do \nnot break anything on the 12 OS's. It is a real pain testing all the \nchanges on them to make sure I did not break anything.\n\nThanks,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"78997","messageId":"Pine.LNX.4.64.0806061822220.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061718420.18454@xenau.zenez.com","subject":"Re: [PATCH] 0002 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-07T00:38:19Z","receivedAt":"2008-06-07T00:38:19Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":">From db0574a7f89bb90b6ce02cd44053f8cec2c454cc\n\nThis patch has patches to\n\nMakefile\ngit-compat-util.h\nprogress.c\n\nThis patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\nand OpenServer 6.0.X to build and run git. Applied suggestions from list.\n\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ 1042 East Fort Union #135, Midvale Utah 84047\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..a0456c8 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -165,6 +165,28 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+#\tChange to -O2 for released version\n+#\tCFLAGS = -O2\n+#\tDebug Version\n+\t\tCFLAGS = -g\n+\tendif\n+#\tFor System V based OS's\n+\tifeq ($(uname_R),5)\n+#\tFor System V based OS's and shared libraries\n+\t\tCFLAGS = -g -O2 -Wall\n+#\tUse for Static version\n+#\t\tCFLAGS = -g -O2\n+\tendif\n+endif\n+#\tFor all UnixWare Versions.\n+ifeq ($(uname_S),UnixWare)\n+#\tFor System V based OS's and shared libraries\n+\tCFLAGS = -g -O2 -Wall\n+#\tUse for Static version\n+#\tCFLAGS = -g -O2\n+endif\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -564,6 +586,42 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tendif\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..b3cd7b3 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,12 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n+ Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n+ OpenServer 5.0.7 This is do avoided compiler hell like the other\n+ OS's __APPLE__ and __FreeBSD__ */\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n+fined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n-- \n1.5.2.4\n"},{"id":"79001","messageId":"alpine.LNX.1.00.0806062043350.19665@iabervon.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061822220.18454@xenau.zenez.com","subject":"Re: [PATCH] 0002 This patch is to allow 12 different OS's to compile and run git.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-06-07T00:47:43Z","receivedAt":"2008-06-07T00:47:43Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n\n> From db0574a7f89bb90b6ce02cd44053f8cec2c454cc\n> \n> This patch has patches to\n> \n> Makefile\n> git-compat-util.h\n> progress.c\n> \n> This patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\n> and OpenServer 6.0.X to build and run git. Applied suggestions from list.\n> \n> Developer's Certificate of Origin 1.1\n> \n> By making a contribution to this project, I certify that:\n> \n> (a) The contribution was created in whole or in part by me and I\n> have the right to submit it under the open source license\n> indicated in the file; or\n> \n> (b) The contribution is based upon previous work that, to the best\n> of my knowledge, is covered under an appropriate open source\n> license and I have the right under that license to submit that\n> work with modifications, whether created in whole or in part\n> by me, under the same open source license (unless I am\n> permitted to submit under a different license), as indicated\n> in the file; or\n> \n> (c) The contribution was provided directly to me by some other\n> person who certified (a), (b) or (c) and I have not modified\n> it.\n> \n> (d) I understand and agree that this project and the contribution\n> are public and that a record of the contribution (including all\n> personal information I submit with it, including my sign-off) is\n> maintained indefinitely and may be redistributed consistent with\n> this project or the open source license(s) involved.\n> \n> Signed-off-by: Boyd Lynn Gerber \n> \n> --\n> Boyd Gerber \n> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047\n> \n> diff --git a/Makefile b/Makefile\n> index cce5a6e..a0456c8 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -165,6 +165,28 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> # CFLAGS and LDFLAGS are for the users to override from the command line.\n> \n> CFLAGS = -g -O2 -Wall\n> +ifeq ($(uname_S),SCO_SV)\n> +\tifeq ($(uname_R),3.2)\n> +#\tChange to -O2 for released version\n> +#\tCFLAGS = -O2\n> +#\tDebug Version\n> +\t\tCFLAGS = -g\n> +\tendif\n> +#\tFor System V based OS's\n> +\tifeq ($(uname_R),5)\n> +#\tFor System V based OS's and shared libraries\n> +\t\tCFLAGS = -g -O2 -Wall\n\nYou don't need this, because CFLAGS is already -g -O2 -Wall, since we set \nit above and couldn't have changed it.\n\n> +#\tUse for Static version\n> +#\t\tCFLAGS = -g -O2\n\nStatic libraries don't support -Wall?\n\n> +\tendif\n> +endif\n> +#\tFor all UnixWare Versions.\n> +ifeq ($(uname_S),UnixWare)\n> +#\tFor System V based OS's and shared libraries\n> +\tCFLAGS = -g -O2 -Wall\n\nAgain, this just sets it to what it must already be.\n\nYou might want to test something the person doing the build can put \nsomewhere, rather than commenting out the lines you're not using.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"79004","messageId":"Pine.LNX.4.64.0806061922290.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"alpine.LNX.1.00.0806062043350.19665@iabervon.org","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-07T01:25:11Z","receivedAt":"2008-06-07T01:25:11Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Daniel Barkalow wrote:\n\n> On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n> \n> > From db0574a7f89bb90b6ce02cd44053f8cec2c454cc\n> > \n> > This patch has patches to\n> > \n> > Makefile\n> > git-compat-util.h\n> > progress.c\n> > \n> > This patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\n> > and OpenServer 6.0.X to build and run git. Applied suggestions from list.\n> > \n> > Developer's Certificate of Origin 1.1\n> > \n> > By making a contribution to this project, I certify that:\n> > \n> > (a) The contribution was created in whole or in part by me and I\n> > have the right to submit it under the open source license\n> > indicated in the file; or\n> > \n> > (b) The contribution is based upon previous work that, to the best\n> > of my knowledge, is covered under an appropriate open source\n> > license and I have the right under that license to submit that\n> > work with modifications, whether created in whole or in part\n> > by me, under the same open source license (unless I am\n> > permitted to submit under a different license), as indicated\n> > in the file; or\n> > \n> > (c) The contribution was provided directly to me by some other\n> > person who certified (a), (b) or (c) and I have not modified\n> > it.\n> > \n> > (d) I understand and agree that this project and the contribution\n> > are public and that a record of the contribution (including all\n> > personal information I submit with it, including my sign-off) is\n> > maintained indefinitely and may be redistributed consistent with\n> > this project or the open source license(s) involved.\n> > \n> > Signed-off-by: Boyd Lynn Gerber \n> > \n> > --\n> > Boyd Gerber \n> > ZENEZ 1042 East Fort Union #135, Midvale Utah 84047\n\nOK made changes you recommended.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..000bf1f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -165,6 +165,11 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+endif\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -564,6 +569,42 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kalloca -Kthread\n+\tendif\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..b3cd7b3 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,12 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n+ Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n+ OpenServer 5.0.7 This is do avoided compiler hell like the other\n+ OS's __APPLE__ and __FreeBSD__ */\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n+fined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79007","messageId":"7vzlpyouwf.fsf@gitster.siamese.dyndns.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806061922290.18454@xenau.zenez.com","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-06-07T02:12:32Z","receivedAt":"2008-06-07T02:12:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> On Fri, 6 Jun 2008, Daniel Barkalow wrote:\n>\n>> On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n>> \n>> > From db0574a7f89bb90b6ce02cd44053f8cec2c454cc\n>> > \n>> > This patch has patches to\n>> > \n>> > Makefile\n>> > git-compat-util.h\n>> > progress.c\n>> > \n>> > This patch allows some older OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4,\n>> > and OpenServer 6.0.X to build and run git. Applied suggestions from list.\n>> > \n>> > Developer's Certificate of Origin 1.1\n>> > \n>> > By making a contribution to this project, I certify that:\n>> > \n>> > (a) The contribution was created in whole or in part by me and I\n>> > have the right to submit it under the open source license\n>> > indicated in the file; or\n>> > \n>> > (b) The contribution is based upon previous work that, to the best\n>> > of my knowledge, is covered under an appropriate open source\n>> > license and I have the right under that license to submit that\n>> > work with modifications, whether created in whole or in part\n>> > by me, under the same open source license (unless I am\n>> > permitted to submit under a different license), as indicated\n>> > in the file; or\n>> > \n>> > (c) The contribution was provided directly to me by some other\n>> > person who certified (a), (b) or (c) and I have not modified\n>> > it.\n>> > \n>> > (d) I understand and agree that this project and the contribution\n>> > are public and that a record of the contribution (including all\n>> > personal information I submit with it, including my sign-off) is\n>> > maintained indefinitely and may be redistributed consistent with\n>> > this project or the open source license(s) involved.\n>> > \n>> > Signed-off-by: Boyd Lynn Gerber \n>> > \n>> > --\n>> > Boyd Gerber \n>> > ZENEZ 1042 East Fort Union #135, Midvale Utah 84047\n>\n> OK made changes you recommended.\n\nI guess the patch text itself seems to be getting reasonable, and perhaps\nthe next few rounds would be to fix the commit log message ;-)\n\n> diff --git a/Makefile b/Makefile\n> index cce5a6e..000bf1f 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -165,6 +165,11 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> # CFLAGS and LDFLAGS are for the users to override from the command line.\n> \n> CFLAGS = -g -O2 -Wall\n> +ifeq ($(uname_S),SCO_SV)\n> +\tifeq ($(uname_R),3.2)\n> +\t\tCFLAGS = -O2\n> +\tendif\n> +endif\n\nWhat makes SCO_SV so special that this platform specific tweak does not\nlive in \"Platform specific tweaks\" section like others?\n\nCFLAGS is for the user to oerride from the command line, and I do not very\nmuch like any tweaks in Makefile. I'd suggest dropping this hunk.\n\n> @@ -564,6 +569,42 @@ endif\n> ifeq ($(uname_S),GNU/kFreeBSD)\n> \tNO_STRLCPY = YesPlease\n> endif\n> +ifeq ($(uname_S),UnixWare)\n> +\tCC=cc\n\ns/=/ = /; you have similar one elsewhere.\n\n> +\tNEEDS_SOCKET = YesPlease\n> +\tNEEDS_NSL = YesPlease\n> +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n> +\tSHELL_PATH = /usr/local/bin/bash\n> +\tNO_IPV6 = YesPlease\n> +\tNO_HSTRERROR = YesPlease\n> +\tBASIC_CFLAGS += -Kalloca -Kthread\n\nI am only guessing what -Kalloca is, but is it for alloca(3), and if so do\nyou still need it?\n\n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index 01c4045..b3cd7b3 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -39,7 +39,12 @@\n> /* Approximation of the length of the decimal representation of this type. */\n> #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> \n> -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> +/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n> + Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n> + OpenServer 5.0.7 This is do avoided compiler hell like the other\n> + OS's __APPLE__ and __FreeBSD__ */\n\nWe generally do not do changelog inside the code comment.\n\n> +#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n> +fined(_M_UNIX)\n\nLinewrapped patch? It is very curious that you have + in front of \"fined(_M_UNIX)\".\n"},{"id":"79009","messageId":"Pine.LNX.4.64.0806062015440.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"7vzlpyouwf.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-07T02:40:34Z","receivedAt":"2008-06-07T02:40:34Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Junio C Hamano wrote:\n> Boyd Lynn Gerber writes:\n> I guess the patch text itself seems to be getting reasonable, and perhaps\n> the next few rounds would be to fix the commit log message ;-)\n\nI have it the same, without all the >> as I first posted, but I agree. \nthat it needs some tweaking.\n \n> > diff --git a/Makefile b/Makefile\n> > index cce5a6e..000bf1f 100644\n> > --- a/Makefile\n> > +++ b/Makefile\n> > @@ -165,6 +165,11 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> > # CFLAGS and LDFLAGS are for the users to override from the command line.\n> > \n> > CFLAGS = -g -O2 -Wall\n> > +ifeq ($(uname_S),SCO_SV)\n> > +\tifeq ($(uname_R),3.2)\n> > +\t\tCFLAGS = -O2\n> > +\tendif\n> > +endif\n> \n> What makes SCO_SV so special that this platform specific tweak does not\n> live in \"Platform specific tweaks\" section like others?\n> \n> CFLAGS is for the user to oerride from the command line, and I do not very\n> much like any tweaks in Makefile. I'd suggest dropping this hunk.\n> \n> > @@ -564,6 +569,42 @@ endif\n> > ifeq ($(uname_S),GNU/kFreeBSD)\n> > \tNO_STRLCPY = YesPlease\n> > endif\n> > +ifeq ($(uname_S),UnixWare)\n> > +\tCC=cc\n> \n> s/=/ = /; you have similar one elsewhere.\n\nI only have the one section now. I will look at it some more.\n\n> > +\tNEEDS_SOCKET = YesPlease\n> > +\tNEEDS_NSL = YesPlease\n> > +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> > +\tNEEDS_LIBICONV = YesPlease\n> > +\tSHELL_PATH = /usr/local/bin/bash\n> > +\tNO_IPV6 = YesPlease\n> > +\tNO_HSTRERROR = YesPlease\n> > +\tBASIC_CFLAGS += -Kalloca -Kthread\n> \n> I am only guessing what -Kalloca is, but is it for alloca(3), and if so do\n> you still need it?\n\nI will make tests without it on the next run. It takes about 3 hours for \nme to get the patches to all the system review them and then run \neverything. Some of the machines are really slow.\n\n> > diff --git a/git-compat-util.h b/git-compat-util.h\n> > index 01c4045..b3cd7b3 100644\n> > --- a/git-compat-util.h\n> > +++ b/git-compat-util.h\n> > @@ -39,7 +39,12 @@\n> > /* Approximation of the length of the decimal representation of this type. */\n> > #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> > \n> > -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> > +/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n> > + Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n> > + OpenServer 5.0.7 This is do avoided compiler hell like the other\n> > + OS's __APPLE__ and __FreeBSD__ */\n> \n> We generally do not do changelog inside the code comment.\n\nWhere do you put your change log stuff, to explain why you made the \nchange. Maybe it is a bit left over from doing things for MySQL AB.\n\n> > +#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !de\n> > +fined(_M_UNIX)\n> \n> Linewrapped patch? It is very curious that you have + in front of \"fined(_M_UNIX)\".\n\nIt is not line wrapped in my file. I do the following after reverting \nevery and strarting with a clean slate.\n\n cp -p .new/* . \n git add Makefile git-compat-util.h progress.c\n git diff --cached\n git commit -s\n git format-patch -p -M -B origin\n\nThe last command above is creating the line wrapped because the line is so \nlong. I do not know enough to force the tools to not do that line wrap. \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79011","messageId":"alpine.LNX.1.00.0806062316270.19665@iabervon.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806062015440.18454@xenau.zenez.com","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-06-07T03:40:01Z","receivedAt":"2008-06-07T03:40:01Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n\n> On Fri, 6 Jun 2008, Junio C Hamano wrote:\n> > Boyd Lynn Gerber writes:\n> > I guess the patch text itself seems to be getting reasonable, and perhaps\n> > the next few rounds would be to fix the commit log message ;-)\n> \n> I have it the same, without all the >> as I first posted, but I agree. \n> that it needs some tweaking.\n> \n> > > diff --git a/Makefile b/Makefile\n> > > index cce5a6e..000bf1f 100644\n> > > --- a/Makefile\n> > > +++ b/Makefile\n> > > @@ -165,6 +165,11 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n> > > # CFLAGS and LDFLAGS are for the users to override from the command line.\n> > > \n> > > CFLAGS = -g -O2 -Wall\n> > > +ifeq ($(uname_S),SCO_SV)\n> > > +\tifeq ($(uname_R),3.2)\n> > > +\t\tCFLAGS = -O2\n> > > +\tendif\n> > > +endif\n> > \n> > What makes SCO_SV so special that this platform specific tweak does not\n> > live in \"Platform specific tweaks\" section like others?\n> > \n> > CFLAGS is for the user to oerride from the command line, and I do not very\n> > much like any tweaks in Makefile. I'd suggest dropping this hunk.\n> > \n> > > @@ -564,6 +569,42 @@ endif\n> > > ifeq ($(uname_S),GNU/kFreeBSD)\n> > > \tNO_STRLCPY = YesPlease\n> > > endif\n> > > +ifeq ($(uname_S),UnixWare)\n> > > +\tCC=cc\n> > \n> > s/=/ = /; you have similar one elsewhere.\n> \n> I only have the one section now. I will look at it some more.\n> \n> > > +\tNEEDS_SOCKET = YesPlease\n> > > +\tNEEDS_NSL = YesPlease\n> > > +\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> > > +\tNEEDS_LIBICONV = YesPlease\n> > > +\tSHELL_PATH = /usr/local/bin/bash\n> > > +\tNO_IPV6 = YesPlease\n> > > +\tNO_HSTRERROR = YesPlease\n> > > +\tBASIC_CFLAGS += -Kalloca -Kthread\n> > \n> > I am only guessing what -Kalloca is, but is it for alloca(3), and if so do\n> > you still need it?\n> \n> I will make tests without it on the next run. It takes about 3 hours for \n> me to get the patches to all the system review them and then run \n> everything. Some of the machines are really slow.\n> \n> > > diff --git a/git-compat-util.h b/git-compat-util.h\n> > > index 01c4045..b3cd7b3 100644\n> > > --- a/git-compat-util.h\n> > > +++ b/git-compat-util.h\n> > > @@ -39,7 +39,12 @@\n> > > /* Approximation of the length of the decimal representation of this type. */\n> > > #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> > > \n> > > -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> > > +/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n> > > + Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n> > > + OpenServer 5.0.7 This is do avoided compiler hell like the other\n> > > + OS's __APPLE__ and __FreeBSD__ */\n> > \n> > We generally do not do changelog inside the code comment.\n> \n> Where do you put your change log stuff, to explain why you made the \n> change. Maybe it is a bit left over from doing things for MySQL AB.\n\nIn the commit message. That is, if your commit message goes:\n\n Allow more systems to build git\n\n __USLC__ indicates a Novell-derived compiler or some SysV\n __M_UNIX indicates XENIX/SCO UNIX/OpenServer before 5.0.7\n Like Apple and BSD, both of these shouldn't have _XOPEN_SOURCE defined\n\nthen an interested user can use \"git blame\" on the file, and then read \nthat info in the commit message for the commit that introduced those \nlines.\n\nAlso on the commit message: you should put the list of affected files \nafter a line with just \"---\", so it appears in the patch but not in the \ncommit; if we want to find out what the commit affects, we can use \"git \nlog --stat\" and find out for sure. The explanation of the sign-off can \nprobably go after the \"---\", too, although the \"Signed-off-by\" line should \nbe above it.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"79091","messageId":"Pine.LNX.4.64.0806072143230.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"alpine.LNX.1.00.0806062316270.19665@iabervon.org","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T03:46:48Z","receivedAt":"2008-06-08T03:46:48Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 6 Jun 2008, Daniel Barkalow wrote:\n> On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:\n> > On Fri, 6 Jun 2008, Junio C Hamano wrote:\n> > > Boyd Lynn Gerber writes:\n> > > > diff --git a/git-compat-util.h b/git-compat-util.h\n> > > > index 01c4045..b3cd7b3 100644\n> > > > --- a/git-compat-util.h\n> > > > +++ b/git-compat-util.h\n> > > > @@ -39,7 +39,12 @@\n> > > > /* Approximation of the length of the decimal representation of this type. */\n> > > > #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n> > > > \n> > > > -#if !defined(__APPLE__) && !defined(__FreeBSD__)\n> > > > +/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V \n> > > > + Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal\n> > > > + OpenServer 5.0.7 This is do avoided compiler hell like the other\n> > > > + OS's __APPLE__ and __FreeBSD__ */\n> > > \n> > > We generally do not do changelog inside the code comment.\n> > \n> > Where do you put your change log stuff, to explain why you made the \n> > change. Maybe it is a bit left over from doing things for MySQL AB.\n> \n> In the commit message. That is, if your commit message goes:\n> \n> Allow more systems to build git\n> \n> __USLC__ indicates a Novell-derived compiler or some SysV\n> __M_UNIX indicates XENIX/SCO UNIX/OpenServer before 5.0.7\n> Like Apple and BSD, both of these shouldn't have _XOPEN_SOURCE defined\n> \n> then an interested user can use \"git blame\" on the file, and then read \n> that info in the commit message for the commit that introduced those \n> lines.\n> \n> Also on the commit message: you should put the list of affected files \n> after a line with just \"---\", so it appears in the patch but not in the \n> commit; if we want to find out what the commit affects, we can use \"git \n> log --stat\" and find out for sure. The explanation of the sign-off can \n> probably go after the \"---\", too, although the \"Signed-off-by\" line should \n> be above it.\n\nSo I should have\n\n---\nMakefile\n\nAdd changes for System V, UnixWare, SCO OS's\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a \nNovell-derived compiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer before 5.0.7 and prior \nrelease of and SCO OS. It is used just like Apple and BSD, both of these \nshouldn't have _XOPEN_SOURCE defined.\n\n---\nprogress.c\n\nChanges for older OS's that do not support the current methods for \nallocation of memory.\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79092","messageId":"Pine.LNX.4.64.0806072146550.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"alpine.LNX.1.00.0806062316270.19665@iabervon.org","subject":"Re: [PATCH] 0004 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T03:50:31Z","receivedAt":"2008-06-08T03:50:31Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"\nThis patch allows some older OS's, UNIX Systems Labs (USL)/Novell and SYS V\nbased OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\nSCO pre OSR 5 OS's to build and run git. Applied suggestions from list.\n\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\nMakefile\n\nAdd changes for System V, UnixWare, SCO OS's\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer before 5.0.7 and prior release\nof and SCO OS. It is used just like Apple and BSD, both of these shouldn't\nhave _XOPEN_SOURCE defined.\n\n---\nprogress.c\n\nChanges for older OS's that do not support the current methods for allocation\nof memory.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..bd65509 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -164,7 +164,6 @@ uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')\n \n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n-CFLAGS = -g -O2 -Wall\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -564,6 +563,45 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kthread\n+\tendif\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..c04e8ba 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n-- \n1.5.2.4\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79096","messageId":"Pine.LNX.4.64.0806080118380.18454@xenau.zenez.com","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806072146550.18454@xenau.zenez.com","subject":"Re: [PATCH] 0004 This patch is to allow 12 different OS's to compile and run git.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-08T07:22:50Z","receivedAt":"2008-06-08T07:22:50Z","isPatch":true,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"Sorry, I forgot to copy the real 00* file to the machine I work on. \nBelow, is what should have been sent.\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n\n--------------------------------Cut-Here-------------------------------\nSubject: [PATCH] This patch is to allow 12 different OS's to compile and run git.\n\nThis patch allows some older OS's, UNIX Systems Labs (USL)/Novell and SYS V\nbased OS's, SCO OpenServer 5.0.X, SCO UnixWare 7.1.4, OpenServer 6.0.X and\nSCO pre OSR 5 OS's to build and run git. Applied suggestions from list.\n\nSigned-off-by: Boyd Lynn Gerber \n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n---\n Developer's Certificate of Origin 1.1\n\n By making a contribution to this project, I certify that:\n\n (a) The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n (b) The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n (c) The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n (d) I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n\n---\nMakefile\n\nAdd changes for System V, UnixWare, SCO OS's\n\n---\ngit-compat-util.h\n\n__USLC__ indicates UNIX System Labs Corperation (USLC), or a Novell-derived\ncompiler and/or some SysV based OS's.\n\n__M_UNIX indicates XENIX/SCO UNIX/OpenServer 5.0.7 and prior release\nof and SCO OS. It is used just like Apple and BSD, both of these shouldn't\nhave _XOPEN_SOURCE defined.\n\n---\nprogress.c\n\nChanges for older OS's that do not support the current methods for allocation\nof memory.\n\ndiff --git a/Makefile b/Makefile\nindex cce5a6e..026de2f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -564,6 +564,45 @@ endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n+ifeq ($(uname_S),UnixWare)\n+\tCC=cc\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/local/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -Kthread\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+endif\n+ifeq ($(uname_S),SCO_SV)\n+\tifeq ($(uname_R),3.2)\n+\t\tCFLAGS = -O2\n+\tendif\n+\tifeq ($(uname_R),5)\n+\t\tCC=cc\n+\t\tBASIC_CFLAGS += -Kthread\n+\tendif\n+\tNEEDS_SOCKET = YesPlease\n+\tNEEDS_NSL = YesPlease\n+\tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSHELL_PATH = /usr/bin/bash\n+\tNO_IPV6 = YesPlease\n+\tNO_HSTRERROR = YesPlease\n+\tBASIC_CFLAGS += -I/usr/local/include\n+\tBASIC_LDFLAGS += -L/usr/local/lib\n+\tNO_STRCASESTR = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tINSTALL = ginstall\n+\tTAR = gtar\n+endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 01c4045..c04e8ba 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -39,7 +39,7 @@\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n-#if !defined(__APPLE__) && !defined(__FreeBSD__)\n+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\ndiff --git a/progress.c b/progress.c\nindex d19f80c..55a8687 100644\n--- a/progress.c\n+++ b/progress.c\n@@ -241,16 +241,21 @@ void stop_progress_msg(struct progress **p_progress, const char *msg)\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n-\t\tchar buf[strlen(msg) + 5];\n+\t\tchar buf[128], *bufp;\n+\t\tsize_t len = strlen(msg) + 5;\n \t\tstruct throughput *tp = progress->throughput;\n+\n+\t\tbufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n \t\t\t\t\ttp->avg_bytes / tp->avg_misecs;\n \t\t\tthroughput_string(tp, tp->curr_total, rate);\n \t\t}\n \t\tprogress_update = 1;\n-\t\tsprintf(buf, \", %s.\\n\", msg);\n-\t\tdisplay(progress, progress->last_value, buf);\n+\t\tsprintf(bufp, \", %s.\\n\", msg);\n+\t\tdisplay(progress, progress->last_value, bufp);\n+\t\tif (buf != bufp)\n+\t\t\tfree(bufp);\n \t}\n \tclear_progress_signal();\n \tfree(progress->throughput);\n-- \n1.5.2.4\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"79097","messageId":"7vy75gl68y.fsf@gitster.siamese.dyndns.org","threadId":"13835","inReplyTo":"Pine.LNX.4.64.0806072143230.18454@xenau.zenez.com","subject":"Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-06-08T07:45:33Z","receivedAt":"2008-06-08T07:45:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> So I should have\n> ... (deleted)\n\nMore like this:\n\n From: Boyd Lynn Gerber \n Subject: [PATCH] Port to other 12 platforms\n Date: Sat, 7 Jun 2008 21:46:48 -0600\n To: git@vger.kernel.org\n Cc: gitster@pobox.com\n\n This adds support to compile git on 12 platforms (<>).\n\n __USLC__ indicates UNIX System Labs Corperation (USLC), or a \n Novell-derived compiler and/or some SysV based OS's. __M_UNIX indicates\n XENIX/SCO UNIX/OpenServer before 5.0.7 and prior release of and SCO OS.\n Like Apple and BSD, both of these do not want _XOPEN_SOURCE defined to\n allow use of <