{"thread":{"id":"13821","subject":"git-name-rev --undefined / --always","startedAt":"2008-06-05T23:49:19Z","lastAt":"2008-06-05T23:49:19Z","messageCount":1,"participants":["Lea Wiemann"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"78844","messageId":"48487B7F.5000909@gmail.com","threadId":"13821","inReplyTo":null,"subject":"git-name-rev --undefined / --always","fromName":"Lea Wiemann","fromEmail":"lewiemann@gmail.com","sentAt":"2008-06-05T23:49:19Z","receivedAt":"2008-06-05T23:49:19Z","isPatch":false,"sender":{"key":"lewiemann@gmail.com","avatar":null},"body":"The name-rev command has an option --undefined (which is not documented \nin git-name-rev.txt) that doesn't do anything.  If you look at \nbuiltin-name-rev.c, allow_undefined never gets set to anything but 1, I \nthink.  In that case --undefined could be made a dummy option for \ncompatibility and the allow_undefined code could be ripped out.\n\nIn the same file, there's also an \"else if (always)\" clause that, if \nallow_undefined is indeed always true, never gets run.  \"git-name-ref \n--tags --always master\" still prints \"undefined\" despite the --always \noption.  (--always is undocumented as well.)\n\nPerhaps someone more knowledgeable should take a look at this (and maybe \nwrite up a test case or two), I don't feel confident submitting patches \nto this file.\n\n-- Lea\n"}]}