{"thread":{"id":"13753","subject":"[PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.","startedAt":"2008-06-01T15:28:44Z","lastAt":"2008-06-02T13:21:38Z","messageCount":4,"participants":["Rob Shearman","Miklos Vajna"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"78291","messageId":"1096648c0806010828yf4f07ebt3f758f41cab5cdfd@mail.gmail.com","threadId":"13753","inReplyTo":null,"subject":"[PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Rob Shearman","fromEmail":"robertshearman@gmail.com","sentAt":"2008-06-01T15:28:44Z","receivedAt":"2008-06-01T15:28:44Z","isPatch":true,"sender":{"key":"robertshearman@gmail.com","avatar":null},"body":"Call setup_git_directory_gently to allow git-imap-send to be used from\nsubdirectories of a git tree.\n\nSigned-off-by: Robert Shearman <robertshearman@gmail.com>\n---\n imap-send.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\n\ndiff --git a/imap-send.c b/imap-send.c\nindex 1ec1310..89a1532 100644\n--- a/imap-send.c\n+++ b/imap-send.c\n@@ -1296,6 +1296,7 @@ main(int argc, char **argv)\n \t/* init the random number generator */\n \tarc4_init();\n \n+\tsetup_git_directory_gently( NULL );\n \tgit_config(git_imap_config, NULL);\n \n \tif (!imap_folder) {\n"},{"id":"78313","messageId":"20080601220410.GD29404@genesis.frugalware.org","threadId":"13753","inReplyTo":"1096648c0806010828yf4f07ebt3f758f41cab5cdfd@mail.gmail.com","subject":"Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-06-01T22:04:10Z","receivedAt":"2008-06-01T22:04:10Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:\n> +\tsetup_git_directory_gently( NULL );\n>  \tgit_config(git_imap_config, NULL);\n\nI know this is just about cosmetics, but the style of the rest of the\ncode would suggest using\n\n        setup_git_directory_gently(NULL);\n\nnot \n\n        setup_git_directory_gently( NULL );\n"},{"id":"78343","messageId":"1096648c0806020118i1d990affn17af29651e60b13b@mail.gmail.com","threadId":"13753","inReplyTo":"20080601220410.GD29404@genesis.frugalware.org","subject":"Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Rob Shearman","fromEmail":"robertshearman@gmail.com","sentAt":"2008-06-02T08:18:09Z","receivedAt":"2008-06-02T08:18:09Z","isPatch":true,"sender":{"key":"robertshearman@gmail.com","avatar":null},"body":"2008/6/1 Miklos Vajna <vmiklos@frugalware.org>:\n> On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:\n>> +     setup_git_directory_gently( NULL );\n>>       git_config(git_imap_config, NULL);\n>\n> I know this is just about cosmetics, but the style of the rest of the\n> code would suggest using\n>\n>        setup_git_directory_gently(NULL);\n>\n> not\n>\n>        setup_git_directory_gently( NULL );\n\nThis isn't my normal coding style - I was trying to match the coding\nstyle to the rest of the file. Only the subsequent line to my added\nline uses the \"func(arg)\" style instead of the \"func( arg )\" style and\nthat line was changed to the former very recently.\n\nA patch to fix the style of the call to git_config could be done\nseparately to this one.\n\n-- \nRob Shearman\n"},{"id":"78359","messageId":"20080602132138.GG29404@genesis.frugalware.org","threadId":"13753","inReplyTo":"1096648c0806020118i1d990affn17af29651e60b13b@mail.gmail.com","subject":"Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-06-02T13:21:38Z","receivedAt":"2008-06-02T13:21:38Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Mon, Jun 02, 2008 at 09:18:09AM +0100, Rob Shearman <robertshearman@gmail.com> wrote:\n> > not\n> >\n> >        setup_git_directory_gently( NULL );\n> \n> This isn't my normal coding style - I was trying to match the coding\n> style to the rest of the file. Only the subsequent line to my added\n> line uses the \"func(arg)\" style instead of the \"func( arg )\" style and\n> that line was changed to the former very recently.\n\nAh, I see. I haven't looked at imap-send.c specifically, it seems that\nthis weird \"func( arg )\" style is used there a lot of times, so sorry\nfor bothering you with cosmetics.\n"}]}