{"thread":{"id":"13708","subject":"Problem fetching the git homepage","startedAt":"2008-05-28T15:45:43Z","lastAt":"2008-05-28T16:59:15Z","messageCount":4,"participants":["Gustaf Hendeby","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"77943","messageId":"483D7E27.7030809@isy.liu.se","threadId":"13708","inReplyTo":null,"subject":"Problem fetching the git homepage","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-05-28T15:45:43Z","receivedAt":"2008-05-28T15:45:43Z","isPatch":false,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"I'm trying to fetch the repo of the git homepage but get this error:\n\n$ git version\ngit version 1.5.6.rc0.140.ga9675\n$ git fetch origin\nGetting alternates list for http://repo.or.cz/r/git-homepage.git\nGetting pack list for http://repo.or.cz/r/git-homepage.git\nGetting index for pack d4404a860edd30b154e8cd5b8c66ec35cf682dae\nGetting pack d4404a860edd30b154e8cd5b8c66ec35cf682dae\n which contains 50819d376acb03429ab2628ef3d07893c7f0e22c\nerror: packfile \n.git/objects/pack/pack-d4404a860edd30b154e8cd5b8c66ec35cf682dae.pack \nsize changed\nfatal: packfile \n.git/objects/pack/pack-d4404a860edd30b154e8cd5b8c66ec35cf682dae.pack \ncannot be accessed\n\nThe last commit I have is \"Automated update: [2008-04-20] v1.5.5 -> \nv1.5.5.1\" (2b7e2d6a).\n\nIs this due to something I've done? (Not even sure from the error \nmessage if it is a local error, or a remote error.) Or a sign of \nsomething more serious?\n\n/Gustaf\n"},{"id":"77949","messageId":"7v1w3mwffq.fsf@gitster.siamese.dyndns.org","threadId":"13708","inReplyTo":"483D7E27.7030809@isy.liu.se","subject":"Re: Problem fetching the git homepage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-05-28T16:39:53Z","receivedAt":"2008-05-28T16:39:53Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Gustaf Hendeby writes:\n\n> I'm trying to fetch the repo of the git homepage but get this error:\n>\n> $ git version\n> git version 1.5.6.rc0.140.ga9675\n> $ git fetch origin\n> Getting alternates list for http://repo.or.cz/r/git-homepage.git\n> Getting pack list for http://repo.or.cz/r/git-homepage.git\n> Getting index for pack d4404a860edd30b154e8cd5b8c66ec35cf682dae\n> Getting pack d4404a860edd30b154e8cd5b8c66ec35cf682dae\n> which contains 50819d376acb03429ab2628ef3d07893c7f0e22c\n> error: packfile\n> .git/objects/pack/pack-d4404a860edd30b154e8cd5b8c66ec35cf682dae.pack\n> size changed\n> fatal: packfile\n> .git/objects/pack/pack-d4404a860edd30b154e8cd5b8c66ec35cf682dae.pack\n> cannot be accessed\n>\n> The last commit I have is \"Automated update: [2008-04-20] v1.5.5 ->\n> v1.5.5.1\" (2b7e2d6a).\n>\n> Is this due to something I've done? (Not even sure from the error\n> message if it is a local error, or a remote error.) Or a sign of\n> something more serious?\n\nThanks for reporting. This is a breakage in 633f43e (Remove redundant\ncode, eliminate one static variable, 2008-05-24).\n"},{"id":"77950","messageId":"7vskw2v0i8.fsf_-_@gitster.siamese.dyndns.org","threadId":"13708","inReplyTo":"7v1w3mwffq.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] fix sha1_pack_index_name()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-05-28T16:47:43Z","receivedAt":"2008-05-28T16:47:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"An earlier commit 633f43e (Remove redundant code, eliminate one static\nvariable, 2008-05-24) had a thinko (perhaps an eyeno) that broke\nsha1_pack_index_name() function. One symptom of this was that the http\nwalker is now completely broken.\n\nThis should fix it.\n\nSigned-off-by: Junio C Hamano \n---\n sha1_file.c | 9 +++++----\n 1 files changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/sha1_file.c b/sha1_file.c\nindex 9679040..adcf37c 100644\n--- a/sha1_file.c\n+++ b/sha1_file.c\n@@ -177,7 +177,7 @@ char *sha1_file_name(const unsigned char *sha1)\n }\n \n static char *sha1_get_pack_name(const unsigned char *sha1,\n-\t\t\t\tchar **name, char **base)\n+\t\t\t\tchar **name, char **base, const char *which)\n {\n \tstatic const char hex[] = \"0123456789abcdef\";\n \tchar *buf;\n@@ -187,7 +187,8 @@ static char *sha1_get_pack_name(const unsigned char *sha1,\n \t\tconst char *sha1_file_directory = get_object_directory();\n \t\tint len = strlen(sha1_file_directory);\n \t\t*base = xmalloc(len + 60);\n-\t\tsprintf(*base, \"%s/pack/pack-1234567890123456789012345678901234567890.pack\", sha1_file_directory);\n+\t\tsprintf(*base, \"%s/pack/pack-1234567890123456789012345678901234567890.%s\",\n+\t\t\tsha1_file_directory, which);\n \t\t*name = *base + len + 11;\n \t}\n \n@@ -206,14 +207,14 @@ char *sha1_pack_name(const unsigned char *sha1)\n {\n \tstatic char *name, *base;\n \n-\treturn sha1_get_pack_name(sha1, &name, &base);\n+\treturn sha1_get_pack_name(sha1, &name, &base, \"pack\");\n }\n \n char *sha1_pack_index_name(const unsigned char *sha1)\n {\n \tstatic char *name, *base;\n \n-\treturn sha1_get_pack_name(sha1, &name, &base);\n+\treturn sha1_get_pack_name(sha1, &name, &base, \"idx\");\n }\n \n struct alternate_object_database *alt_odb_list;\n"},{"id":"77953","messageId":"483D8F63.2000007@isy.liu.se","threadId":"13708","inReplyTo":"7vskw2v0i8.fsf_-_@gitster.siamese.dyndns.org","subject":"Re: [PATCH] fix sha1_pack_index_name()","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-05-28T16:59:15Z","receivedAt":"2008-05-28T16:59:15Z","isPatch":true,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"On 05/28/2008 06:47 PM, Junio C Hamano wrote:\n> An earlier commit 633f43e (Remove redundant code, eliminate one static\n> variable, 2008-05-24) had a thinko (perhaps an eyeno) that broke\n> sha1_pack_index_name() function. One symptom of this was that the http\n> walker is now completely broken.\n> \n> This should fix it.\n> \n> Signed-off-by: Junio C Hamano \n\nThis did - applied on top of next - not fix my problem but changed the \nerror message somewhat:\n\n$ git version\ngit version 1.5.6.rc0.141.g55e0e\n$ git fetch origin\nGetting alternates list for http://repo.or.cz/r/git-homepage.git\nGetting pack list for http://repo.or.cz/r/git-homepage.git\nerror: Unable to find 50819d376acb03429ab2628ef3d07893c7f0e22c under \nhttp://repo.or.cz/r/git-homepage.git\nCannot obtain needed object 50819d376acb03429ab2628ef3d07893c7f0e22c\nfatal: Fetch failed.\n\n/Gustaf\n\n> ---\n> sha1_file.c | 9 +++++----\n> 1 files changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/sha1_file.c b/sha1_file.c\n> index 9679040..adcf37c 100644\n> --- a/sha1_file.c\n> +++ b/sha1_file.c\n> @@ -177,7 +177,7 @@ char *sha1_file_name(const unsigned char *sha1)\n> }\n> \n> static char *sha1_get_pack_name(const unsigned char *sha1,\n> -\t\t\t\tchar **name, char **base)\n> +\t\t\t\tchar **name, char **base, const char *which)\n> {\n> \tstatic const char hex[] = \"0123456789abcdef\";\n> \tchar *buf;\n> @@ -187,7 +187,8 @@ static char *sha1_get_pack_name(const unsigned char *sha1,\n> \t\tconst char *sha1_file_directory = get_object_directory();\n> \t\tint len = strlen(sha1_file_directory);\n> \t\t*base = xmalloc(len + 60);\n> -\t\tsprintf(*base, \"%s/pack/pack-1234567890123456789012345678901234567890.pack\", sha1_file_directory);\n> +\t\tsprintf(*base, \"%s/pack/pack-1234567890123456789012345678901234567890.%s\",\n> +\t\t\tsha1_file_directory, which);\n> \t\t*name = *base + len + 11;\n> \t}\n> \n> @@ -206,14 +207,14 @@ char *sha1_pack_name(const unsigned char *sha1)\n> {\n> \tstatic char *name, *base;\n> \n> -\treturn sha1_get_pack_name(sha1, &name, &base);\n> +\treturn sha1_get_pack_name(sha1, &name, &base, \"pack\");\n> }\n> \n> char *sha1_pack_index_name(const unsigned char *sha1)\n> {\n> \tstatic char *name, *base;\n> \n> -\treturn sha1_get_pack_name(sha1, &name, &base);\n> +\treturn sha1_get_pack_name(sha1, &name, &base, \"idx\");\n> }\n> \n> struct alternate_object_database *alt_odb_list;\n"}]}