{"thread":{"id":"13563","subject":"Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","startedAt":"2008-05-18T05:18:30Z","lastAt":"2008-05-22T23:59:08Z","messageCount":12,"participants":["Twiinz","Shawn O. Pearce","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"77219","messageId":"412a1d9a0805172218v7c0a920es8a48129014051a35@mail.gmail.com","threadId":"13563","inReplyTo":null,"subject":"Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Twiinz","fromEmail":"twiinz@gmail.com","sentAt":"2008-05-18T05:18:30Z","receivedAt":"2008-05-18T05:18:30Z","isPatch":false,"sender":{"key":"twiinz@gmail.com","avatar":null},"body":"In git-gui after clicking either on 'Create New Repository' or 'Open\nExisting Repository' the form elements aren't centered like they are\npretty much everywhere else in the app. At least when ran on a mac,\nhaven't checked on other platforms.\n\nUsing grid instead of pack seems to fix this.\n\nHope that helps, cheers,\n/twiinz\n\n\n--- choose_repository.old.tcl\t2008-05-18 11:54:23.000000000 +0700\n+++ choose_repository.tcl\t2008-05-18 11:56:41.000000000 +0700\n@@ -388,9 +388,7 @@ method _do_new {} {\n \t\t-command [cb _new_local_path]\n \tset w_localpath $w_body.where.t\n \n-\tpack $w_body.where.b -side right\n-\tpack $w_body.where.l -side left\n-\tpack $w_body.where.t -fill x\n+\tgrid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew\n \tpack $w_body.where -fill x\n \n \ttrace add variable @local_path write [cb _write_local_path]\n@@ -987,9 +985,7 @@ method _do_open {} {\n \t\t-text [mc \"Browse\"] \\\n \t\t-command [cb _open_local_path]\n \n-\tpack $w_body.where.b -side right\n-\tpack $w_body.where.l -side left\n-\tpack $w_body.where.t -fill x\n+\tgrid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew\n \tpack $w_body.where -fill x\n \n \ttrace add variable @local_path write [cb _write_local_path]\n"},{"id":"77251","messageId":"20080519040746.GA29038@spearce.org","threadId":"13563","inReplyTo":"412a1d9a0805172218v7c0a920es8a48129014051a35@mail.gmail.com","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-05-19T04:07:46Z","receivedAt":"2008-05-19T04:07:46Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Twiinz wrote:\n> In git-gui after clicking either on 'Create New Repository' or 'Open\n> Existing Repository' the form elements aren't centered like they are\n> pretty much everywhere else in the app. At least when ran on a mac,\n> haven't checked on other platforms.\n> \n> Using grid instead of pack seems to fix this.\n\nThanks. This is a reasonable solution. Signed-off-by tag? Do you\nwant the attribution to be just \"Twiinz \"?\n\nI ask because the patch is a valid patch and it does apply, but it\nisn't a standard git patch and wasn't sent inline, so git-am wasn't\nable to extract and apply everything for me automagically.\n\n-- \nShawn.\n"},{"id":"77255","messageId":"412a1d9a0805182234i18e2da4ckf428b2c134e174d1@mail.gmail.com","threadId":"13563","inReplyTo":"20080519040746.GA29038@spearce.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Twiinz","fromEmail":"twiinz@gmail.com","sentAt":"2008-05-19T05:34:31Z","receivedAt":"2008-05-19T05:34:31Z","isPatch":false,"sender":{"key":"twiinz@gmail.com","avatar":null},"body":"Hi Shawn,\n\nNo worries for Signed-off-by and \"Twiinz \" for the\nattribution.\n\nSorry for the lack of information in the patch, I'm rather new to\nthat, I'll check out how to make it better for future contributions.\n\nCheers,\n/twiinz\n\nOn Mon, May 19, 2008 at 11:07 AM, Shawn O. Pearce wrote:\n> Twiinz wrote:\n>> In git-gui after clicking either on 'Create New Repository' or 'Open\n>> Existing Repository' the form elements aren't centered like they are\n>> pretty much everywhere else in the app. At least when ran on a mac,\n>> haven't checked on other platforms.\n>>\n>> Using grid instead of pack seems to fix this.\n>\n> Thanks. This is a reasonable solution. Signed-off-by tag? Do you\n> want the attribution to be just \"Twiinz \"?\n>\n> I ask because the patch is a valid patch and it does apply, but it\n> isn't a standard git patch and wasn't sent inline, so git-am wasn't\n> able to extract and apply everything for me automagically.\n>\n> --\n> Shawn.\n>\n"},{"id":"77265","messageId":"alpine.DEB.1.00.0805191127200.30431@racer","threadId":"13563","inReplyTo":"412a1d9a0805182234i18e2da4ckf428b2c134e174d1@mail.gmail.com","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-05-19T10:28:48Z","receivedAt":"2008-05-19T10:28:48Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 19 May 2008, Twiinz wrote:\n\n> No worries for Signed-off-by and \"Twiinz \" for the\n> attribution.\n\nUmm.\n\nThe Signed-off-by is not so much for _you_ as for the people who _use_ \nwhat you contributed, so that they can always say \"but Twiinz signed off \non it, he said that he will not sue my $ss off later, like this Darl \nb$stard\".\n\nSo yes, I do worry.\n\nAlso, please do not top-post.\n\nHth,\nDscho\n"},{"id":"77372","messageId":"7vej7w6syo.fsf@gitster.siamese.dyndns.org","threadId":"13563","inReplyTo":"alpine.DEB.1.00.0805191127200.30431@racer","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-05-21T07:01:51Z","receivedAt":"2008-05-21T07:01:51Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> The Signed-off-by is not so much for _you_ as for the people who _use_ \n> what you contributed, so that they can always say \"but Twiinz signed off \n> on it, he said that he will not sue my $ss off later, like this Darl \n> b$stard\".\n>\n> So yes, I do worry.\n\nIt is not about him suing us, but more about \"He certified that he did not\nsteal it from anywhere else\", iow, other people suing us for what he did.\n\nAnd we should worry.\n"},{"id":"77458","messageId":"20080522121107.GK29038@spearce.org","threadId":"13563","inReplyTo":"7vej7w6syo.fsf@gitster.siamese.dyndns.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-05-22T12:11:07Z","receivedAt":"2008-05-22T12:11:07Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> Johannes Schindelin writes:\n> \n> > The Signed-off-by is not so much for _you_ as for the people who _use_ \n> > what you contributed, so that they can always say \"but Twiinz signed off \n> > on it, he said that he will not sue my $ss off later, like this Darl \n> > b$stard\".\n> >\n> > So yes, I do worry.\n> \n> It is not about him suing us, but more about \"He certified that he did not\n> steal it from anywhere else\", iow, other people suing us for what he did.\n> \n> And we should worry.\n\nIn this case it is a very trivial patch. Anyone who tries to do\nthe same thing is likely to come up with the same result, or one\nthat is close enough that it looks identical anyway.\n\nStill, it isn't in my main tree, because it is lacking a proper\nSigned-off-by tag by the original author.\n\n-- \nShawn.\n"},{"id":"77460","messageId":"412a1d9a0805220545veb9af51y833aed2234d258b@mail.gmail.com","threadId":"13563","inReplyTo":"20080522121107.GK29038@spearce.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Twiinz","fromEmail":"twiinz@gmail.com","sentAt":"2008-05-22T12:45:27Z","receivedAt":"2008-05-22T12:45:27Z","isPatch":false,"sender":{"key":"twiinz@gmail.com","avatar":null},"body":"On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce wrote:\n> In this case it is a very trivial patch. Anyone who tries to do\n> the same thing is likely to come up with the same result, or one\n> that is close enough that it looks identical anyway.\n>\n> Still, it isn't in my main tree, because it is lacking a proper\n> Signed-off-by tag by the original author.\n\nSorry for the late response,\n\nIt's a very trivial patch, indeed.\n\nI'm still a bit confused with those Signed-off-by things. Anyway I\nsign hereby that:\n- I coded those few lines myself\n- I didn't steal them from anyone\n- I'm not going to sue anybody over its utilization\n\nIf there's more that need to be done to get this patch approved please\npoint me to some online materials that detail the process.\n\nI hope that helps,\n/twiinz\n"},{"id":"77467","messageId":"20080522125559.GO29038@spearce.org","threadId":"13563","inReplyTo":"412a1d9a0805220545veb9af51y833aed2234d258b@mail.gmail.com","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-05-22T12:55:59Z","receivedAt":"2008-05-22T12:55:59Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Twiinz wrote:\n> On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce wrote:\n> > In this case it is a very trivial patch. Anyone who tries to do\n> > the same thing is likely to come up with the same result, or one\n> > that is close enough that it looks identical anyway.\n> >\n> > Still, it isn't in my main tree, because it is lacking a proper\n> > Signed-off-by tag by the original author.\n> \n> Sorry for the late response,\n> \n> It's a very trivial patch, indeed.\n> \n> I'm still a bit confused with those Signed-off-by things. Anyway I\n> sign hereby that:\n> - I coded those few lines myself\n> - I didn't steal them from anyone\n> - I'm not going to sue anybody over its utilization\n\nSee \"Sign your work\" of git.git/Documentation/SubmittingPatches:\n\n http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;h=0e155c936c25255706bc6d47651c2b336c628417;hb=377d9c409ffe0f0d994b929aeb94716139207b9d\n\nI think most reasonable people would say your statement has roughly\nthe same intent and effect as the Developer's Certificate of\nOrigin 1.1.\n \n> If there's more that need to be done to get this patch approved please\n> point me to some online materials that detail the process.\n> \n> I hope that helps,\n\nI'm going to edit your commit and add the signed off by line for you:\n\n\tSigned-off-by: Twiinz \n\nThanks.\n\n-- \nShawn.\n"},{"id":"77468","messageId":"412a1d9a0805220609r5403cbffyf48478cf8dfcc27d@mail.gmail.com","threadId":"13563","inReplyTo":"20080522125559.GO29038@spearce.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Twiinz","fromEmail":"twiinz@gmail.com","sentAt":"2008-05-22T13:09:00Z","receivedAt":"2008-05-22T13:09:00Z","isPatch":false,"sender":{"key":"twiinz@gmail.com","avatar":null},"body":"On Thu, May 22, 2008 at 7:55 PM, Shawn O. Pearce wrote:\n> I'm going to edit your commit and add the signed off by line for you:\n>\n> Signed-off-by: Twiinz \n\nThanks for your help Shawn.\n\nI'll read that link you sent and I'll make sure next patch i\ncontribute has everything needed.\n\nCheers,\n/twiinz\n"},{"id":"77483","messageId":"7v4p8qw7to.fsf@gitster.siamese.dyndns.org","threadId":"13563","inReplyTo":"20080522121107.GK29038@spearce.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-05-22T17:46:11Z","receivedAt":"2008-05-22T17:46:11Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Junio C Hamano wrote:\n>> Johannes Schindelin writes:\n>> \n>> > The Signed-off-by is not so much for _you_ as for the people who _use_ \n>> > what you contributed, so that they can always say \"but Twiinz signed off \n>> > on it, he said that he will not sue my $ss off later, like this Darl \n>> > b$stard\".\n>> >\n>> > So yes, I do worry.\n>> \n>> It is not about him suing us, but more about \"He certified that he did not\n>> steal it from anywhere else\", iow, other people suing us for what he did.\n>> \n>> And we should worry.\n>\n> In this case it is a very trivial patch.\n\nYeah, I realized that I should have added that after sending the message.\nI'd rather not to see a patch without S-o-b than with a S-o-b with a\nphoney name, though.\n"},{"id":"77509","messageId":"20080522225730.GQ29038@spearce.org","threadId":"13563","inReplyTo":"7v4p8qw7to.fsf@gitster.siamese.dyndns.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-05-22T22:57:30Z","receivedAt":"2008-05-22T22:57:30Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> \"Shawn O. Pearce\" writes:\n> > In this case it is a very trivial patch.\n> \n> Yeah, I realized that I should have added that after sending the message.\n> I'd rather not to see a patch without S-o-b than with a S-o-b with a\n> phoney name, though.\n\nLike this one?\n\n commit 2b36b146fa892a0a326eb2e35a39c9daf58fbe5e\n Author: A Large Angry SCM \n Date: Sat May 10 16:52:51 2008 -0400\n\n git-repack: re-enable parsing of -n command line option\n \n In commit 5715d0b (Migrate git-repack.sh to use git-rev-parse --parseopt,\n 2007-11-04), parsing of the '-n' command line option was accidentally lost\n when git-repack.sh was migrated to use git-rev-parse --parseopt. This adds\n it back.\n \n Signed-off-by: A Large Angry SCM \n Signed-off-by: Junio C Hamano \n\n;-)\n\nAre we starting to make a submission policy that all contributions\nneed to have a non-phony looking name for the author line and\nSBO? We have not done so in the past, and we do not have the\ninfrastructure like The Eclipse Foundation has to require all\ncontributors to execute a (possibly enforceable) legal agreement\nstating their contribution can be distributed under the GPLv2.\n\n-- \nShawn.\n"},{"id":"77514","messageId":"7vabihvqk3.fsf@gitster.siamese.dyndns.org","threadId":"13563","inReplyTo":"20080522225730.GQ29038@spearce.org","subject":"Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-05-22T23:59:08Z","receivedAt":"2008-05-22T23:59:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Junio C Hamano wrote:\n>> \"Shawn O. Pearce\" writes:\n>> > In this case it is a very trivial patch.\n>> \n>> Yeah, I realized that I should have added that after sending the message.\n>> I'd rather not to see a patch without S-o-b than with a S-o-b with a\n>> phoney name, though.\n>\n> Like this one?\n\nSorry, your comparison is worse than apples-and-oranges.\n\nGitzilla was a relatively old-timer, already known entity in git circle\nfor quite some time, when we accepted that patch (also I think we know the\nreal name as well, check your local list archive).\n\nIn either case, that one and the one under discussion are both trivially\nobvious changes and do not give us much worries.\n"}]}