{"thread":{"id":"13562","subject":"[PATCH] t/Makefile: update makefile to remove new spaceful trash directory","startedAt":"2008-05-18T04:03:03Z","lastAt":"2008-05-18T05:01:27Z","messageCount":2,"participants":["drafnel@gmail.com","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"77217","messageId":"3559937.1211083293079.JavaMail.teamon@b304.teamon.com","threadId":"13562","inReplyTo":null,"subject":"[PATCH] t/Makefile: update makefile to remove new spaceful trash directory","fromName":"","fromEmail":"drafnel@gmail.com","sentAt":"2008-05-18T04:03:03Z","receivedAt":"2008-05-18T04:03:03Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nSigned-off-by: Brandon Casey <drafnel@gmail.com>\n---\n t/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 72d7884..c6a60ab 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -20,7 +20,7 @@ $(T):\n \t@echo \"*** $@ ***\"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)\n \n clean:\n-\t$(RM) -r trash\n+\t$(RM) -r 'trash directory'\n \n # we can test NO_OPTIMIZE_COMMITS independently of LC_ALL\n full-svn-test:\n-- \n1.5.5.1.447.geb0a7\n"},{"id":"77218","messageId":"20080518050126.GB31609@sigill.intra.peff.net","threadId":"13562","inReplyTo":"3559937.1211083293079.JavaMail.teamon@b304.teamon.com","subject":"Re: [PATCH] t/Makefile: update makefile to remove new spaceful trash directory","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-05-18T05:01:27Z","receivedAt":"2008-05-18T05:01:27Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, May 17, 2008 at 11:03:03PM -0500, drafnel@gmail.com wrote:\n\n>  clean:\n> -\t$(RM) -r trash\n> +\t$(RM) -r 'trash directory'\n\nProbably these non-code references should be squashed in as well. This\nis the result of scanning \"git grep trash\". There are still a few\nreferences to \"trash\" in test script comments, but they are more of the\n\"this goes in the trash directory\" context and not \"the name of this\ndirectory is 'trash'\".\n\nt5516 has a few insteadOf tests that look like they might be\nproblematic, but aren't.\n\n---\ndiff --git a/t/README b/t/README\nindex 73ed11b..70841a4 100644\n--- a/t/README\n+++ b/t/README\n@@ -123,7 +123,7 @@ This test harness library does the following things:\n    (or -h), it shows the test_description and exits.\n \n  - Creates an empty test directory with an empty .git/objects\n-   database and chdir(2) into it.  This directory is 't/trash'\n+   database and chdir(2) into it.  This directory is 't/trash directory'\n    if you must know, but I do not think you care.\n \n  - Defines standard test helper functions for your scripts to\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 5002fb0..6ba569f 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -368,7 +368,7 @@ test_done () {\n \tcase \"$test_failure\" in\n \t0)\n \t\t# We could:\n-\t\t# cd .. && rm -fr trash\n+\t\t# cd .. && rm -fr 'trash directory'\n \t\t# but that means we forbid any tests that use their own\n \t\t# subdirectory from calling test_done without coming back\n \t\t# to where they started from.\n"}]}