{"thread":{"id":"13479","subject":"[PATCH 3/3] rev-parse --verify: do not output anything on error","startedAt":"2008-05-11T16:28:25Z","lastAt":"2008-05-11T16:28:25Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"76632","messageId":"20080511182825.42bc6ec9.chriscool@tuxfamily.org","threadId":"13479","inReplyTo":null,"subject":"[PATCH 3/3] rev-parse --verify: do not output anything on error","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-05-11T16:28:25Z","receivedAt":"2008-05-11T16:28:25Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Before this patch, when \"git rev-parse --verify\" was passed at least one\ngood rev and then anything, it would output something for the good rev\neven if it would latter exit on error.\n\nWith this patch, we only output something if everything is ok.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n builtin-rev-parse.c         |   38 +++++++++++++++++++++++---------------\n t/t1503-rev-parse-verify.sh |   12 +++---------\n 2 files changed, 26 insertions(+), 24 deletions(-)\n\ndiff --git a/builtin-rev-parse.c b/builtin-rev-parse.c\nindex 7dbf282..03b5f59 100644\n--- a/builtin-rev-parse.c\n+++ b/builtin-rev-parse.c\n@@ -28,8 +28,6 @@ static int symbolic;\n static int abbrev;\n static int output_sq;\n \n-static int revs_count;\n-\n /*\n  * Some arguments are relevant \"revision\" arguments,\n  * others are about output format or other details.\n@@ -102,7 +100,6 @@ static void show_rev(int type, const unsigned char *sha1, const char *name)\n \tif (!(filter & DO_REVS))\n \t\treturn;\n \tdef = NULL;\n-\trevs_count++;\n \n \tif (type != show_type)\n \t\tputchar('^');\n@@ -150,7 +147,7 @@ static int show_flag(const char *arg)\n \treturn 0;\n }\n \n-static void show_default(void)\n+static int show_default(void)\n {\n \tconst char *s = def;\n \n@@ -160,9 +157,10 @@ static void show_default(void)\n \t\tdef = NULL;\n \t\tif (!get_sha1(s, sha1)) {\n \t\t\tshow_rev(NORMAL, sha1, s);\n-\t\t\treturn;\n+\t\t\treturn 1;\n \t\t}\n \t}\n+\treturn 0;\n }\n \n static int show_reference(const char *refname, const unsigned char *sha1, int flag, void *cb_data)\n@@ -375,8 +373,9 @@ static void die_no_single_rev(int quiet)\n \n int cmd_rev_parse(int argc, const char **argv, const char *prefix)\n {\n-\tint i, as_is = 0, verify = 0, quiet = 0;\n+\tint i, as_is = 0, verify = 0, quiet = 0, revs_count = 0, type;\n \tunsigned char sha1[20];\n+\tconst char *name;\n \n \tif (argc > 1 && !strcmp(\"--parseopt\", argv[1]))\n \t\treturn cmd_parseopt(argc - 1, argv + 1, prefix);\n@@ -568,12 +567,17 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)\n \t\t/* Not a flag argument */\n \t\tif (try_difference(arg))\n \t\t\tcontinue;\n-\t\tif (!get_sha1(arg, sha1)) {\n-\t\t\tshow_rev(NORMAL, sha1, arg);\n-\t\t\tcontinue;\n+\t\tname = arg;\n+\t\ttype = NORMAL;\n+\t\tif (*arg == '^') {\n+\t\t\tname++;\n+\t\t\ttype = REVERSED;\n \t\t}\n-\t\tif (*arg == '^' && !get_sha1(arg+1, sha1)) {\n-\t\t\tshow_rev(REVERSED, sha1, arg+1);\n+\t\tif (!get_sha1(name, sha1)) {\n+\t\t\tif (verify)\n+\t\t\t\trevs_count++;\n+\t\t\telse\n+\t\t\t\tshow_rev(type, sha1, name);\n \t\t\tcontinue;\n \t\t}\n \t\tif (verify)\n@@ -583,10 +587,14 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)\n \t\t\tcontinue;\n \t\tverify_filename(prefix, arg);\n \t}\n-\tif (verify && revs_count == 1)\n-\t\treturn 0;\n-\tshow_default();\n-\tif (verify && revs_count != 1)\n+\tif (verify) {\n+\t\tif (revs_count == 1) {\n+\t\t\tshow_rev(type, sha1, name);\n+\t\t\treturn 0;\n+\t\t} else if (revs_count == 0 && show_default())\n+\t\t\treturn 0;\n \t\tdie_no_single_rev(quiet);\n+\t} else\n+\t\tshow_default();\n \treturn 0;\n }\ndiff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh\nindex e93f1b3..95244c9 100755\n--- a/t/t1503-rev-parse-verify.sh\n+++ b/t/t1503-rev-parse-verify.sh\n@@ -83,17 +83,11 @@ test_expect_success 'fails silently when using -q' '\n \ttest -z \"$(cat error)\"\n '\n \n-test_expect_success '1 no stdout output on error' '\n+test_expect_success 'no stdout output on error' '\n \ttest -z \"$(git rev-parse --verify)\" &&\n \ttest -z \"$(git rev-parse --verify foo)\" &&\n-\ttest -z \"$(git rev-parse --verify baz HEAD)\"\n-'\n-\n-test_expect_failure '2 no stdout output on error' '\n-\ttest -z \"$(git rev-parse --verify HEAD bar)\"\n-'\n-\n-test_expect_failure '3 no stdout output on error' '\n+\ttest -z \"$(git rev-parse --verify baz HEAD)\" &&\n+\ttest -z \"$(git rev-parse --verify HEAD bar)\" &&\n \ttest -z \"$(git rev-parse --verify $HASH2 HEAD)\"\n '\n \n-- \n1.5.5.1.347.g779f4\n"}]}