{"thread":{"id":"13423","subject":"[PATCH] gitk: Allow toggling of checkboxes by clicking on the label","startedAt":"2008-05-07T22:43:39Z","lastAt":"2008-05-07T22:43:39Z","messageCount":1,"participants":["Jean-Luc Herren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"76332","messageId":"4822309B.9010303@gmx.ch","threadId":"13423","inReplyTo":null,"subject":"[PATCH] gitk: Allow toggling of checkboxes by clicking on the label","fromName":"Jean-Luc Herren","fromEmail":"jlh@gmx.ch","sentAt":"2008-05-07T22:43:39Z","receivedAt":"2008-05-07T22:43:39Z","isPatch":true,"sender":{"key":"jlh@gmx.ch","avatar":null},"body":"\nSigned-off-by: Jean-Luc Herren <jlh@gmx.ch>\n---\nI hope this makes any sense, since I do not know any tcl/tk at all.  I\nthink being able to click on the label of checkboxes is good manner,\nsince otherwise you have to click into a fairly small area.  However,\nthis patch unfortunately also reduces the size of the checkbox itself,\nproably because it adapts itself to the small optionfont.  I don't know\nhow to fix this other than increasing the size of optionfont, so I'll\nlet someone else do this, if this is desired.\n\n gitk-git/gitk |   24 ++++++++++++------------\n 1 files changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 9a4d9c4..ef8dcc0 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -8015,14 +8015,14 @@ proc doprefs {} {\n     spinbox $top.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct\n     grid x $top.maxpctl $top.maxpct -sticky w\n     frame $top.showlocal\n-    label $top.showlocal.l -text [mc \"Show local changes\"] -font optionfont\n-    checkbutton $top.showlocal.b -variable showlocalchanges\n-    pack $top.showlocal.b $top.showlocal.l -side left\n+    checkbutton $top.showlocal.b -variable showlocalchanges \\\n+\t-text [mc \"Show local changes\"] -font optionfont\n+    pack $top.showlocal.b -side left\n     grid x $top.showlocal -sticky w\n     frame $top.autoselect\n-    label $top.autoselect.l -text [mc \"Auto-select SHA1\"] -font optionfont\n-    checkbutton $top.autoselect.b -variable autoselect\n-    pack $top.autoselect.b $top.autoselect.l -side left\n+    checkbutton $top.autoselect.b -variable autoselect \\\n+\t-text [mc \"Auto-select SHA1\"] -font optionfont\n+    pack $top.autoselect.b -side left\n     grid x $top.autoselect -sticky w\n \n     label $top.ddisp -text [mc \"Diff display options\"]\n@@ -8031,14 +8031,14 @@ proc doprefs {} {\n     spinbox $top.tabstop -from 1 -to 20 -width 4 -textvariable tabstop\n     grid x $top.tabstopl $top.tabstop -sticky w\n     frame $top.ntag\n-    label $top.ntag.l -text [mc \"Display nearby tags\"] -font optionfont\n-    checkbutton $top.ntag.b -variable showneartags\n-    pack $top.ntag.b $top.ntag.l -side left\n+    checkbutton $top.ntag.b -variable showneartags \\\n+\t-text [mc \"Display nearby tags\"] -font optionfont\n+    pack $top.ntag.b -side left\n     grid x $top.ntag -sticky w\n     frame $top.ldiff\n-    label $top.ldiff.l -text [mc \"Limit diffs to listed paths\"] -font optionfont\n-    checkbutton $top.ldiff.b -variable limitdiffs\n-    pack $top.ldiff.b $top.ldiff.l -side left\n+    checkbutton $top.ldiff.b -variable limitdiffs \\\n+\t-text [mc \"Limit diffs to listed paths\"] -font optionfont\n+    pack $top.ldiff.b -side left\n     grid x $top.ldiff -sticky w\n \n     label $top.cdisp -text [mc \"Colors: press to choose\"]\n-- \n1.5.5.1\n"}]}