{"thread":{"id":"13326","subject":"[PATCH] cvsimport: always pass user data to \"system\" as a list","startedAt":"2008-04-30T04:36:14Z","lastAt":"2008-04-30T07:30:42Z","messageCount":2,"participants":["Jeff King","Nigel Magnay"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"75630","messageId":"20080430043614.GA31019@sigill.intra.peff.net","threadId":"13326","inReplyTo":null,"subject":"[PATCH] cvsimport: always pass user data to \"system\" as a list","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-04-30T04:36:14Z","receivedAt":"2008-04-30T04:36:14Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"This avoids invoking the shell. Not only is it faster, but\nit prevents the possibility of interpreting our arguments in\nthe shell.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nNigel reported a problem with a CVS branch that had '(' in the name. No\nreport yet on whether this fixes it, but it should be done regardless.\n\nI checked over git-cvsimport.perl, and this was the only instance I\nfound.\n\n git-cvsimport.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsimport.perl b/git-cvsimport.perl\nindex 95c5eec..bdac5d5 100755\n--- a/git-cvsimport.perl\n+++ b/git-cvsimport.perl\n@@ -772,7 +772,7 @@ sub commit {\n \twaitpid($pid,0);\n \tdie \"Error running git-commit-tree: $?\\n\" if $?;\n \n-\tsystem(\"git-update-ref $remote/$branch $cid\") == 0\n+\tsystem('git-update-ref', \"$remote/$branch\", $cid) == 0\n \t\tor die \"Cannot write branch $branch for update: $!\\n\";\n \n \tif ($tag) {\n-- \n1.5.5.1.178.gc1eb9.dirty\n"},{"id":"75647","messageId":"320075ff0804300030q227cee39w28bfb8456a97995f@mail.gmail.com","threadId":"13326","inReplyTo":"20080430043614.GA31019@sigill.intra.peff.net","subject":"Re: [PATCH] cvsimport: always pass user data to \"system\" as a list","fromName":"Nigel Magnay","fromEmail":"nigel.magnay@gmail.com","sentAt":"2008-04-30T07:30:42Z","receivedAt":"2008-04-30T07:30:42Z","isPatch":true,"sender":{"key":"nigel.magnay@gmail.com","avatar":"https://gravatar.com/avatar/d85cf38287bef3a8e4fa02358d2756d7589f8676c5eeb881ce2f6d731e4526c3?d=mp&s=160"},"body":"This fixed my import problem - thanks for the swift identification (my\nperl isn't so hot so it scared me :) )\n\nOn Wed, Apr 30, 2008 at 5:36 AM, Jeff King <peff@peff.net> wrote:\n> This avoids invoking the shell. Not only is it faster, but\n>  it prevents the possibility of interpreting our arguments in\n>  the shell.\n>\n>  Signed-off-by: Jeff King <peff@peff.net>\n>  ---\n>  Nigel reported a problem with a CVS branch that had '(' in the name. No\n>  report yet on whether this fixes it, but it should be done regardless.\n>\n>  I checked over git-cvsimport.perl, and this was the only instance I\n>  found.\n>\n>   git-cvsimport.perl |    2 +-\n>   1 files changed, 1 insertions(+), 1 deletions(-)\n>\n>  diff --git a/git-cvsimport.perl b/git-cvsimport.perl\n>  index 95c5eec..bdac5d5 100755\n>  --- a/git-cvsimport.perl\n>  +++ b/git-cvsimport.perl\n>  @@ -772,7 +772,7 @@ sub commit {\n>         waitpid($pid,0);\n>         die \"Error running git-commit-tree: $?\\n\" if $?;\n>\n>  -       system(\"git-update-ref $remote/$branch $cid\") == 0\n>  +       system('git-update-ref', \"$remote/$branch\", $cid) == 0\n>                 or die \"Cannot write branch $branch for update: $!\\n\";\n>\n>         if ($tag) {\n>  --\n>  1.5.5.1.178.gc1eb9.dirty\n>\n>\n"}]}