{"thread":{"id":"13318","subject":"format-patch --cc and send-mail --s-o-b-cc don't play nice together","startedAt":"2008-04-29T13:57:11Z","lastAt":"2008-04-29T22:28:24Z","messageCount":4,"participants":["Bert Wesarg","Junio C Hamano","Daniel Barkalow"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"75527","messageId":"36ca99e90804290657k88710eer630898d837659f37@mail.gmail.com","threadId":"13318","inReplyTo":null,"subject":"format-patch --cc and send-mail --s-o-b-cc don't play nice together","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-04-29T13:57:11Z","receivedAt":"2008-04-29T13:57:11Z","isPatch":false,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"Hi,\n\nthe --cc option from format-patch adds a Cc: header to the mail where\nmultiple recipients are put into a new line, separated by commas.\nUnfortunately send-mail with the --signed-off-by-cc option can't parse\nthese lines.\n\nAny ideas how to solve this?\n\nRegards\nBert Wesarg\n"},{"id":"75587","messageId":"7v8wyw7349.fsf@gitster.siamese.dyndns.org","threadId":"13318","inReplyTo":"36ca99e90804290657k88710eer630898d837659f37@mail.gmail.com","subject":"Re: format-patch --cc and send-mail --s-o-b-cc don't play nice together","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-04-29T21:39:02Z","receivedAt":"2008-04-29T21:39:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Bert Wesarg\" writes:\n\n> the --cc option from format-patch adds a Cc: header to the mail where\n> multiple recipients are put into a new line, separated by commas.\n\nI am not sure if --cc ever made sense to be given to format-patch. It is\nnot a tool to send e-mails, which send-email is.\n\n> Unfortunately send-mail with the --signed-off-by-cc option can't parse\n> these lines.\n\nIsn't --signed-off-by-cc a completely unrelated feature, where it gives\ncarbon copies to people who signed off the patch? Why does the option\nneed to read from existing CC: header of the material the command is told\nto send out?\n"},{"id":"75599","messageId":"36ca99e90804291511m619c8373j5e79edab2e57f644@mail.gmail.com","threadId":"13318","inReplyTo":"7v8wyw7349.fsf@gitster.siamese.dyndns.org","subject":"Re: format-patch --cc and send-mail --s-o-b-cc don't play nice together","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-04-29T22:11:18Z","receivedAt":"2008-04-29T22:11:18Z","isPatch":false,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Tue, Apr 29, 2008 at 11:39 PM, Junio C Hamano wrote:\n> \"Bert Wesarg\" writes:\n>\n> > the --cc option from format-patch adds a Cc: header to the mail where\n> > multiple recipients are put into a new line, separated by commas.\n>\n> I am not sure if --cc ever made sense to be given to format-patch. It is\n> not a tool to send e-mails, which send-email is.\nAFAIK, this option is not in the master branch.\n\n>\n> > Unfortunately send-mail with the --signed-off-by-cc option can't parse\n> > these lines.\n>\n> Isn't --signed-off-by-cc a completely unrelated feature, where it gives\n> carbon copies to people who signed off the patch? Why does the option\n> need to read from existing CC: header of the material the command is told\n> to send out?\nNo, it scans Cc: lines (header and body) too and add these to the cc\nlist (in the body since abec100c3382f7d7b759f915a86e9773277263b6).\n\nBert\n"},{"id":"75603","messageId":"alpine.LNX.1.00.0804291756070.19665@iabervon.org","threadId":"13318","inReplyTo":"7v8wyw7349.fsf@gitster.siamese.dyndns.org","subject":"Re: format-patch --cc and send-mail --s-o-b-cc don't play nice together","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-04-29T22:28:24Z","receivedAt":"2008-04-29T22:28:24Z","isPatch":false,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Tue, 29 Apr 2008, Junio C Hamano wrote:\n\n> \"Bert Wesarg\" writes:\n> \n> > the --cc option from format-patch adds a Cc: header to the mail where\n> > multiple recipients are put into a new line, separated by commas.\n> \n> I am not sure if --cc ever made sense to be given to format-patch. It is\n> not a tool to send e-mails, which send-email is.\n\nBut part of preparing patches for e-mail submission is often figuring out \nwhere to send them. I think the common use of format-patch is to generate \nthe series, import it into some MUA (I actually append it to my \"postponed \nmessages\" mbox for Alpine), edit the messages to add any commentary needed \noutside of the commit message, and send them, going through the user's \nnormal outgoing email path. For this purpose, it makes sense to be able to \nget git to produce anything that is standard for patch submission in the \nproject, so that the user doesn't have to edit them more than necessary.\n\nI think that it would make sense for format-patch to handle \n--signed-off-by-cc itself, since this is clearly generating useful \ninformation for composing the email out of git's information about the \ncommits.\n\n> > Unfortunately send-mail with the --signed-off-by-cc option can't parse\n> > these lines.\n> \n> Isn't --signed-off-by-cc a completely unrelated feature, where it gives\n> carbon copies to people who signed off the patch? Why does the option\n> need to read from existing CC: header of the material the command is told\n> to send out?\n\nIt also Cc's people listed in Cc: lines in the commit message, which I'd \nguess is where it's getting confused. But it also makes sense that people \nmight want to determine who to send each patch to individually, put it in \nthe patch in the RFC823-compliant fashion, additionally include people in \nSigned-off-by: lines, and send the whole batch off, in which case \nsend-email would need to know how to handle existing Cc: headers which may \nbe wrapped.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"}]}