{"thread":{"id":"13314","subject":"git-send-email: Skipping - not found.","startedAt":"2008-04-28T21:15:24Z","lastAt":"2008-04-29T20:09:35Z","messageCount":3,"participants":["Timur Tabi","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"75459","messageId":"48163E6C.60104@freescale.com","threadId":"13314","inReplyTo":null,"subject":"git-send-email: Skipping - not found.","fromName":"Timur Tabi","fromEmail":"timur@freescale.com","sentAt":"2008-04-28T21:15:24Z","receivedAt":"2008-04-28T21:15:24Z","isPatch":false,"sender":{"key":"timur@freescale.com","avatar":null},"body":"When I issue this command:\n\ngit-send-email  --from Timur Tabi <timur@freescale.com> --suppress-cc=all --to\ntimur@tabi.org --smtp-server remotesmtp.freescale.net\n0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch\n\nI get this output:\n\nSkipping  - not found.\n0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch\nOK. Log says:\nServer: remotesmtp.freescale.net\nMAIL FROM:<timur@freescale.com>\nRCPT TO:<timur@tabi.org>\nFrom: Timur Tabi <timur@freescale.com>\nTo: timur@tabi.org\nSubject: [PATCH] Update CS4270 driver to ASoC V2\nDate: Mon, 28 Apr 2008 16:13:34 -0500\nMessage-Id: <1209417214-17376-1-git-send-email-timur@freescale.com>\nX-Mailer: git-send-email 1.5.5\n\nResult: 250 2.0.0 m3SLDY4k005131 Message accepted for delivery\n\n\nI don't know enough about Perl to debug this, but I presume the problem is in\nthis code:\n\nfor my $f (@ARGV) {\n\tif (-d $f) {\n\t\topendir(DH,$f)\n\t\t\tor die \"Failed to opendir $f: $!\";\n\n\t\tpush @files, grep { -f $_ } map { +$f . \"/\" . $_ }\n\t\t\t\tsort readdir(DH);\n\n\t} elsif (-f $f) {\n\t\tpush @files, $f;\n\n\t} else {\n\t\tprint STDERR \"Skipping $f - not found.\\n\";\n\t}\n}\n\nMy guess is that \"$f\", at some point, is an empty string or a blank space.\n\n-- \nTimur Tabi\nLinux kernel developer at Freescale\n"},{"id":"75566","messageId":"20080429200619.GA20509@sigill.intra.peff.net","threadId":"13314","inReplyTo":"48163E6C.60104@freescale.com","subject":"Re: git-send-email: Skipping - not found.","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-04-29T20:06:19Z","receivedAt":"2008-04-29T20:06:19Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Apr 28, 2008 at 04:15:24PM -0500, Timur Tabi wrote:\n\n> When I issue this command:\n> \n> git-send-email  --from Timur Tabi <timur@freescale.com> --suppress-cc=all --to\n> timur@tabi.org --smtp-server remotesmtp.freescale.net\n> 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch\n\nSurely that is not the command you issued, since it lacks shell quoting\naround your name and email address.\n\n> I don't know enough about Perl to debug this, but I presume the problem is in\n> this code:\n> [...]\n> for my $f (@ARGV) {\n> [...]\n> \t\tprint STDERR \"Skipping $f - not found.\\n\";\n\nYes, that is what is producing the error message. But that is the first\ntime we ever look at @ARGV, let alone modify it. So the error is almost\ncertainly caused by a blank argument being passed on the command line.\nAnd we can't debug that unless you show us the exact shell invocation\nthat was used.\n\n-Peff\n"},{"id":"75567","messageId":"4817807F.9020508@freescale.com","threadId":"13314","inReplyTo":"20080429200619.GA20509@sigill.intra.peff.net","subject":"Re: git-send-email: Skipping - not found.","fromName":"Timur Tabi","fromEmail":"timur@freescale.com","sentAt":"2008-04-29T20:09:35Z","receivedAt":"2008-04-29T20:09:35Z","isPatch":false,"sender":{"key":"timur@freescale.com","avatar":null},"body":"Jeff King wrote:\n\n>> git-send-email  --from Timur Tabi <timur@freescale.com> --suppress-cc=all --to\n>> timur@tabi.org --smtp-server remotesmtp.freescale.net\n>> 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch\n> \n> Surely that is not the command you issued, since it lacks shell quoting\n> around your name and email address.\n\nYou're right.  It's the output from an \"echo\" command in a shell script, which\nlikes to remove quotation marks.  I keep forgetting that it does that.\n\n> Yes, that is what is producing the error message. But that is the first\n> time we ever look at @ARGV, let alone modify it. So the error is almost\n> certainly caused by a blank argument being passed on the command line.\n\nRight again!  I did a more through check of the command-line arguments, and I am\nsending '' as one argument on the command line.\n\nI just rewrote my script so that it doesn't ever send a null argument.  Thanks\nfor the help.\n\n-- \nTimur Tabi\nLinux kernel developer at Freescale\n"}]}