{"thread":{"id":"13224","subject":"[PATCH] archive.c: format_subst - fixed bogus argument to memchr","startedAt":"2008-04-23T00:24:21Z","lastAt":"2008-04-23T15:54:37Z","messageCount":3,"participants":["Ariel Badichi","René Scharfe"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"75024","messageId":"87od81peog.fsf@sneeze.site","threadId":"13224","inReplyTo":null,"subject":"[PATCH] archive.c: format_subst - fixed bogus argument to memchr","fromName":"Ariel Badichi","fromEmail":"abadichi@bezeqint.net","sentAt":"2008-04-23T00:24:21Z","receivedAt":"2008-04-23T00:24:21Z","isPatch":true,"sender":{"key":"abadichi@bezeqint.net","avatar":null},"body":"\nAlso removed a superfluous test.\n\nSigned-off-by: Ariel Badichi <abadichi@bezeqint.net>\n---\n archive.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/archive.c b/archive.c\nindex fb159fe..7a32c19 100644\n--- a/archive.c\n+++ b/archive.c\n@@ -16,9 +16,9 @@ static void format_subst(const struct commit *commit,\n \t\tconst char *b, *c;\n \n \t\tb = memmem(src, len, \"$Format:\", 8);\n-\t\tif (!b || src + len < b + 9)\n+\t\tif (!b)\n \t\t\tbreak;\n-\t\tc = memchr(b + 8, '$', len - 8);\n+\t\tc = memchr(b + 8, '$', (src + len) - b - 8);\n \t\tif (!c)\n \t\t\tbreak;\n \n-- \n1.5.5.1.57.g5909c\n"},{"id":"75051","messageId":"87y775nyvf.fsf@sneeze.site","threadId":"13224","inReplyTo":"87od81peog.fsf@sneeze.site","subject":"Re: [PATCH] archive.c: format_subst - fixed bogus argument to memchr","fromName":"Ariel Badichi","fromEmail":"abadichi@bezeqint.net","sentAt":"2008-04-23T01:28:20Z","receivedAt":"2008-04-23T01:28:20Z","isPatch":true,"sender":{"key":"abadichi@bezeqint.net","avatar":null},"body":"Ariel Badichi <abadichi@bezeqint.net> writes:\n\nArf.  Sorry about the duplicates.\n\nAriel\n"},{"id":"75070","messageId":"480F5BBD.8090101@lsrfire.ath.cx","threadId":"13224","inReplyTo":"87od81peog.fsf@sneeze.site","subject":"Re: [PATCH] archive.c: format_subst - fixed bogus argument to memchr","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2008-04-23T15:54:37Z","receivedAt":"2008-04-23T15:54:37Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Ariel Badichi schrieb:\n> Also removed a superfluous test.\n> \n> Signed-off-by: Ariel Badichi <abadichi@bezeqint.net>\n> ---\n>  archive.c |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/archive.c b/archive.c\n> index fb159fe..7a32c19 100644\n> --- a/archive.c\n> +++ b/archive.c\n> @@ -16,9 +16,9 @@ static void format_subst(const struct commit *commit,\n>  \t\tconst char *b, *c;\n>  \n>  \t\tb = memmem(src, len, \"$Format:\", 8);\n> -\t\tif (!b || src + len < b + 9)\n> +\t\tif (!b)\n>  \t\t\tbreak;\n\nOK.\n\n> -\t\tc = memchr(b + 8, '$', len - 8);\n> +\t\tc = memchr(b + 8, '$', (src + len) - b - 8);\n>  \t\tif (!c)\n>  \t\t\tbreak;\n\nOuch.  Perhaps rearranging it to \"len - (b - src) - 8\" would make it a\nlittle easier to read?  Anyway, thanks and:\n\nAcked-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n"}]}