{"thread":{"id":"13217","subject":"Re: [PATCH] git_blame2: fix rendering on Firefox 3.0b5","startedAt":"2008-04-22T17:05:40Z","lastAt":"2008-04-22T18:45:31Z","messageCount":3,"participants":["Jakub Narebski","Steven Walter"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"74986","messageId":"200804221905.41963.jnareb@gmail.com","threadId":"13217","inReplyTo":"1208821391-7895-1-git-send-email-stevenrwalter@gmail.com","subject":"Re: [PATCH] git_blame2: fix rendering on Firefox 3.0b5","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-04-22T17:05:40Z","receivedAt":"2008-04-22T17:05:40Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, 22 April 2008, stevenrwalter@gmail.com wrote:\n> From: Steven Walter \n> \n> Using variably-sized rows and rowspan does not render correctly with\n> Firefox 3.0b5. Instead, make each row have the same number of cells.\n\nBeta version of Firefox doesn't correctly render perfectly valid HTML;\nmore, the way rowspan was meanto to be used, see example in\n\n http://www.w3.org/TR/html401/struct/tables.html#h-11.2.6.1\n (subsection \"Cells that span several rows or columns\" in HTML 4.01)\n\nand you want gitweb to generate invalid HTML?\n\nFirefox 3.0b5 doesn't render, for a beta version, is not a valid\nreason for me.\n\nP.S. I don't know / remember who wrote the code in question...\n-- \nJakub Narebski\nPoland\n"},{"id":"74995","messageId":"e06498070804221046j5b9d4edbwe798ddb44f4fecf8@mail.gmail.com","threadId":"13217","inReplyTo":"200804221905.41963.jnareb@gmail.com","subject":"Re: [PATCH] git_blame2: fix rendering on Firefox 3.0b5","fromName":"Steven Walter","fromEmail":"stevenrwalter@gmail.com","sentAt":"2008-04-22T17:46:45Z","receivedAt":"2008-04-22T17:46:45Z","isPatch":true,"sender":{"key":"stevenrwalter@gmail.com","avatar":"https://avatars.githubusercontent.com/u/79127?v=4"},"body":"On Tue, Apr 22, 2008 at 1:05 PM, Jakub Narebski wrote:\n> On Tue, 22 April 2008, stevenrwalter@gmail.com wrote:\n> > Using variably-sized rows and rowspan does not render correctly with\n> > Firefox 3.0b5. Instead, make each row have the same number of cells.\n>\n> Beta version of Firefox doesn't correctly render perfectly valid HTML;\n> more, the way rowspan was meanto to be used, see example in\n>\n> http://www.w3.org/TR/html401/struct/tables.html#h-11.2.6.1\n> (subsection \"Cells that span several rows or columns\" in HTML 4.01)\n>\n> and you want gitweb to generate invalid HTML?\n\nWhat's invalid about the way my patch generated HTML? It renders\ncorrectly on both FF2 and FF3. It may have been fully correct before,\nbut is it any less correct now?\n\nConversely, I will also file a bug with Firefox regarding it's\napparently-broken handling of rowspan.\n-- \n-Steven Walter \n"},{"id":"75002","messageId":"200804222045.32416.jnareb@gmail.com","threadId":"13217","inReplyTo":"e06498070804221046j5b9d4edbwe798ddb44f4fecf8@mail.gmail.com","subject":"Re: [PATCH] git_blame2: fix rendering on Firefox 3.0b5","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-04-22T18:45:31Z","receivedAt":"2008-04-22T18:45:31Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, 22 April 2008, Steven Walter wrote:\n> On Tue, Apr 22, 2008 at 1:05 PM, Jakub Narebski wrote:\n>> On Tue, 22 April 2008, stevenrwalter@gmail.com wrote:\n>>>\n>>> Using variably-sized rows and rowspan does not render correctly with\n>>> Firefox 3.0b5. Instead, make each row have the same number of cells.\n>>\n>> Beta version of Firefox doesn't correctly render perfectly valid HTML;\n>> more, the way rowspan was meanto to be used, see example in\n>>\n>> http://www.w3.org/TR/html401/struct/tables.html#h-11.2.6.1\n>> (subsection \"Cells that span several rows or columns\" in HTML 4.01)\n>>\n>> and you want gitweb to generate invalid HTML?\n> \n> What's invalid about the way my patch generated HTML? It renders\n> correctly on both FF2 and FF3.\n\nThe fact that HTML is valid or not is not dependent on the fact that\nsome web browser, or some beta version of web browser (which can have\nbugs), renders it correctly or not. You check if HTML is valid against\nHTML specification, e.g. using one of online HTML validators, including\nW3C Validator or WDG Validator.\n\n> It may have been fully correct before, but is it any less correct now?\n\nThe idea is that enlarged cell (either via rowspan, or via colspan),\ntakes place / pushes out other cells. Se the ASCII-art diagram (to be\nviewed using fixed-width, non-proportinal font) below:\n\n |-----|-----|\n | A | B | A B \n | |-----|\n | | C | C \n |-----|-----|\n \nSee example in provided link to HTML specification. It is natural way\nof writing HTML table with cell spanning multiple rows.\n\n> Conversely, I will also file a bug with Firefox regarding it's\n> apparently-broken handling of rowspan.\n\nIf handling of rowspan differs from handling colspan with respect to\nvariable number of cells in row / column, then it is certainly a bug.\nGitweb don't use colspan beside row spanning whole table, so you\nwouldn't detect it.\n\n\nAll said, the fact that beta version of a browser doesn't render\ngitweb correctly, while HTML is correct and follows examples in\nHTML specification, is not a reason to change gitweb: it is reason\nto file bug report, and try newer version.\n\nIf some popular browser had trouble rendering some complicated HTML\ncode, we could think of changing gitweb.\n\nP.S. I have dug your original letter from spam folder on my GMail\naccount, and as far as I can see (reading via GMane NNTP / news\ninterface) it didn't appear on git mailing list either, probably\nbecause of VGER antispam filter.\n\nP.P.S. All that aside your commit message needs improvements.\nFirst line (summary line) should IMHO start with \"gitweb: \",\nnot \"git_blame2\", and tell _what_ was fixed.\n-- \nJakub Narebski\nPoland\n"}]}