{"thread":{"id":"13198","subject":"git-gui hangs on read","startedAt":"2008-04-21T14:23:03Z","lastAt":"2008-04-25T06:45:40Z","messageCount":12,"participants":["Benjamin Collins","Shawn O. Pearce","Gustaf Hendeby"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"74873","messageId":"b3889dff0804210723s620363fdscba43c79dbb62d55@mail.gmail.com","threadId":"13198","inReplyTo":null,"subject":"git-gui hangs on read","fromName":"Benjamin Collins","fromEmail":"ben.collins@acm.org","sentAt":"2008-04-21T14:23:03Z","receivedAt":"2008-04-21T14:23:03Z","isPatch":false,"sender":{"key":"ben.collins@acm.org","avatar":"https://gravatar.com/avatar/64b64ab02b075e25a237875776cce945a70e2e6fd16253e4ff3d4024fdd00346?d=mp&s=160"},"body":"I just upgraded a few machines (RHEL 4.4) to the latest stable, and\ngit-gui stopped working. It just hangs forever if it's in a git\nrepository. If it's not in a repository, it will open up the dialog\nthat lets you create or open a repository. I'm not sure what's going\non, but here's the tail end of the strace -f:\n\n[pid 16903] open(\"/usr/share/aspell/standard.kbd\", O_RDONLY) = 3\n[pid 16903] fstat(3, {st_mode=S_IFREG|0644, st_size=100, ...}) = 0\n[pid 16903] mmap(NULL, 4096, PROT_READ|PROT_WRITE,\nMAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2a983ce000\n[pid 16903] read(3, \"# Standard keyboard data file\\n\\nq\"..., 4096) = 100\n[pid 16903] read(3, \"\", 4096) = 0\n[pid 16903] close(3) = 0\n[pid 16903] munmap(0x2a983ce000, 4096) = 0\n[pid 16903] fstat(1, {st_mode=S_IFIFO|0600, st_size=0, ...}) = 0\n[pid 16903] mmap(NULL, 4096, PROT_READ|PROT_WRITE,\nMAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2a983ce000\n[pid 16903] write(1, \"@(#) International Ispell Versio\"..., 68 \n[pid 16897] <... read resumed> \"@(#) International Ispell Versio\"..., 4096) = 68\n[pid 16903] <... write resumed> ) = 68\n[pid 16903] fstat(0, {st_mode=S_IFIFO|0600, st_size=0, ...}) = 0\n[pid 16903] mmap(NULL, 4096, PROT_READ|PROT_WRITE,\nMAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2a983cf000\n[pid 16903] read(0, \n[pid 16897] write(5, \"!\\n$$cr master\\n\", 14) = 14\n[pid 16903] <... read resumed> \"!\\n$$cr master\\n\", 4096) = 14\n[pid 16897] read(6, \n[pid 16903] read(0,\n\nHas anyone seen this before? I wanted to get some other eyeballs on\nthis before I dive into this rabbit hole.\n\n-- \nBenjamin A. Collins \n"},{"id":"74885","messageId":"b3889dff0804211405r6f477f3w3216670c91c4fb9a@mail.gmail.com","threadId":"13198","inReplyTo":"b3889dff0804210723s620363fdscba43c79dbb62d55@mail.gmail.com","subject":"Re: git-gui hangs on read","fromName":"Benjamin Collins","fromEmail":"aggieben@gmail.com","sentAt":"2008-04-21T21:05:20Z","receivedAt":"2008-04-21T21:05:20Z","isPatch":false,"sender":{"key":"aggieben@gmail.com","avatar":"https://gravatar.com/avatar/28fe19679c681bd9e42efa676b04199512aab92373ebc94e67537e14663b8d8a?d=mp&s=160"},"body":"On Mon, Apr 21, 2008 at 9:23 AM, Benjamin Collins wrote:\n> I just upgraded a few machines (RHEL 4.4) to the latest stable, and\n> git-gui stopped working. It just hangs forever if it's in a git\n> repository.\n\nStill don't know what the deal is (no time to investigate, yet), but\n1.5.4 doesn't have this issue.\n\n-- \nBenjamin A. Collins \n"},{"id":"74893","messageId":"20080422001311.GS29771@spearce.org","threadId":"13198","inReplyTo":"b3889dff0804210723s620363fdscba43c79dbb62d55@mail.gmail.com","subject":"Re: git-gui hangs on read","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-22T00:13:11Z","receivedAt":"2008-04-22T00:13:11Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Benjamin Collins wrote:\n> I just upgraded a few machines (RHEL 4.4) to the latest stable, and\n> git-gui stopped working. It just hangs forever if it's in a git\n> repository.\n...\n> [pid 16903] write(1, \"@(#) International Ispell Versio\"..., 68 \n> [pid 16897] <... read resumed> \"@(#) International Ispell Versio\"..., 4096) = 68\n> [pid 16903] <... write resumed> ) = 68\n> [pid 16903] fstat(0, {st_mode=S_IFIFO|0600, st_size=0, ...}) = 0\n> [pid 16903] mmap(NULL, 4096, PROT_READ|PROT_WRITE,\n> MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2a983cf000\n> [pid 16903] read(0, \n> [pid 16897] write(5, \"!\\n$$cr master\\n\", 14) = 14\n> [pid 16903] <... read resumed> \"!\\n$$cr master\\n\", 4096) = 14\n> [pid 16897] read(6, \n> [pid 16903] read(0,\n> \n> Has anyone seen this before?\n\nNope. This was a new feature of git-gui 0.10; we now launch an\naspell session in the background via a bi-directional pipe and\nuse it to spell check the commit message area on the fly. The\nreason Git 1.5.4 doesn't have this problem is because it ships\nwith git-gui 0.9.x, which doesn't have this spell check.\n\nI'm not sure why your system is hanging. I've used git-gui 0.10\non Mac OS 10.4, 10.5 and Windows without any issues for many weeks\nprior to the 1.5.5 release. Doesn't mean there isn't possibly\nsomething wrong here, I just had thought this was pretty stable\ncode at this point.\n\n>From the strace it looks like your aspell is not giving us a\nreply to the \"$$cr master\" command. What does this give you?\n\n\taspell --mode=none --encoding=UTF-8 pipe < wrote:\n> From the strace it looks like your aspell is not giving us a\n> reply to the \"$$cr master\" command. What does this give you?\n>\n> aspell --mode=none --encoding=UTF-8 pipe < !\n> $$cr master\n> EOF\n>\n> --\n> Shawn.\n\nResponse:\n\n$ aspell --mode=none --encoding=UTF-8 pipe < !\n> $$cr master\n> EOF\n@(#) International Ispell Version 3.1.20 (but really Aspell 0.50.5)\n& cr 70 5: Cr, cry, RC, CPR, CRT, Car, car, ctr, cur, CT, Ct, ct, C, R, c, r, Ce\n, cir, Gr, Jr, Kr, gr, qr, NCR, OCR, VCR, CA, CO, Ca, Co, Cu, RR, ca, cc, ck, co\n, cu, cw, yr, BR, Br, CB, CD, CF, CV, CZ, Cb, Cd, Cf, Cl, Cm, Cs, Dr, Fr, HR, Lr\n, Mr, PR, Pr, Sr, Zr, cf, cg, cl, cm, cs, fr, hr, pr, tr\n\n$\n\n\n-- \nBenjamin A. Collins \n"},{"id":"75019","messageId":"20080422232530.GK29771@spearce.org","threadId":"13198","inReplyTo":"b3889dff0804220634u58a5ed21yf8a4f369471c6534@mail.gmail.com","subject":"Re: git-gui hangs on read","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-22T23:25:30Z","receivedAt":"2008-04-22T23:25:30Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Benjamin Collins wrote:\n> On Mon, Apr 21, 2008 at 7:13 PM, Shawn O. Pearce wrote:\n> > From the strace it looks like your aspell is not giving us a\n> > reply to the \"$$cr master\" command. What does this give you?\n> \n> $ aspell --mode=none --encoding=UTF-8 pipe < > !\n> > $$cr master\n> > EOF\n> @(#) International Ispell Version 3.1.20 (but really Aspell 0.50.5)\n> & cr 70 5: Cr, cry, RC, CPR, CRT, Car, car, ctr, cur, CT, Ct, ct, C, R, c, r, Ce\n> , cir, Gr, Jr, Kr, gr, qr, NCR, OCR, VCR, CA, CO, Ca, Co, Cu, RR, ca, cc, ck, co\n> , cu, cw, yr, BR, Br, CB, CD, CF, CV, CZ, Cb, Cd, Cf, Cl, Cm, Cs, Dr, Fr, HR, Lr\n> , Mr, PR, Pr, Sr, Zr, cf, cg, cl, cm, cs, fr, hr, pr, tr\n> \n\nAwww hell. I think I see two issues. The first is $$ maybe\nwas expanded by your shell so aspell didn't see it as a command?\nI should have used <<'EOF' to avoid that, but I uh, forgot.\n\nCan you upgrade aspell to 0.60.5? Everywhere that I have used\ngit-gui 0.10 that's the version I have had available. I wonder\nif 0.50.5 has an issue here, or just doesn't support the \"$$cr\"\ncommand I was trying to use. In which case I can try to make\ngit-gui 0.10.2 detect the aspell version and avoid using $$cr\nif its an old version.\n\n-- \nShawn.\n"},{"id":"75046","messageId":"480EF84A.4020308@isy.liu.se","threadId":"13198","inReplyTo":"20080422232530.GK29771@spearce.org","subject":"Re: git-gui hangs on read","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-04-23T08:50:18Z","receivedAt":"2008-04-23T08:50:18Z","isPatch":false,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"On 04/23/2008 01:25 AM, Shawn O. Pearce wrote:\n> Benjamin Collins wrote:\n>> On Mon, Apr 21, 2008 at 7:13 PM, Shawn O. Pearce wrote:\n>>> From the strace it looks like your aspell is not giving us a\n>>> reply to the \"$$cr master\" command. What does this give you?\n>> $ aspell --mode=none --encoding=UTF-8 pipe <>> !\n>>> $$cr master\n>>> EOF\n>> @(#) International Ispell Version 3.1.20 (but really Aspell 0.50.5)\n>> & cr 70 5: Cr, cry, RC, CPR, CRT, Car, car, ctr, cur, CT, Ct, ct, C, R, c, r, Ce\n>> , cir, Gr, Jr, Kr, gr, qr, NCR, OCR, VCR, CA, CO, Ca, Co, Cu, RR, ca, cc, ck, co\n>> , cu, cw, yr, BR, Br, CB, CD, CF, CV, CZ, Cb, Cd, Cf, Cl, Cm, Cs, Dr, Fr, HR, Lr\n>> , Mr, PR, Pr, Sr, Zr, cf, cg, cl, cm, cs, fr, hr, pr, tr\n>>\n> \n> Awww hell. I think I see two issues. The first is $$ maybe\n> was expanded by your shell so aspell didn't see it as a command?\n> I should have used <<'EOF' to avoid that, but I uh, forgot.\n> \n> Can you upgrade aspell to 0.60.5? Everywhere that I have used\n> git-gui 0.10 that's the version I have had available. I wonder\n> if 0.50.5 has an issue here, or just doesn't support the \"$$cr\"\n> command I was trying to use. In which case I can try to make\n> git-gui 0.10.2 detect the aspell version and avoid using $$cr\n> if its an old version.\n> \n\nHi!\n\nI just ran into the same/similar problem using the latest msysGit git \nversion on Windows XP.\n\nI have aspell 0.50.3 alpha installed on my laptop, and that seems to be \nbasically up to date for the Windows port of aspell. Is there any way \nto get around this problem?\n\n/Gustaf\n"},{"id":"75065","messageId":"b3889dff0804230716n1b5dde1ctb7b0c1dd83f2d1ff@mail.gmail.com","threadId":"13198","inReplyTo":"480EF84A.4020308@isy.liu.se","subject":"Re: git-gui hangs on read","fromName":"Benjamin Collins","fromEmail":"ben.collins@acm.org","sentAt":"2008-04-23T14:16:39Z","receivedAt":"2008-04-23T14:16:39Z","isPatch":false,"sender":{"key":"ben.collins@acm.org","avatar":"https://gravatar.com/avatar/64b64ab02b075e25a237875776cce945a70e2e6fd16253e4ff3d4024fdd00346?d=mp&s=160"},"body":"On Wed, Apr 23, 2008 at 3:50 AM, Gustaf Hendeby wrote:\n\n> I have aspell 0.50.3 alpha installed on my laptop, and that seems to be\n> basically up to date for the Windows port of aspell. Is there any way to\n> get around this problem?\n>\n> /Gustaf\n>\n\nWhat I have done for now is to comment out the line in gui-gui that\ndoes the lappend on spell_cmd, near the end.\n\nSorry for the dupe.\n\n-- \nBenjamin A. Collins \n"},{"id":"75067","messageId":"480F4C6E.9070400@isy.liu.se","threadId":"13198","inReplyTo":"b3889dff0804230716n1b5dde1ctb7b0c1dd83f2d1ff@mail.gmail.com","subject":"Re: git-gui hangs on read","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-04-23T14:49:18Z","receivedAt":"2008-04-23T14:49:18Z","isPatch":false,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"On 04/23/2008 04:16 PM, Benjamin Collins wrote:\n> What I have done for now is to comment out the line in gui-gui that\n> does the lappend on spell_cmd, near the end.\n\nThanks!\n\n/Gustaf\n"},{"id":"75123","messageId":"20080424010015.GS29771@spearce.org","threadId":"13198","inReplyTo":"480F4C6E.9070400@isy.liu.se","subject":"Re: git-gui hangs on read","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-24T01:00:15Z","receivedAt":"2008-04-24T01:00:15Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Gustaf Hendeby wrote:\n> On 04/23/2008 04:16 PM, Benjamin Collins wrote:\n> >What I have done for now is to comment out the line in gui-gui that\n> >does the lappend on spell_cmd, near the end.\n\nHere's another work around that doesn't require editing the code.\nJust turn the d**n spell checker off:\n\n\tgit config --global gui.spellingdictionary none\n\nThat will keep us from evening trying to launch aspell, and since\nits global (in your ~/.gitconfig) it should default into every\nrepository you have, or create.\n\nApparently aspell 0.50 does not like git-gui. I'll have to look at\nthe version header and abort trying to use aspell if it is pre 0.60.\n\ngit-gui 0.10.2 here we come.\n\n-- \nShawn.\n"},{"id":"75142","messageId":"48102E92.3090601@isy.liu.se","threadId":"13198","inReplyTo":"20080424010015.GS29771@spearce.org","subject":"Re: git-gui hangs on read","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-04-24T06:54:10Z","receivedAt":"2008-04-24T06:54:10Z","isPatch":false,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"On 04/24/2008 03:00 AM, Shawn O. Pearce wrote:\n> Just turn the d**n spell checker off:\n> \n> \tgit config --global gui.spellingdictionary none\n> \n> That will keep us from evening trying to launch aspell, and since\n> its global (in your ~/.gitconfig) it should default into every\n> repository you have, or create.\n\nThanks, even better! Though, I can't seem to find this option (and \nother ones indicated by the source) documented anywhere. Where would be \nthe place to put such information? For git options the place seems to \nbe the git config help, but given that the git gui is maintained \nindependently the choice is less obvious to me.\n\n/Gustaf\n"},{"id":"75164","messageId":"20080425010245.GZ29771@spearce.org","threadId":"13198","inReplyTo":"48102E92.3090601@isy.liu.se","subject":"Re: git-gui hangs on read","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-25T01:02:45Z","receivedAt":"2008-04-25T01:02:45Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Gustaf Hendeby wrote:\n> On 04/24/2008 03:00 AM, Shawn O. Pearce wrote:\n> >Just turn the d**n spell checker off:\n> >\n> >\tgit config --global gui.spellingdictionary none\n> >\n> >That will keep us from evening trying to launch aspell, and since\n> >its global (in your ~/.gitconfig) it should default into every\n> >repository you have, or create.\n> \n> Thanks, even better! Though, I can't seem to find this option (and \n> other ones indicated by the source) documented anywhere. Where would be \n> the place to put such information? For git options the place seems to \n> be the git config help, but given that the git gui is maintained \n> independently the choice is less obvious to me.\n\nIndeed. The git-gui options dialog lets you select this value,\nbut you can't get into git-gui far enough to open that dialog.\n\nAs far as documenting the git-gui options, maybe they should go into\neither Documentation/git-gui.txt or into Documentation/config.txt\nin the main git.git project. The latter almost makes sense because\ngit-gui does store its preferences in the same config file, and that\nfile describes the valid keys and what they mean.\n\n-- \nShawn.\n"},{"id":"75172","messageId":"48117E14.7010505@isy.liu.se","threadId":"13198","inReplyTo":"20080425010245.GZ29771@spearce.org","subject":"Re: git-gui hangs on read","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2008-04-25T06:45:40Z","receivedAt":"2008-04-25T06:45:40Z","isPatch":false,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"On 04/25/2008 03:02 AM, Shawn O. Pearce wrote:\n> Gustaf Hendeby wrote:\n>> On 04/24/2008 03:00 AM, Shawn O. Pearce wrote:\n>>> Just turn the d**n spell checker off:\n>>>\n>>> \tgit config --global gui.spellingdictionary none\n>>>\n>>> That will keep us from evening trying to launch aspell, and since\n>>> its global (in your ~/.gitconfig) it should default into every\n>>> repository you have, or create.\n>> Thanks, even better! Though, I can't seem to find this option (and \n>> other ones indicated by the source) documented anywhere. Where would be \n>> the place to put such information? For git options the place seems to \n>> be the git config help, but given that the git gui is maintained \n>> independently the choice is less obvious to me.\n> \n> As far as documenting the git-gui options, maybe they should go into\n> either Documentation/git-gui.txt or into Documentation/config.txt\n> in the main git.git project. The latter almost makes sense because\n> git-gui does store its preferences in the same config file, and that\n> file describes the valid keys and what they mean.\n> \n\nMy first thought about the documentation was to put it in \nDocumentation/config.txt but wouldn't that be strange if someone uses a \ngit-gui other than the one bundled with the git version used? On the \nother hand, if the keys don't ever change that is not a big problem.\n\nI'll try to have a go at writing some docs, but it won't be until late \nnext week because my daytime work is killing me right now.\n\n/Gustaf\n"}]}