{"thread":{"id":"13151","subject":"gitweb: pathinfo feature breaks commitdiff/raw links","startedAt":"2008-04-17T09:23:39Z","lastAt":"2008-04-17T10:11:18Z","messageCount":3,"participants":["martin f krafft","Wincent Colaiuta"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"74625","messageId":"20080417092339.GA17016@piper.oerlikon.madduck.net","threadId":"13151","inReplyTo":null,"subject":"gitweb: pathinfo feature breaks commitdiff/raw links","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2008-04-17T09:23:39Z","receivedAt":"2008-04-17T09:23:39Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"Hello,\n\nas per suggestion in gitweb.cgi, I put the following into my\ngitweb.conf:\n\n  $feature{'pathinfo'}{'default'} = [1];\n\nThis mostly works, but James Vega recently found a corner case where\nthis is broken: the raw link of a commitdiff page, such as\n\n  http://git.madduck.net/v/code/mailplate.git?a=commitdiff;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e\n\nsuddenly becomes\n\n  http://git.madduck.net/v/ARRAY(0xbc3b70)?a=commitdiff_plain;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e\n                           ^^^^^^^^^^^^^^^\nwhen the feature is turned on. It works when it's off.\n\nI discussed this a bit on IRC, with the following bottom line:\n\n  < jengelh> if you see ARRAY... in the url, and [1] in the source\n  the wise Perl person says \"ah, of course\"\n\nUnfortunately, I am neither wise nor a Perl person, so I resort to\njust pointing this out to you and can offer to test any patches on\nthis live server.\n\nCheers,\n\n-- \nmartin | http://madduck.net/ | http://two.sentenc.es/\n \n\"it is only the modern that ever becomes old-fashioned.\" \n                                                        -- oscar wilde\n \nspamtraps: madduck.bogus@madduck.net\n"},{"id":"74627","messageId":"869CFE40-B245-4744-A9D5-0F3FA623633F@wincent.com","threadId":"13151","inReplyTo":"20080417092339.GA17016@piper.oerlikon.madduck.net","subject":"Re: gitweb: pathinfo feature breaks commitdiff/raw links","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2008-04-17T09:57:32Z","receivedAt":"2008-04-17T09:57:32Z","isPatch":false,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"El 17/4/2008, a las 11:23, martin f krafft escribió:\n> Hello,\n>\n> as per suggestion in gitweb.cgi, I put the following into my\n> gitweb.conf:\n>\n>  $feature{'pathinfo'}{'default'} = [1];\n>\n> This mostly works, but James Vega recently found a corner case where\n> this is broken: the raw link of a commitdiff page, such as\n>\n>  http://git.madduck.net/v/code/mailplate.git?a=commitdiff;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e\n>\n> suddenly becomes\n>\n>  http://git.madduck.net/v/ARRAY(0xbc3b70)?a=commitdiff_plain;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e\n>                           ^^^^^^^^^^^^^^^\n> when the feature is turned on. It works when it's off.\n>\n> I discussed this a bit on IRC, with the following bottom line:\n>\n>  < jengelh> if you see ARRAY... in the url, and [1] in the source\n>  the wise Perl person says \"ah, of course\"\n>\n> Unfortunately, I am neither wise nor a Perl person, so I resort to\n> just pointing this out to you and can offer to test any patches on\n> this live server.\n\nAre you running an older version of gitweb? One which predates 7863c61?\n\nCheers,\nWincent\n"},{"id":"74629","messageId":"20080417101118.GA26063@piper.oerlikon.madduck.net","threadId":"13151","inReplyTo":"869CFE40-B245-4744-A9D5-0F3FA623633F@wincent.com","subject":"Re: gitweb: pathinfo feature breaks commitdiff/raw links","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2008-04-17T10:11:18Z","receivedAt":"2008-04-17T10:11:18Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Wincent Colaiuta <win@wincent.com> [2008.04.17.1157 +0200]:\n> Are you running an older version of gitweb? One which predates 7863c61?\n\nYes, sorry for not including that information.\n\npiper:~/code/git> git describe 7863c61\nv1.5.4.4-10-g7863c61\n\nI run the 1.5.4.2-1 Debian backport.\n\nI assume from your answer that 1.5.4.4 fixes this issue and will\ngladly wait.\n\n-- \nmartin | http://madduck.net/ | http://two.sentenc.es/\n \n\"they redundantly repeated themselves over and over,\n incessantly without end and ad infinitum\"\n                                                             -- ibid\n \nspamtraps: madduck.bogus@madduck.net\n"}]}