{"thread":{"id":"1314","subject":"[PATCH] Deb packages should include the binaries (Try 2 - this time it actually applies)","startedAt":"2005-07-23T05:31:59Z","lastAt":"2005-07-23T05:31:59Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"6366","messageId":"7voe8u5bqo.fsf@assigned-by-dhcp.cox.net","threadId":"1314","inReplyTo":null,"subject":"[PATCH] Deb packages should include the binaries (Try 2 - this time it actually applies)","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-07-23T05:31:59Z","receivedAt":"2005-07-23T05:31:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"From: Ryan Anderson <ryan@michonline.com>\nDate: 1122011756 -0400\n\nThe Deb packages were missing a dependency on \"build install\" from the\nbinary target - this fixes that, and cleans up some inconsistencies\nelsewhere in the rulesets.\n\nTraditionally, Debian packaging uses a file called \"build-stamp\" (or\n\"install-stamp\", etc) in the main source tree.  The initial deb package\nsupport for Git tried to move this \"build-stamp\" file into the debian/\ndirectory, but some instances were missed.  That problem, however, was\nincidental - the real fix is the missing dependency mentioned above.\n\n(version 2 of this patch.  I missed an early commit in v1 that made the old\npatch impossible to apply.)\n\nSigned-off-by: Ryan Anderson <ryan@michonline.com>\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n\n debian/changelog |    8 +++++++-\n debian/control   |    2 +-\n debian/rules     |   10 +++++-----\n 3 files changed, 13 insertions(+), 7 deletions(-)\n\n469775a2f3b479cd4bbd930754e59601a7132f68\ndiff --git a/debian/changelog b/debian/changelog\n--- a/debian/changelog\n+++ b/debian/changelog\n@@ -1,5 +1,11 @@\n+git-core (0.99-1) unstable; urgency=low\n+\n+  * Update deb package support to build correctly. \n+\n+ -- Ryan Anderson <ryan@michonline.com>  Thu, 21 Jul 2005 02:03:32 -0400\n+\n git-core (0.99-0) unstable; urgency=low\n-\t\n+\n   * Initial deb package support\n \n  -- Eric Biederman <ebiederm@xmission.com>  Tue, 12 Jul 2005 10:57:51 -0600\ndiff --git a/debian/control b/debian/control\n--- a/debian/control\n+++ b/debian/control\n@@ -7,7 +7,7 @@ Standards-Version: 3.6.1\n \n Package: git-core\n Architecture: any\n-Depends: ${shlibs:Depends}, shellutils, diff, rsync, rcs\n+Depends: ${misc:Depends}, shellutils, diff, rsync, rcs\n Description: The git content addressable filesystem\n  GIT comes in two layers. The bottom layer is merely an extremely fast\n  and flexible filesystem-based database designed to store directory trees\ndiff --git a/debian/rules b/debian/rules\n--- a/debian/rules\n+++ b/debian/rules\n@@ -21,8 +21,8 @@ DESTDIR  := $(CURDIR)/debian/tmp\n DOC_DESTDIR := $(DESTDIR)/usr/share/doc/git-core/\n MAN_DESTDIR := $(DESTDIR)/$(MANDIR)\n \n-build: build-stamp\n-build-stamp:\n+build: debian/build-stamp\n+debian/build-stamp:\n \tdh_testdir\n \t$(MAKE) all doc\n \ttouch debian/build-stamp\n@@ -36,7 +36,7 @@ debian-clean:\n clean: debian-clean\n \t$(MAKE) clean\n \n-install: debian/build-stamp\n+install: build\n \tdh_testdir\n \tdh_testroot\n \tdh_clean -k \n@@ -47,9 +47,9 @@ install: debian/build-stamp\n \tmkdir -p $(DOC_DESTDIR)\n \tfind $(DOC) '(' -name '*.txt' -o -name '*.html' ')' -exec install {} $(DOC_DESTDIR) ';'\n \n-\tdh_install --sourcedir=$(DESTDIR)\n+\tdh_install --list-missing --sourcedir=$(DESTDIR)\n \n-binary:\n+binary: build install\n \tdh_testdir\n \tdh_testroot\n \tdh_installchangelogs\n"}]}