{"thread":{"id":"13108","subject":"[PATCH] gitk: Makefile/install: force permissions when installing files and dirs","startedAt":"2008-04-14T08:27:09Z","lastAt":"2008-04-14T08:27:09Z","messageCount":1,"participants":["Gerrit Pape"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"74339","messageId":"20080414082709.14951.qmail@abeaeea100406a.315fe32.mid.smarden.org","threadId":"13108","inReplyTo":null,"subject":"[PATCH] gitk: Makefile/install: force permissions when installing files and dirs","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2008-04-14T08:27:09Z","receivedAt":"2008-04-14T08:27:09Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"The msg-files msgs/*.msg used to be installed with mode 755 although\nthey're not executables.  With this commit, files are forced to be\ninstalled with mode 644, directories and executables with mode 755.\n---\n Makefile |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex f90dfab..e1b6045 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -40,9 +40,9 @@ endif\n all:: gitk-wish $(ALL_MSGFILES)\n \n install:: all\n-\t$(INSTALL) gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk\n-\t$(INSTALL) -d '$(DESTDIR_SQ)$(msgsdir_SQ)'\n-\t$(foreach p,$(ALL_MSGFILES), $(INSTALL) $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n+\t$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk\n+\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'\n+\t$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n \n uninstall::\n \t$(foreach p,$(ALL_MSGFILES), $(RM) '$(DESTDIR_SQ)$(msgsdir_SQ)'/$(notdir $p) &&) true\n-- \n1.5.5\n"}]}