{"thread":{"id":"13047","subject":"rev-list date-order not overridable","startedAt":"2008-04-10T11:43:06Z","lastAt":"2008-04-10T20:06:52Z","messageCount":2,"participants":["Jan Engelhardt","Michele Ballabio"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"74058","messageId":"alpine.LNX.1.10.0804101342090.8765@fbirervta.pbzchgretzou.qr","threadId":"13047","inReplyTo":null,"subject":"rev-list date-order not overridable","fromName":"Jan Engelhardt","fromEmail":"jengelh@computergmbh.de","sentAt":"2008-04-10T11:43:06Z","receivedAt":"2008-04-10T11:43:06Z","isPatch":false,"sender":{"key":"jengelh@computergmbh.de","avatar":null},"body":"Hi,\n\n\ngit-rev-list --topo-order (the default) can be overriden by specifying \n--date-order, but --date-order cannot be overriden by passing in \n--topo-order again. Having it work would be really nice because it \nallows extra programs to default to --date-order in some way.\n"},{"id":"74095","messageId":"200804102206.52464.barra_cuda@katamail.com","threadId":"13047","inReplyTo":"alpine.LNX.1.10.0804101342090.8765@fbirervta.pbzchgretzou.qr","subject":"[PATCH] revision.c: make --date-order overriddable","fromName":"Michele Ballabio","fromEmail":"barra_cuda@katamail.com","sentAt":"2008-04-10T20:06:52Z","receivedAt":"2008-04-10T20:06:52Z","isPatch":true,"sender":{"key":"barra_cuda@katamail.com","avatar":"https://avatars.githubusercontent.com/u/16371673?v=4"},"body":"Jan Engelhardt noticed that while --topo-order can be overridden by a\nsubsequent --date-order, the reverse was not possible. That's because\nsetup_revisions() failed to set revs->lifo properly.\n\nSigned-off-by: Michele Ballabio <barra_cuda@katamail.com>\n---\nOn Thursday 10 April 2008, Jan Engelhardt wrote:\n> git-rev-list --topo-order (the default) can be overriden by specifying \n> --date-order, but --date-order cannot be overriden by passing in \n> --topo-order again. Having it work would be really nice because it \n> allows extra programs to default to --date-order in some way.\n\nThis should do.\n\n revision.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/revision.c b/revision.c\nindex 196fedc..ffbed3f 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -1083,6 +1083,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\tif (!strcmp(arg, \"--topo-order\")) {\n+\t\t\t\trevs->lifo = 1;\n \t\t\t\trevs->topo_order = 1;\n \t\t\t\tcontinue;\n \t\t\t}\n-- \n1.5.5\n"}]}