{"thread":{"id":"13036","subject":"[PATCH] (parsecvs) avoid \"git mktag\" failure with newer git","startedAt":"2008-04-09T10:01:34Z","lastAt":"2008-04-09T10:01:34Z","messageCount":1,"participants":["Jim Meyering"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73941","messageId":"871w5fz6rl.fsf@rho.meyering.net","threadId":"13036","inReplyTo":null,"subject":"[PATCH] (parsecvs) avoid \"git mktag\" failure with newer git","fromName":"Jim Meyering","fromEmail":"jim@meyering.net","sentAt":"2008-04-09T10:01:34Z","receivedAt":"2008-04-09T10:01:34Z","isPatch":true,"sender":{"key":"jim@meyering.net","avatar":"https://avatars.githubusercontent.com/u/710630?v=4"},"body":"With recent git, parsecvs now always fails like this:\n\n  ...\n  Save:                              master *....................     1 of   269\n  Save:                              master *....................     2 of   269\n  error: char77: malformed tagger field\n  fatal: invalid tag signature file\n  git-mktag < '.git-cvs/tag-0': No such file or directory\n\nThis is due to the change that makes git's mktag perform\nstricter input validation.  parsecvs patch below.\n\n[BTW, Keith, or anyone with write access to the parsecvs repo,\n I have a few other patches, but a few I sent have gone un-applied\n and with no response for months, I'm hoping there's a maintained\n repository somewhere else.\n\n I've been using this: git://people.freedesktop.org/~keithp/parsecvs\n\n Today's failure nearly pushed me to cvs2git (aka cvs2svn\n http://cvs2svn.tigris.org/cvs2git.html), which I hear is good,\n although still pretty new.  Since this fix was easy, I'm sticking\n with parsecvs for now. ]\n\n>From 9c6ca141e82fae93ff173b87a27c118c5e87547c Mon Sep 17 00:00:00 2001\nFrom: Jim Meyering <meyering@redhat.com>\nDate: Wed, 9 Apr 2008 11:53:29 +0200\nSubject: [PATCH] avoid \"git mktag\" failure with newer git\n\n* git.c (git_mktag): Emit full tagger information, now that\ngit's mktag (since git's 5fbd0a44cfee7be96fe29b9252f34b8f1bce9ac5\non 2008-04-02) is more strict about it.\n\nSigned-off-by: Jim Meyering <meyering@redhat.com>\n---\n git.c |    6 ++++--\n 1 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/git.c b/git.c\nindex 614069d..a1828ef 100644\n--- a/git.c\n+++ b/git.c\n@@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)\n \t\t\"object %s\\n\"\n \t\t\"type commit\\n\"\n \t\t\"tag %s\\n\"\n-\t\t\"tagger %s\\n\"\n+\t\t\"tagger %s <%s> %lu +0000\\n\"\n \t\t\"\\n\",\n \t\tcommit->sha1,\n \t\tname,\n-\t\tauthor ? author->full : commit->author);\n+\t\tauthor ? author->full : commit->author,\n+\t\tauthor ? author->email : commit->author,\n+\t\tcommit->date);\n     if (rv < 1) {\n \tfprintf (stderr, \"%s: %s\\n\", filename, strerror (errno));\n \tfclose (f);\n--\n1.5.5.rc3.14.g78bf3\n"}]}