{"thread":{"id":"13003","subject":"[PATCH] test suite: remove useless TERM cruft in \"t7005-editor.sh\"","startedAt":"2008-04-06T17:08:50Z","lastAt":"2008-04-06T17:08:50Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73749","messageId":"20080406190850.e7a13c3c.chriscool@tuxfamily.org","threadId":"13003","inReplyTo":null,"subject":"[PATCH] test suite: remove useless TERM cruft in \"t7005-editor.sh\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-04-06T17:08:50Z","receivedAt":"2008-04-06T17:08:50Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"In commit 15387e32ff5116b82d3fe53df55b8c87eec83e01 I added some cruft\nto reset TERM to its previous value before the \"test_done\" at the end\nof \"t7005-editor.sh\" because otherwise \"test_done\" would have printed\nthe test result with a bad TERM env variable (this resulted in output\nwith no color on konsole).\n\nBut since commit c2116a1783a3d555d41892ae7db0dd0934d4ddf1 colored\noutput is printed in a subshell with TERM reset to its original value\nso the cruft added in my patch above is now useless.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n t/t7005-editor.sh |    4 ----\n 1 files changed, 0 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t7005-editor.sh b/t/t7005-editor.sh\nindex 6a74b3a..2d919d6 100755\n--- a/t/t7005-editor.sh\n+++ b/t/t7005-editor.sh\n@@ -4,8 +4,6 @@ test_description='GIT_EDITOR, core.editor, and stuff'\n \n . ./test-lib.sh\n \n-OLD_TERM=\"$TERM\"\n-\n for i in GIT_EDITOR core_editor EDITOR VISUAL vi\n do\n \tcat >e-$i.sh <<-EOF\n@@ -116,6 +114,4 @@ test_expect_success 'core.editor with a space' '\n \n '\n \n-TERM=\"$OLD_TERM\"\n-\n test_done\n-- \n1.5.5.rc2.20.g03f57.dirty\n"}]}