{"thread":{"id":"12964","subject":"[PATCH] git-p4: Wrong sync config filename","startedAt":"2008-04-02T08:23:00Z","lastAt":"2008-04-03T07:09:10Z","messageCount":2,"participants":["Kevin Leung","Simon Hausmann"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73540","messageId":"e66701d40804020123qb66f52fo13c32e939a7d6f75@mail.gmail.com","threadId":"12964","inReplyTo":null,"subject":"[PATCH] git-p4: Wrong sync config filename","fromName":"Kevin Leung","fromEmail":"kevinlsk@gmail.com","sentAt":"2008-04-02T08:23:00Z","receivedAt":"2008-04-02T08:23:00Z","isPatch":true,"sender":{"key":"kevinlsk@gmail.com","avatar":null},"body":"The filename should be p4-git-sync.cfg.db instead of p4-git-sync.cfg.\n\nSigned-off-by: Kevin Leung <kevinlsk@gmail.com>\n---\nI encounter this problem after submitting the changelist to Perforce.\n\nI was using Mac OS X 10.5 with Python 2.5.1. I am not sure if this patch will\nhelp others.\n\nChange 29323 submitted.\nAll changes applied!\nPerforming incremental import into refs/remotes/p4/master git branch\nDepot paths: //depot/POPCAT/\nImport destination: refs/remotes/p4/master\nImporting revision 29323 (100%)\nDo you want to rebase current HEAD from Perforce now using git-p4\nrebase? [y]es/[n]o n\nTraceback (most recent call last):\n  File \"/Users/kevin/bin/git-p4\", line 1828, in <module>\n    main()\n  File \"/Users/kevin/bin/git-p4\", line 1823, in main\n    if not cmd.run(args):\n  File \"/Users/kevin/bin/git-p4\", line 835, in run\n    os.remove(self.configFile)\nOSError: [Errno 2] No such file or directory:\n'/Users/kevin/cdc.git/popcat/.git/p4-git-sync.cfg'\n\n contrib/fast-import/git-p4 |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\nindex c80a6da..623757a 100755\n--- a/contrib/fast-import/git-p4\n+++ b/contrib/fast-import/git-p4\n@@ -796,7 +796,7 @@ class P4Submit(Command):\n                 self.logSubstitutions[tokens[0]] = tokens[1]\n\n         self.check()\n-        self.configFile = self.gitdir + \"/p4-git-sync.cfg\"\n+        self.configFile = self.gitdir + \"/p4-git-sync.cfg.db\"\n         self.config = shelve.open(self.configFile, writeback=True)\n\n         if self.firstTime:\n-- \n1.5.4.5\n"},{"id":"73578","messageId":"200804030909.11067.simon@lst.de","threadId":"12964","inReplyTo":"e66701d40804020123qb66f52fo13c32e939a7d6f75@mail.gmail.com","subject":"Re: [PATCH] git-p4: Wrong sync config filename","fromName":"Simon Hausmann","fromEmail":"simon@lst.de","sentAt":"2008-04-03T07:09:10Z","receivedAt":"2008-04-03T07:09:10Z","isPatch":true,"sender":{"key":"hausmann@kde.org","avatar":"https://gravatar.com/avatar/bc9aad4fb31dce17eb66e690e7b51fe980c62da3c225c785da35dd806b8da778?d=mp&s=160"},"body":"On Wednesday 02 April 2008 10:23:00 Kevin Leung wrote:\n> The filename should be p4-git-sync.cfg.db instead of p4-git-sync.cfg.\n>\n> Signed-off-by: Kevin Leung <kevinlsk@gmail.com>\n> ---\n> I encounter this problem after submitting the changelist to Perforce.\n>\n> I was using Mac OS X 10.5 with Python 2.5.1. I am not sure if this patch\n> will help others.\n\nThanks for the patch! Fortunately this config file is not needed anymore and I \nremoved its use alltogether a while ago, also as a result of running into \nthis problem on Mac OS X myself :). So the latest git has this resolved :)\n\n\nSimon\n\n> Change 29323 submitted.\n> All changes applied!\n> Performing incremental import into refs/remotes/p4/master git branch\n> Depot paths: //depot/POPCAT/\n> Import destination: refs/remotes/p4/master\n> Importing revision 29323 (100%)\n> Do you want to rebase current HEAD from Perforce now using git-p4\n> rebase? [y]es/[n]o n\n> Traceback (most recent call last):\n>   File \"/Users/kevin/bin/git-p4\", line 1828, in <module>\n>     main()\n>   File \"/Users/kevin/bin/git-p4\", line 1823, in main\n>     if not cmd.run(args):\n>   File \"/Users/kevin/bin/git-p4\", line 835, in run\n>     os.remove(self.configFile)\n> OSError: [Errno 2] No such file or directory:\n> '/Users/kevin/cdc.git/popcat/.git/p4-git-sync.cfg'\n>\n>  contrib/fast-import/git-p4 |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\n> index c80a6da..623757a 100755\n> --- a/contrib/fast-import/git-p4\n> +++ b/contrib/fast-import/git-p4\n> @@ -796,7 +796,7 @@ class P4Submit(Command):\n>                  self.logSubstitutions[tokens[0]] = tokens[1]\n>\n>          self.check()\n> -        self.configFile = self.gitdir + \"/p4-git-sync.cfg\"\n> +        self.configFile = self.gitdir + \"/p4-git-sync.cfg.db\"\n>          self.config = shelve.open(self.configFile, writeback=True)\n>\n>          if self.firstTime:\n\n\n"}]}