{"thread":{"id":"12961","subject":"[PATCH] t7004-tag: Skip more tests if gpg is not available.","startedAt":"2008-04-02T06:52:37Z","lastAt":"2008-04-02T06:52:37Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73535","messageId":"47F32D35.3010407@viscovery.net","threadId":"12961","inReplyTo":null,"subject":"[PATCH] t7004-tag: Skip more tests if gpg is not available.","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-04-02T06:52:37Z","receivedAt":"2008-04-02T06:52:37Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <johannes.sixt@telecom.at>\n\nThis test was already careful enough to skip signed tag tests if gpg\nis not available, but it must also skip all verify tests, even those\nthat are about non-signed tags, because they also invoke gpg.\n\nSigned-off-by: Johannes Sixt <johannes.sixt@telecom.at>\n---\n t/t7004-tag.sh |   15 ++++++++-------\n 1 files changed, 8 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\nindex 2b4c270..c4854c3 100755\n--- a/t/t7004-tag.sh\n+++ b/t/t7004-tag.sh\n@@ -579,6 +579,14 @@ test_expect_success \\\n \tgit diff expect actual\n '\n\n+# subsequent tests require gpg; check if it is available\n+gpg --version >/dev/null\n+if [ $? -eq 127 ]; then\n+\techo \"gpg not found - skipping tag signing and verification tests\"\n+\ttest_done\n+\texit\n+fi\n+\n # trying to verify annotated non-signed tags:\n\n test_expect_success \\\n@@ -601,13 +609,6 @@ test_expect_success \\\n\n # creating and verifying signed tags:\n\n-gpg --version >/dev/null\n-if [ $? -eq 127 ]; then\n-\techo \"Skipping signed tags tests, because gpg was not found\"\n-\ttest_done\n-\texit\n-fi\n-\n # As said here: http://www.gnupg.org/documentation/faqs.html#q6.19\n # the gpg version 1.0.6 didn't parse trust packets correctly, so for\n # that version, creation of signed tags using the generated key fails.\n-- \n1.5.5.rc2.861.g18c5b.dirty\n"}]}