{"thread":{"id":"12958","subject":"[PATCH] help: Add a missing OPT_END().","startedAt":"2008-04-02T03:44:31Z","lastAt":"2008-04-02T04:34:05Z","messageCount":3,"participants":["Christian Couder","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73529","messageId":"20080402034430.GA10360@coredump.intra.peff.net","threadId":"12958","inReplyTo":"20080402054741.24d95299.chriscool@tuxfamily.org","subject":"Re: [PATCH] help: Add a missing OPT_END().","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-04-02T03:44:31Z","receivedAt":"2008-04-02T03:44:31Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Apr 02, 2008 at 05:47:41AM +0200, Christian Couder wrote:\n\n> \tSome comments in \"parse-options.h\" say it is needed,\n> \tthough I did not see a crash without it.\n\nThere was no particular reason I didn't put it in; I just didn't know\nabout it. So ack from me, assuming it is supposed to be there.\n\n-Peff\n"},{"id":"73528","messageId":"20080402054741.24d95299.chriscool@tuxfamily.org","threadId":"12958","inReplyTo":null,"subject":"[PATCH] help: Add a missing OPT_END().","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-04-02T03:47:41Z","receivedAt":"2008-04-02T03:47:41Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n help.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\n\tSome comments in \"parse-options.h\" say it is needed,\n\tthough I did not see a crash without it.\n\ndiff --git a/help.c b/help.c\nindex ecaca77..10298fb 100644\n--- a/help.c\n+++ b/help.c\n@@ -30,6 +30,7 @@ static struct option builtin_help_options[] = {\n \t\t\tHELP_FORMAT_WEB),\n \tOPT_SET_INT('i', \"info\", &help_format, \"show info page\",\n \t\t\tHELP_FORMAT_INFO),\n+\tOPT_END(),\n };\n \n static const char * const builtin_help_usage[] = {\n-- \n1.5.5.rc2.6.gf58d\n"},{"id":"73531","messageId":"7vk5jgan9e.fsf@gitster.siamese.dyndns.org","threadId":"12958","inReplyTo":"20080402034430.GA10360@coredump.intra.peff.net","subject":"Re: [PATCH] help: Add a missing OPT_END().","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-04-02T04:34:05Z","receivedAt":"2008-04-02T04:34:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Wed, Apr 02, 2008 at 05:47:41AM +0200, Christian Couder wrote:\n>\n>> \tSome comments in \"parse-options.h\" say it is needed,\n>> \tthough I did not see a crash without it.\n>\n> There was no particular reason I didn't put it in; I just didn't know\n> about it. So ack from me, assuming it is supposed to be there.\n\nparse-options.c::parse_short_opt() and parse_long_opt() has this loop:\n\n\tfor (; options->type != OPTION_END; options++) {\n\t\t...\n\t}\n\nSo whatever happens to come after builtin_help_options[] may be read from\nby this loop when you do not have OPTION_END.\n"}]}