{"thread":{"id":"12896","subject":"[PATCH] Silence cpio's \"N blocks\" output when cloning locally","startedAt":"2008-03-28T06:19:46Z","lastAt":"2008-03-31T00:19:04Z","messageCount":6,"participants":["Bryan Donlan","Johannes Schindelin","Wincent Colaiuta","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73241","messageId":"1206685186-10352-1-git-send-email-bdonlan@fushizen.net","threadId":"12896","inReplyTo":null,"subject":"[PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Bryan Donlan","fromEmail":"bdonlan@fushizen.net","sentAt":"2008-03-28T06:19:46Z","receivedAt":"2008-03-28T06:19:46Z","isPatch":true,"sender":{"key":"bdonlan@fushizen.net","avatar":null},"body":"Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\" message.\nFor compatibility with operating systems which might not support GNUisms,\nthe presence of --quiet is probed for by grepping cpio's --help output.\n\nSigned-off-by: Bryan Donlan \n---\n git-clone.sh | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/git-clone.sh b/git-clone.sh\nindex e981122..2636159 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -310,6 +310,9 @@ yes)\n \t\tmkdir -p \"$GIT_DIR/objects/info\"\n \t\techo \"$repo/objects\" >>\"$GIT_DIR/objects/info/alternates\"\n \telse\n+\t\tcpio_quiet_flag=\"\"\n+\t\tcpio --help 2>&1 | grep -- --quiet >/dev/null && \\\n+\t\t\tcpio_quiet_flag=--quiet\n \t\tl= &&\n \t\tif test \"$use_local_hardlink\" = yes\n \t\tthen\n@@ -330,7 +333,8 @@ yes)\n \t\t\tfi\n \t\tfi &&\n \t\tcd \"$repo\" &&\n-\t\tfind objects -depth -print | cpio -pumd$l \"$GIT_DIR/\" || exit 1\n+\t\tfind objects -depth -print | cpio $cpio_quiet_flag -pumd$l \"$GIT_DIR/\" || \\\n+\t\t\texit 1\n \tfi\n \tgit-ls-remote \"$repo\" >\"$GIT_DIR/CLONE_HEAD\" || exit 1\n \t;;\n-- \n1.5.4.3\n"},{"id":"73254","messageId":"alpine.LSU.1.00.0803281400330.18259@racer.site","threadId":"12896","inReplyTo":"1206685186-10352-1-git-send-email-bdonlan@fushizen.net","subject":"Re: [PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-28T13:01:10Z","receivedAt":"2008-03-28T13:01:10Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 28 Mar 2008, Bryan Donlan wrote:\n\n> Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\" \n> message. For compatibility with operating systems which might not \n> support GNUisms, the presence of --quiet is probed for by grepping \n> cpio's --help output.\n\nWe have a builtin clone which is almost ready for 'next', and I think that \nthis issue would be resolved there anyway.\n\nCiao,\nDscho\n"},{"id":"73278","messageId":"2145F4A8-7C6E-4AE9-A531-026DC65417BE@wincent.com","threadId":"12896","inReplyTo":"alpine.LSU.1.00.0803281400330.18259@racer.site","subject":"Re: [PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2008-03-28T16:12:27Z","receivedAt":"2008-03-28T16:12:27Z","isPatch":true,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"El 28/3/2008, a las 14:01, Johannes Schindelin escribió:\n\n> On Fri, 28 Mar 2008, Bryan Donlan wrote:\n>\n>> Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\"\n>> message. For compatibility with operating systems which might not\n>> support GNUisms, the presence of --quiet is probed for by grepping\n>> cpio's --help output.\n>\n> We have a builtin clone which is almost ready for 'next', and I \n> think that\n> this issue would be resolved there anyway.\n\nIn any case, I'd rather see the cpio check at configure-time rather \nthan run-time.\n\nCheers,\nWincent\n"},{"id":"73279","messageId":"alpine.LSU.1.00.0803281728530.18259@racer.site","threadId":"12896","inReplyTo":"2145F4A8-7C6E-4AE9-A531-026DC65417BE@wincent.com","subject":"Re: [PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-28T16:29:36Z","receivedAt":"2008-03-28T16:29:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 28 Mar 2008, Wincent Colaiuta wrote:\n\n> El 28/3/2008, a las 14:01, Johannes Schindelin escribió:\n> \n> >On Fri, 28 Mar 2008, Bryan Donlan wrote:\n> >\n> > >Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\" \n> > >message. For compatibility with operating systems which might not \n> > >support GNUisms, the presence of --quiet is probed for by grepping \n> > >cpio's --help output.\n> >\n> >We have a builtin clone which is almost ready for 'next', and I think \n> >that this issue would be resolved there anyway.\n> \n> In any case, I'd rather see the cpio check at configure-time rather than \n> run-time.\n\nThat would have to be done via ./configure, missing out those people who \ndo not run ./configure, but just make.\n\nCiao,\nDscho\n"},{"id":"73287","messageId":"3e8340490803281159t2ecdcdd6rea502331dcf04457@mail.gmail.com","threadId":"12896","inReplyTo":"alpine.LSU.1.00.0803281728530.18259@racer.site","subject":"Re: [PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Bryan Donlan","fromEmail":"bdonlan@gmail.com","sentAt":"2008-03-28T18:59:12Z","receivedAt":"2008-03-28T18:59:12Z","isPatch":true,"sender":{"key":"bdonlan@gmail.com","avatar":null},"body":"On Fri, Mar 28, 2008 at 12:29 PM, Johannes Schindelin\n wrote:\n> Hi,\n>\n>\n> On Fri, 28 Mar 2008, Wincent Colaiuta wrote:\n>\n> > El 28/3/2008, a las 14:01, Johannes Schindelin escribió:\n> >\n> > >On Fri, 28 Mar 2008, Bryan Donlan wrote:\n> > >\n> > > >Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\"\n> > > >message. For compatibility with operating systems which might not\n> > > >support GNUisms, the presence of --quiet is probed for by grepping\n> > > >cpio's --help output.\n> > >\n> > >We have a builtin clone which is almost ready for 'next', and I think\n> > >that this issue would be resolved there anyway.\n> >\n> > In any case, I'd rather see the cpio check at configure-time rather than\n> > run-time.\n>\n> That would have to be done via ./configure, missing out those people who\n> do not run ./configure, but just make.\n\nSome distributions don't run configure either, including debian (and\nby extension, likely ubuntu). That said, if git-clone's going builtin\nanyway, we might as well wait for that :)\n"},{"id":"73387","messageId":"7v1w5rwxs7.fsf@gitster.siamese.dyndns.org","threadId":"12896","inReplyTo":"alpine.LSU.1.00.0803281728530.18259@racer.site","subject":"Re: [PATCH] Silence cpio's \"N blocks\" output when cloning locally","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-31T00:19:04Z","receivedAt":"2008-03-31T00:19:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> On Fri, 28 Mar 2008, Wincent Colaiuta wrote:\n>\n>> El 28/3/2008, a las 14:01, Johannes Schindelin escribió:\n>> \n>> >On Fri, 28 Mar 2008, Bryan Donlan wrote:\n>> >\n>> > >Pass --quiet to cpio in git-clone to hide the (confusing) \"0 blocks\" \n>> > >message. For compatibility with operating systems which might not \n>> > >support GNUisms, the presence of --quiet is probed for by grepping \n>> > >cpio's --help output.\n>> >\n>> >We have a builtin clone which is almost ready for 'next', and I think \n>> >that this issue would be resolved there anyway.\n>> \n>> In any case, I'd rather see the cpio check at configure-time rather than \n>> run-time.\n>\n> That would have to be done via ./configure, missing out those people who \n> do not run ./configure, but just make.\n\nRuntime is just fine for this case. Unlike other commands, clone is not\nsomething you run all the time. Anything more elaborate is just\noverengineered.\n"}]}