{"thread":{"id":"12841","subject":"[PATCH] Documentation: git-tag '-m' implies '-a'","startedAt":"2008-03-24T14:41:54Z","lastAt":"2008-03-25T17:13:24Z","messageCount":5,"participants":["Dirk Süsserott","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"72895","messageId":"47E7BDB2.3030304@dirk.my1.cc","threadId":"12841","inReplyTo":null,"subject":"[PATCH] Documentation: git-tag '-m' implies '-a'","fromName":"Dirk Süsserott","fromEmail":"newsletter@dirk.my1.cc","sentAt":"2008-03-24T14:41:54Z","receivedAt":"2008-03-24T14:41:54Z","isPatch":true,"sender":{"key":"newsletter@dirk.my1.cc","avatar":null},"body":"Described that '-a' is implied when '-m' or '-F' is present.\n---\n Documentation/git-tag.txt | 7 +++++++\n 1 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt\nindex b62a3d1..c22fb71 100644\n--- a/Documentation/git-tag.txt\n+++ b/Documentation/git-tag.txt\n@@ -26,6 +26,9 @@ creates a 'tag' object, and requires the tag message. \nUnless\n `-m ` or `-F ` is given, an editor is started for the user \nto type\n in the tag message.\n \n+If `-m ` or `-F ` is given and `-a`, `-s`, and `-u `\n+are absent, `-a` is implied.\n+\n Otherwise just the SHA1 object name of the commit object is\n written (i.e. a lightweight tag).\n \n@@ -68,10 +71,14 @@ OPTIONS\n Use the given tag message (instead of prompting).\n If multiple `-m` options are given, there values are\n concatenated as separate paragraphs.\n+ Implies `-a` if none of `-a`, `-s`, or `-u `\n+ is given.\n \n -F ::\n Take the tag message from the given file. Use '-' to\n read the message from the standard input.\n+ Implies `-a` if none of `-a`, `-s`, or `-u `\n+ is given.\n \n CONFIGURATION\n -------------\n-- \n1.5.4.950.ga176\n"},{"id":"72937","messageId":"20080324194308.GE14002@coredump.intra.peff.net","threadId":"12841","inReplyTo":"47E7BDB2.3030304@dirk.my1.cc","subject":"[PATCH] Documentation: git-tag '-m' implies '-a'","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-03-24T19:43:08Z","receivedAt":"2008-03-24T19:43:08Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"From: Dirk Süsserott \n\nDescribed that '-a' is implied when '-m' or '-F' is present.\n---\nOn Mon, Mar 24, 2008 at 03:41:54PM +0100, Dirk Süsserott wrote:\n\n> Described that '-a' is implied when '-m' or '-F' is present.\n\nOh, I see you already took my suggestion before I made it. :)\n\nThe text looks good to me, but the patch would not apply here. I think\nthere are some wrapping issues, and it looks like some tabs have been\nmangled to spaces.\n\nAlso, it is generally a good idea to:\n - at least cc Junio on patch submissions to make sure he sees it\n - sign off your patch (either with commit -s or format-patch -s).\n\nHere is an unmangled version of the patch.\n\n Documentation/git-tag.txt | 7 +++++++\n 1 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt\nindex b62a3d1..c22fb71 100644\n--- a/Documentation/git-tag.txt\n+++ b/Documentation/git-tag.txt\n@@ -26,6 +26,9 @@ creates a 'tag' object, and requires the tag message. Unless\n `-m ` or `-F ` is given, an editor is started for the user to type\n in the tag message.\n \n+If `-m ` or `-F ` is given and `-a`, `-s`, and `-u `\n+are absent, `-a` is implied.\n+\n Otherwise just the SHA1 object name of the commit object is\n written (i.e. a lightweight tag).\n \n@@ -68,10 +71,14 @@ OPTIONS\n \tUse the given tag message (instead of prompting).\n \tIf multiple `-m` options are given, there values are\n \tconcatenated as separate paragraphs.\n+\tImplies `-a` if none of `-a`, `-s`, or `-u `\n+\tis given.\n \n -F ::\n \tTake the tag message from the given file. Use '-' to\n \tread the message from the standard input.\n+\tImplies `-a` if none of `-a`, `-s`, or `-u `\n+\tis given.\n \n CONFIGURATION\n -------------\n-- \n1.5.5.rc1.123.ge5f4e6\n"},{"id":"72943","messageId":"7v1w5zvqbw.fsf@gitster.siamese.dyndns.org","threadId":"12841","inReplyTo":"20080324194308.GE14002@coredump.intra.peff.net","subject":"Re: [PATCH] Documentation: git-tag '-m' implies '-a'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-24T20:07:15Z","receivedAt":"2008-03-24T20:07:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> From: Dirk Süsserott \n>\n> Described that '-a' is implied when '-m' or '-F' is present.\n> ---\n> On Mon, Mar 24, 2008 at 03:41:54PM +0100, Dirk Süsserott wrote:\n>\n>> Described that '-a' is implied when '-m' or '-F' is present.\n>\n> Oh, I see you already took my suggestion before I made it. :)\n>\n> The text looks good to me, but the patch would not apply here. I think\n> there are some wrapping issues, and it looks like some tabs have been\n> mangled to spaces.\n\nThanks for tidying up. It makes my life easier.\n\n> Also, it is generally a good idea to:\n> - at least cc Junio on patch submissions to make sure he sees it\n> - sign off your patch (either with commit -s or format-patch -s).\n\nHeh, and you did not sign it off when you forwarded? ;-)\n"},{"id":"72994","messageId":"20080325013842.GB15607@coredump.intra.peff.net","threadId":"12841","inReplyTo":"7v1w5zvqbw.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Documentation: git-tag '-m' implies '-a'","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-03-25T01:38:42Z","receivedAt":"2008-03-25T01:38:42Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Mar 24, 2008 at 01:07:15PM -0700, Junio C Hamano wrote:\n\n> Thanks for tidying up. It makes my life easier.\n\nNo problem.\n\n> > - at least cc Junio on patch submissions to make sure he sees it\n> > - sign off your patch (either with commit -s or format-patch -s).\n> \n> Heh, and you did not sign it off when you forwarded? ;-)\n\nHeh. Believe it or not, that actually did occur to me. However, I'm not\nreally sure what it means to do that. As you have made clear in the\npast, the signoff is _not_ \"this looks good to me, please apply\" but\nrather \"I am signing the Certificate of Origin.\"\n\nAnd while I can only assume that everything in such an obvious patch is\nkosher, it is _not_ true that:\n\n - I created or have the right to submit it under an open source\n license (DCO, part a)\n - The contribution was provided to me by somebody else who certified\n the above (DCO, part c)\n\nI'm not clear on what part (b) of the DCO means. Is it making a\njudgement that says \"even though I have no license on this, it is\nclearly a derivative work of git, which is GPL'd, and therefore it is\nGPL'd\"?\n\n-Peff\n"},{"id":"73051","messageId":"47E932B4.5060700@dirk.my1.cc","threadId":"12841","inReplyTo":"20080325013842.GB15607@coredump.intra.peff.net","subject":"Re: [PATCH] Documentation: git-tag '-m' implies '-a'","fromName":"Dirk Süsserott","fromEmail":"newsletter@dirk.my1.cc","sentAt":"2008-03-25T17:13:24Z","receivedAt":"2008-03-25T17:13:24Z","isPatch":true,"sender":{"key":"newsletter@dirk.my1.cc","avatar":null},"body":"Jeff, thanks for the advice and the corrections, I'll act on it.\nIt was my first submission and I'm handicapped in the way that I'm\nusing Windows. So I just pasted the patch into my Thunderbird window.\n\nThe git-send-email program doesn't work properly with Windows.\nEither the sendmail program isn't present (no shit sherlock ;-))\nor the Net/SMTP.pm module isn't found. I'm currently writing\na wrapper to bypass that. When I manage to figure the problem,\nI'll post a patch.\n\ngit-send-email for Windows doesn't accept the authorization\nswitches (--smtp-user, --smtp-pass) (despite the docs), so I've\neither to patch it or use a wrapper that adds them.\n\nDirk\n\n\nJeff King schrieb:\n> On Mon, Mar 24, 2008 at 01:07:15PM -0700, Junio C Hamano wrote:\n>\n> \n>> Thanks for tidying up. It makes my life easier.\n>> \n>\n> No problem.\n>\n> \n>>> - at least cc Junio on patch submissions to make sure he sees it\n>>> - sign off your patch (either with commit -s or format-patch -s).\n>>> \n>> Heh, and you did not sign it off when you forwarded? ;-)\n>> \n>\n> Heh. Believe it or not, that actually did occur to me. However, I'm not\n> really sure what it means to do that. As you have made clear in the\n> past, the signoff is _not_ \"this looks good to me, please apply\" but\n> rather \"I am signing the Certificate of Origin.\"\n>\n> And while I can only assume that everything in such an obvious patch is\n> kosher, it is _not_ true that:\n>\n> - I created or have the right to submit it under an open source\n> license (DCO, part a)\n> - The contribution was provided to me by somebody else who certified\n> the above (DCO, part c)\n>\n> I'm not clear on what part (b) of the DCO means. Is it making a\n> judgement that says \"even though I have no license on this, it is\n> clearly a derivative work of git, which is GPL'd, and therefore it is\n> GPL'd\"?\n>\n> -Peff\n>\n> \n"}]}